Alexander Lohnau
46feeda0cb
Remove unused default destructors
...
Overriding and defaulting them in the header doesn't make sense
For the dbus interfaces, we don't have any reasources to clean up or memory to be released. Meaning we can drop those lines too
2023-08-05 20:22:18 +00:00
Alexander Lohnau
83888412a9
Simplify and optimize some string usages
...
- Using QLatin1String when concatinating strings is faster, because they
are more lightweight. For the resulting string, we need to allocate
new memory anyway
- Use QLatin1String overloads where they are provided by Qt APIs
- Just use const char* for log messages, the quoting of QStrings is not
needed
- Make sure to reuse string results when possible
2023-08-05 20:22:18 +00:00
l10n daemon script
b356c742c2
GIT_SILENT Sync po/docbooks with svn
2023-08-05 01:46:30 +00:00
Albert Vaca Cintora
21b245cd71
Avoid starting more than 1 connection to the same device
...
Since we close old connections when a new connection is received, due to
race conditions we could end up without a valid connection in this case.
Equivalent to https://invent.kde.org/network/kdeconnect-android/-/merge_requests/382
2023-08-04 08:25:45 +00:00
l10n daemon script
d2d9c224ae
GIT_SILENT Sync po/docbooks with svn
2023-08-04 01:46:44 +00:00
Albert Vaca Cintora
abb6dfcc6e
plugins: Add context-aware logging in case of errors
...
Also clean up some unneeded statements
2023-08-03 20:54:38 +02:00
Alexander Lohnau
1631ada5b3
Simplify KDEConnectPlugin::recievePacket
...
- We do not need the return type. If a plugin declares it can handle the
packet it should do so. We don't have any fallback logic in place and
the packet types are namespaced with the plugin IDs anyway.
- Provide a default implementation with a warning, not all plugins need
to overwrite this
2023-08-03 20:49:44 +02:00
l10n daemon script
2edc139522
GIT_SILENT Sync po/docbooks with svn
2023-08-03 02:07:02 +00:00
l10n daemon script
d39bbd7e99
GIT_SILENT Sync po/docbooks with svn
2023-08-02 01:54:18 +00:00
l10n daemon script
4dd5528bb5
GIT_SILENT Sync po/docbooks with svn
2023-08-01 01:57:11 +00:00
l10n daemon script
b0a122089d
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-08-01 01:39:50 +00:00
Albert Vaca Cintora
94903b6957
Actually fix the MacOS build
2023-07-31 23:04:08 +02:00
Albert Vaca Cintora
829fb8db79
Remove .h file in target_sources
2023-07-31 22:08:28 +02:00
Albert Vaca Cintora
135e3df17b
Hopefully fix the MacOS build
2023-07-31 22:01:32 +02:00
Albert Vaca Cintora
b82b88840d
Disable mpriscontrol plugin on Mac
2023-07-31 11:19:06 +02:00
Alexander Lohnau
b165a03909
plugins/pausemusic: Clean up/modernize CMake code
2023-07-31 06:39:08 +00:00
Alexander Lohnau
6300e9d0c6
Enable Qt6 CI
2023-07-31 06:39:08 +00:00
Alexander Lohnau
6fbecf28da
Remove trailing / for KPluginMetaData::findPlugins
...
This is not needed and pretty much all usages of this method don't do it too
2023-07-31 06:39:08 +00:00
Alexander Lohnau
399d279e83
KDEConnectPluginConfig: Remove unneeded check for delete
...
Deleting a nullptr is a noop
2023-07-31 06:39:08 +00:00
Alexander Lohnau
b54f0e2467
Modernize plugin loading code
...
Use the new utility-methods and improve the logging.
2023-07-31 06:39:08 +00:00
l10n daemon script
20d8c41a4f
GIT_SILENT Sync po/docbooks with svn
2023-07-31 02:08:00 +00:00
l10n daemon script
5485f743e0
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-31 01:39:24 +00:00
Phani Pavan Kambhampati
c5b955fe10
Changed KCM to launch in system settings
...
KCM used to open in a separate window, changed that behaviour to launch in system settings when launched via the plasmoid.
BUG: 446337
2023-07-30 07:30:52 +00:00
Albert Vaca Cintora
b454a6f880
Fix memory leak due to m_receivedIdentityPackets growing
...
We didn't always remove entries from m_receivedIdentityPackets indexed
by sockets that got deleted.
2023-07-30 07:29:52 +00:00
Alexander Lohnau
dd5e61ab0a
KdeConnectKcm: Do not make generated UI class instance a ptr
2023-07-30 07:27:45 +00:00
Alexander Lohnau
b54e739753
Do not make m_ui instance a ptr
...
By having it as a simple member variable, we do not need to take care of deleting it manually
2023-07-30 07:27:45 +00:00
Alexander Lohnau
2e67f95017
Add explicit moc includes to cpp files
...
The rationale is explained in https://planet.kde.org/friedrich-kossebau-2023-06-28-include-also-moc-files-of-headers/
In case of KDEConnect, it impressively speeds up compilation. Before it
took 390 seconds on a clean build and with this change it took 330 seconds.
This is due to the mocs_compilation having to include the header files
and thus all their headers. Due to the lots of small plugins we have,
this means that the same headers must be compiled plenty of times.
When we include the moc files directly in the C++ file, they are already
available.
2023-07-30 07:27:45 +00:00
l10n daemon script
0d04fa98e9
GIT_SILENT Sync po/docbooks with svn
2023-07-30 01:49:01 +00:00
l10n daemon script
1ff98bc580
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-30 01:37:54 +00:00
Albert Vaca Cintora
70f6ebf6d5
Check for errors in KdeConnectConfig
2023-07-29 10:36:12 +02:00
Albert Vaca Cintora
675d1c1262
Make it compile and don't use .data() on temporary QByteArray
2023-07-29 10:36:12 +02:00
Edward Kigwana
20e7790773
core: sslhelper: Check return of openssl functions
...
Use unique_ptr to manage object lifetime and also avoid use of deprecated
MACROS and functions.
2023-07-29 10:36:09 +02:00
Edward Kigwana
1bbd9ff6e3
core: sslhelper: Extern openssl headers and add getSslError helper
...
openssl headers include C headers prior to #ifdef __cplusplus.
Signed-off-by: Edward Kigwana <ekigwana@gmail.com>
2023-07-29 10:35:37 +02:00
Albert Vaca Cintora
d0786d1b62
Simplify using QSslKey
2023-07-29 10:35:37 +02:00
Albert Vaca Cintora
d948d882aa
Replace QCA with a simple OpenSSL wrapper
2023-07-29 08:19:17 +00:00
l10n daemon script
956c88c964
GIT_SILENT Sync po/docbooks with svn
2023-07-29 01:46:13 +00:00
l10n daemon script
297bc8cd73
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-29 01:37:09 +00:00
l10n daemon script
6d4b19c07b
GIT_SILENT Sync po/docbooks with svn
2023-07-28 01:54:26 +00:00
l10n daemon script
885d311b31
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-28 01:41:47 +00:00
l10n daemon script
7de430c19f
GIT_SILENT Sync po/docbooks with svn
2023-07-27 01:46:42 +00:00
l10n daemon script
d9f7fc6918
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-27 01:37:50 +00:00
Albert Vaca Cintora
74e9cdbf12
Do not get deviceId by reference
2023-07-26 21:40:52 +02:00
l10n daemon script
5af0a74f11
GIT_SILENT Sync po/docbooks with svn
2023-07-26 01:48:46 +00:00
l10n daemon script
a0b0477b13
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-07-26 01:38:38 +00:00
Alexander Lohnau
eabb280d9c
Fix runcommand page not being able to be displayed in Qt6
2023-07-25 18:29:38 +02:00
Alexander Lohnau
6d1a7c613b
Fix PluginInfoPage not being able to be displayed in Qt6
2023-07-25 18:29:38 +02:00
Alexander Lohnau
a3fc5eaf9f
Make optional bluetooth and MDNS build against KF6 too
2023-07-25 18:29:38 +02:00
Alexander Lohnau
e00ffbb4f6
Use versionless cmake variable for KF requirements
...
Also, adjust find_package calls that are hidden behind a feature flag
2023-07-25 18:29:38 +02:00
Alexander Lohnau
ba063a5177
Port away from deprecated ECMQMLModules module
2023-07-25 18:29:38 +02:00
Alexander Lohnau
a1195a72a3
Use versionless Qt targets where possible
...
We depend on 5.15 which allows us to use those
2023-07-25 18:29:38 +02:00