tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4207 commits 81 branches 117 tags 12 MiB
Commit graph

1472 commits

Author SHA1 Message Date
l10n daemon script
871fcf0cd1 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-11-17 01:18:34 +00:00
ivan tkachenko
5db4263af6
Port implicit default content items to use contentItem: property 
See also
https://invent.kde.org/frameworks/kirigami/-/merge_requests/1338
and
https://invent.kde.org/frameworks/kirigami/-/merge_requests/1340
 2023-11-09 00:06:14 +03:00
l10n daemon script
d3c2d52c3b SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-11-07 02:12:13 +00:00
Nicolas Fella
0343c9401d Port to new KNotifications action API 2023-11-04 13:40:22 +01:00
l10n daemon script
4b1b1b9b14 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-11-04 11:52:33 +00:00
l10n daemon script
b042e1f78a SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-10-25 01:23:11 +00:00
l10n daemon script
acdd83e100 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-10-21 01:20:48 +00:00
l10n daemon script
1e3882c284 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-10-12 01:20:32 +00:00
l10n daemon script
028f1c938d SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-09-25 01:22:07 +00:00
Albert Vaca Cintora
d721f72a9b Iterate KFilePlacesModel instead of using closestItem to remove SFTP entries 
Fixes bug where we could miss entries due to `closestItem()` skipping hidden items. It is also more performant.

BUG: 461872
 2023-09-22 19:51:25 +00:00
Albert Vaca Cintora
6df3d093e1 Make sure %1 is kept in the final string 2023-09-18 23:31:38 +02:00
Fushan Wen
b43432326b
QImage: use rvalue overloads more 
to reuse internal buffers
 2023-09-16 20:01:55 +08:00
Albert Vaca Cintora
66cf7093fb Fix SFTP plugin, m_mounter was not initialized 
BUG: 474552
 2023-09-16 01:11:00 +02:00
Albert Vaca Cintora
cdcf44efa8 Remove photo plugin 
As discussed in Matrix and BUG: 474121 this plugin is confusing (because
it doesn't actually take a photo, it just launches the camera on your
phone) and its use case can be covered by taking a photo and sharing it,
which only requires a couple extra clicks.
 2023-09-15 23:04:17 +00:00
Albert Vaca Cintora
89548932a6 Fix remote keyboard sending "space" when pressing space 
I believe this was broken in https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/543

BUG: 473956
 2023-09-07 17:55:02 +00:00
Albert Vaca Cintora
4d5474db7b Fix SFTP plugin on Windows 
Broken by https://invent.kde.org/network/kdeconnect-android/-/merge_requests/320
 2023-09-06 04:44:04 +02:00
l10n daemon script
b7982c3724 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-08-29 01:36:14 +00:00
Albert Vaca Cintora
5a27c93538 Windows MPRIS: Add a "default player" entry 
This sends generic multimedia keyboard events, since the implementation
using GlobalSystemMediaTransportControlsSessionManager had some problems:
the SessionsChanged event doesn't work on recent Windows versions,
plus many players don't implement this API (eg: VLC, Windows Media).
 2023-08-28 17:31:26 +00:00
Alexander Lohnau
cfde9ced77 Also use QLatin1String::arg in remaining places 
This is more readable, slightly faster at runtime and results in a slightly smaller binary size
 2023-08-28 17:20:46 +00:00
Alexander Lohnau
88d89e7211 Use std::unique_ptr for pimpl classes 
This is consistent with what we do in frameworks
 2023-08-28 17:20:46 +00:00
Alexander Lohnau
c3b4103d0c plugins/sftp: Do not use pimpl for d-ptr 
This doesn't make sense, because it is a plugin class and not exported
 2023-08-28 17:20:46 +00:00
Alexander Lohnau
69d6c17214 plugins: Use QLatin1String::arg for faster and simpler string concatination 
Using an infix with .arg() is simpler than having two string literals
 2023-08-28 17:20:46 +00:00
Albert Vaca Cintora
7bbc8b0e7d Reformat sshfs arguments so they are easier to read 2023-08-24 18:21:42 +02:00
Albert Vaca Cintora
45615f8acf Cleanup signals and slots in SftpPlugin 2023-08-24 18:15:26 +02:00
Fushan Wen
c4ce19e9cd
plugins/sendnotifications: add support for Windows 2023-08-21 09:52:23 +08:00
Nicolas Fella
70857972fc Add missing QtWidgets link 2023-08-19 00:17:05 +02:00
Albert Vaca Cintora
ed7758f996 Do not forward kdeconnect notifications 2023-08-14 10:47:12 +02:00
Albert Vaca Cintora
b8b30ba571 Use libdbus instead of GIO to listen for notifications 
This fixes the `Error calling StartServiceByName for org.gtk.vfs.Daemon` message and subsequent crash if both the Receive Notifications plugin and Send Notifications plugin where enabled and we received a notification.

Most of the code comes from the SailfishConnect implementation here: https://github.com/R1tschY/harbour-sailfishconnect/blob/master/plugins/sf_sendnotifications/notificationslistener.cpp
 2023-08-13 19:43:59 +00:00
Albert Vaca Cintora
97f245767d Somehow fix Qt6 build 2023-08-09 20:26:57 +02:00
Albert Vaca Cintora
5cc2043c35 Update old-style connect/disconnect where possible 2023-08-08 22:51:30 +02:00
Albert Vaca Cintora
b97cbaa5d0 Remove duplicate target_sources 2023-08-08 17:01:21 +02:00
Alexander Lohnau
ed1e24d231 kdeconnect_add_plugin: Autogenerate logging category 
This is far less code and allows for an easier enforcing of standards, for
example the name of the log identifiers which were adjusted in a few cases.

Also clean up unused includes when noticed.
 2023-08-07 19:47:41 +02:00
Alexander Lohnau
7feb3bdd0d Remove unneeded setting of C++17 standard 2023-08-07 19:47:15 +02:00
Alexander Lohnau
cdc8428542 Create kdeconnect_add_kcm cmake function 
This way, the namespace info is not duplicated within the buildsystem and we have a more reasonable place to put the QML file install into
 2023-08-07 19:28:37 +02:00
Alexander Lohnau
e598a997e7 Use initializer list syntax where appropiate 2023-08-07 19:28:37 +02:00
Alexander Lohnau
c5e7fdb5e4 plugins: Prefer using statements with baseclass over empty constructor 
Those plugins re really simple and don't need any initialization logic.
With the using statement, we do not need to add a constructor and pass the parent/args to the baseclass
 2023-08-07 19:28:37 +02:00
Alexander Lohnau
405f61bf85 Discard unused params more elegantly 
By commenting out the parameter name, we get compile-time checks
Also, we can omit them for slots and Qt will not forward the parameters.

In case we had TODOs next to the code, I kept the Q_UNUSED statements
for now.
 2023-08-05 20:22:18 +00:00
Alexander Lohnau
46feeda0cb Remove unused default destructors 
Overriding and defaulting them in the header doesn't make sense

For the dbus interfaces, we don't have any reasources to clean up or memory to be released. Meaning we can drop those lines too
 2023-08-05 20:22:18 +00:00
Alexander Lohnau
83888412a9 Simplify and optimize some string usages 
- Using QLatin1String when concatinating strings is faster, because they
  are more lightweight. For the resulting string, we need to allocate
  new memory anyway
- Use QLatin1String overloads where they are provided by Qt APIs
- Just use const char* for log messages, the quoting of QStrings is not
  needed
- Make sure to reuse string results when possible
 2023-08-05 20:22:18 +00:00
Albert Vaca Cintora
abb6dfcc6e plugins: Add context-aware logging in case of errors 
Also clean up some unneeded statements
 2023-08-03 20:54:38 +02:00
Alexander Lohnau
1631ada5b3 Simplify KDEConnectPlugin::recievePacket 
- We do not need the return type. If a plugin declares it can handle the
  packet it should do so. We don't have any fallback logic in place and
  the packet types are namespaced with the plugin IDs anyway.

- Provide a default implementation with a warning, not all plugins need
  to overwrite this
 2023-08-03 20:49:44 +02:00
l10n daemon script
b0a122089d SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-08-01 01:39:50 +00:00
Albert Vaca Cintora
94903b6957 Actually fix the MacOS build 2023-07-31 23:04:08 +02:00
Albert Vaca Cintora
829fb8db79 Remove .h file in target_sources 2023-07-31 22:08:28 +02:00
Albert Vaca Cintora
135e3df17b Hopefully fix the MacOS build 2023-07-31 22:01:32 +02:00
Albert Vaca Cintora
b82b88840d Disable mpriscontrol plugin on Mac 2023-07-31 11:19:06 +02:00
Alexander Lohnau
b165a03909 plugins/pausemusic: Clean up/modernize CMake code 2023-07-31 06:39:08 +00:00
Alexander Lohnau
6300e9d0c6 Enable Qt6 CI 2023-07-31 06:39:08 +00:00
Alexander Lohnau
b54e739753 Do not make m_ui instance a ptr 
By having it as a simple member variable, we do not need to take care of deleting it manually
 2023-07-30 07:27:45 +00:00
Alexander Lohnau
2e67f95017 Add explicit moc includes to cpp files 
The rationale is explained in https://planet.kde.org/friedrich-kossebau-2023-06-28-include-also-moc-files-of-headers/

In case of KDEConnect, it impressively speeds up compilation. Before it
took 390 seconds on a clean build and with this change it took 330 seconds.
This is due to the mocs_compilation having to include the header files
and thus all their headers. Due to the lots of small plugins we have,
this means that the same headers must be compiled plenty of times.
When we include the moc files directly in the C++ file, they are already
available.
 2023-07-30 07:27:45 +00:00