Commit graph

4109 commits

Author SHA1 Message Date
Alexander Lohnau
88d89e7211 Use std::unique_ptr for pimpl classes
This is consistent with what we do in frameworks
2023-08-28 17:20:46 +00:00
Alexander Lohnau
c3b4103d0c plugins/sftp: Do not use pimpl for d-ptr
This doesn't make sense, because it is a plugin class and not exported
2023-08-28 17:20:46 +00:00
Alexander Lohnau
a1a7e57011 Daemon: Do not return value by const ref
We operate on a QSharedData object and thus can trivially make a copy. We generally don't use use const refs as return values in KDE APIs unless there is a compelling reason to do so
2023-08-28 17:20:46 +00:00
Alexander Lohnau
890299943d KDEConnectPlugin: Remove Q_SLOTS for virtual methods
We call this as a normal method and don't need them exposed
2023-08-28 17:20:46 +00:00
Alexander Lohnau
16adb6a298 PluginLoader: Improve const corretness, remove unneeded qAsConst
Because they are member variables, we do not need qAsConst in a method that is declared as const
2023-08-28 17:20:46 +00:00
Alexander Lohnau
b70de1eb21 kcmplugin: Do not use d-ptr for trivial members that are fully qualified
Also, make this for the most part header only, because it is just a utility class.
We could make this entirely header only, but it is not worth it.
2023-08-28 17:20:46 +00:00
Alexander Lohnau
473589cd32 Networkpacket: Let Qt generate property setters
We don't need to call this explicitly, it is only called by assigning properties
2023-08-28 17:20:46 +00:00
Alexander Lohnau
13ff8832fb fileitemactionplugin: Use lambda connect to avoid ugly workarounds
Setting properties and using QObject::sender is quite ugly API and not needed in modern code
2023-08-28 17:20:46 +00:00
Alexander Lohnau
01300d8f47 kio: Use kcoreaddons_add_plugin and correct plugin path 2023-08-28 17:20:46 +00:00
Alexander Lohnau
7a5ca725fc kio: Remove empty string from listing array 2023-08-28 17:20:46 +00:00
Alexander Lohnau
69d6c17214 plugins: Use QLatin1String::arg for faster and simpler string concatination
Using an infix with .arg() is simpler than having two string literals
2023-08-28 17:20:46 +00:00
Albert Vaca Cintora
5e270fea2e Error checking 2023-08-28 17:08:18 +00:00
Aleix Pol Gonzalez
1b3e8db72f Fixes from code review 2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
5e225a23cb Add MDNS e2e test 2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
80c34b28ac Enable MDNS by default 2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
bbfbd53123 Implement IP match function 2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
b3ac0df630 Better handling of network changes for MDNS 2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
3485e3aa44 Replace KDNSSD with mdns.h
KDNSSD only works with Avahi (so, only on Linux) while mdns.h is a
header-only library [1] that implements mdns from scratch and should
work on all platforms.

[1] https://github.com/mjansson/mdns
2023-08-28 17:08:18 +00:00
Albert Vaca Cintora
132ae2ca7c Remove unused stuff 2023-08-28 18:48:04 +02:00
l10n daemon script
ec22001648 GIT_SILENT Sync po/docbooks with svn 2023-08-28 02:06:40 +00:00
l10n daemon script
2e1d146bed GIT_SILENT Sync po/docbooks with svn 2023-08-27 01:49:37 +00:00
l10n daemon script
cfd0a0899d GIT_SILENT Sync po/docbooks with svn 2023-08-26 01:46:59 +00:00
l10n daemon script
37b0474665 GIT_SILENT Sync po/docbooks with svn 2023-08-25 01:46:49 +00:00
Albert Vaca Cintora
7bbc8b0e7d Reformat sshfs arguments so they are easier to read 2023-08-24 18:21:42 +02:00
Albert Vaca Cintora
45615f8acf Cleanup signals and slots in SftpPlugin 2023-08-24 18:15:26 +02:00
l10n daemon script
1ef9d7e2a0 GIT_SILENT Sync po/docbooks with svn 2023-08-23 01:46:45 +00:00
l10n daemon script
ee94eb4b83 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-08-23 01:37:46 +00:00
Fushan Wen
c4ce19e9cd
plugins/sendnotifications: add support for Windows 2023-08-21 09:52:23 +08:00
l10n daemon script
cf92bacf02 GIT_SILENT Sync po/docbooks with svn 2023-08-21 01:45:53 +00:00
l10n daemon script
a9c23bd637 GIT_SILENT Sync po/docbooks with svn 2023-08-20 01:46:21 +00:00
l10n daemon script
e3257907ab SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-08-20 01:37:53 +00:00
Nicolas Fella
70857972fc Add missing QtWidgets link 2023-08-19 00:17:05 +02:00
Nicolas Fella
0baeece353 Port to KStatusNotifierItem framework 2023-08-16 23:05:44 +00:00
Heiko Becker
341b5dc006 GIT_SILENT Update Appstream for new release
(cherry picked from commit 394dba3482)
2023-08-16 23:25:06 +02:00
l10n daemon script
aab1d36590 GIT_SILENT Sync po/docbooks with svn 2023-08-15 01:47:26 +00:00
Albert Vaca Cintora
ed7758f996 Do not forward kdeconnect notifications 2023-08-14 10:47:12 +02:00
l10n daemon script
c8c2fd9bd5 GIT_SILENT Sync po/docbooks with svn 2023-08-14 01:46:08 +00:00
Albert Vaca Cintora
b8b30ba571 Use libdbus instead of GIO to listen for notifications
This fixes the `Error calling StartServiceByName for org.gtk.vfs.Daemon` message and subsequent crash if both the Receive Notifications plugin and Send Notifications plugin where enabled and we received a notification.

Most of the code comes from the SailfishConnect implementation here: https://github.com/R1tschY/harbour-sailfishconnect/blob/master/plugins/sf_sendnotifications/notificationslistener.cpp
2023-08-13 19:43:59 +00:00
l10n daemon script
776a5eaccb GIT_SILENT Sync po/docbooks with svn 2023-08-13 01:45:28 +00:00
l10n daemon script
491619bd63 GIT_SILENT Sync po/docbooks with svn 2023-08-12 01:48:35 +00:00
l10n daemon script
0d06c6b905 GIT_SILENT Sync po/docbooks with svn 2023-08-11 01:44:42 +00:00
l10n daemon script
fd62bfe5e8 GIT_SILENT Sync po/docbooks with svn 2023-08-10 01:46:21 +00:00
Albert Vaca Cintora
97f245767d Somehow fix Qt6 build 2023-08-09 20:26:57 +02:00
l10n daemon script
7fae315fda GIT_SILENT Sync po/docbooks with svn 2023-08-09 01:47:58 +00:00
Albert Vaca Cintora
5cc2043c35 Update old-style connect/disconnect where possible 2023-08-08 22:51:30 +02:00
Albert Vaca Cintora
a467247f08 Only use proxy signals for Q_PROPERTY NOTIFY
In other cases we can just connect to the signal from the parent class
2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
2cfde60ab9 Fix clazy warning about re-defining signal 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
f5b4a174e4 Use nullptr instead of NULL 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
fc0bd2290c Use values passed to the signal instead of getting them again 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
b97cbaa5d0 Remove duplicate target_sources 2023-08-08 17:01:21 +02:00