tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4222 commits 81 branches 117 tags 12 MiB
Commit graph

4222 commits

This branch
This branch
All branches
Author SHA1 Message Date
Albert Vaca Cintora
b8b30ba571 Use libdbus instead of GIO to listen for notifications 
This fixes the `Error calling StartServiceByName for org.gtk.vfs.Daemon` message and subsequent crash if both the Receive Notifications plugin and Send Notifications plugin where enabled and we received a notification.

Most of the code comes from the SailfishConnect implementation here: https://github.com/R1tschY/harbour-sailfishconnect/blob/master/plugins/sf_sendnotifications/notificationslistener.cpp
 2023-08-13 19:43:59 +00:00
l10n daemon script
776a5eaccb GIT_SILENT Sync po/docbooks with svn 2023-08-13 01:45:28 +00:00
l10n daemon script
491619bd63 GIT_SILENT Sync po/docbooks with svn 2023-08-12 01:48:35 +00:00
l10n daemon script
0d06c6b905 GIT_SILENT Sync po/docbooks with svn 2023-08-11 01:44:42 +00:00
l10n daemon script
fd62bfe5e8 GIT_SILENT Sync po/docbooks with svn 2023-08-10 01:46:21 +00:00
Albert Vaca Cintora
97f245767d Somehow fix Qt6 build 2023-08-09 20:26:57 +02:00
l10n daemon script
7fae315fda GIT_SILENT Sync po/docbooks with svn 2023-08-09 01:47:58 +00:00
Albert Vaca Cintora
5cc2043c35 Update old-style connect/disconnect where possible 2023-08-08 22:51:30 +02:00
Albert Vaca Cintora
a467247f08 Only use proxy signals for Q_PROPERTY NOTIFY 
In other cases we can just connect to the signal from the parent class
 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
2cfde60ab9 Fix clazy warning about re-defining signal 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
f5b4a174e4 Use nullptr instead of NULL 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
fc0bd2290c Use values passed to the signal instead of getting them again 2023-08-08 20:24:22 +02:00
Albert Vaca Cintora
b97cbaa5d0 Remove duplicate target_sources 2023-08-08 17:01:21 +02:00
Fushan Wen
47cb369e01 Add i18n context for "Ring device" 2023-08-08 16:12:29 +08:00
l10n daemon script
95b92ecf52 GIT_SILENT Sync po/docbooks with svn 2023-08-08 01:48:10 +00:00
Alexander Lohnau
ed1e24d231 kdeconnect_add_plugin: Autogenerate logging category 
This is far less code and allows for an easier enforcing of standards, for
example the name of the log identifiers which were adjusted in a few cases.

Also clean up unused includes when noticed.
 2023-08-07 19:47:41 +02:00
Alexander Lohnau
7feb3bdd0d Remove unneeded setting of C++17 standard 2023-08-07 19:47:15 +02:00
Alexander Lohnau
cdc8428542 Create kdeconnect_add_kcm cmake function 
This way, the namespace info is not duplicated within the buildsystem and we have a more reasonable place to put the QML file install into
 2023-08-07 19:28:37 +02:00
Alexander Lohnau
e598a997e7 Use initializer list syntax where appropiate 2023-08-07 19:28:37 +02:00
Alexander Lohnau
c5e7fdb5e4 plugins: Prefer using statements with baseclass over empty constructor 
Those plugins re really simple and don't need any initialization logic.
With the using statement, we do not need to add a constructor and pass the parent/args to the baseclass
 2023-08-07 19:28:37 +02:00
l10n daemon script
4e3660ff0d GIT_SILENT Sync po/docbooks with svn 2023-08-07 02:06:40 +00:00
l10n daemon script
22c423575e SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-08-07 01:50:26 +00:00
Albert Vaca Cintora
034ecd24c7 Expand comment based on explanation in https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/584 2023-08-06 19:48:23 +00:00
Weixuan Xiao
7ce39e93af Remove QIcon loading to avoid pre-stage D-Bus session cache 
Use a QPixmap icon and black color for all texts in the QSplashScreen
 2023-08-06 19:48:23 +00:00
Weixuan Xiao
621ae3e007 Fix potential race condition 2023-08-06 19:48:23 +00:00
l10n daemon script
e765fa5d12 GIT_SILENT Sync po/docbooks with svn 2023-08-06 01:49:07 +00:00
Alexander Lohnau
49a51e2d27 Handle qDDebug/qCWarning categories more consistently 
We can always provide a function rather than a value.
This is what we do in most places already and is consistent with the
rest of KDE.
This gets compiled to the same code.

```cpp
explicit QLoggingCategoryMacroHolder(const QLoggingCategory &cat)
{
    if (IsOutputEnabled)
        init(cat);
}
explicit QLoggingCategoryMacroHolder(QMessageLogger::CategoryFunction catfunc)
{
    if (IsOutputEnabled)
        init(catfunc());
}
```
 2023-08-05 20:22:18 +00:00
Alexander Lohnau
ee2e782748 CompositeUploadJob: Use lambda connect, log errors 2023-08-05 20:22:18 +00:00
Alexander Lohnau
405f61bf85 Discard unused params more elegantly 
By commenting out the parameter name, we get compile-time checks
Also, we can omit them for slots and Qt will not forward the parameters.

In case we had TODOs next to the code, I kept the Q_UNUSED statements
for now.
 2023-08-05 20:22:18 +00:00
Alexander Lohnau
46feeda0cb Remove unused default destructors 
Overriding and defaulting them in the header doesn't make sense

For the dbus interfaces, we don't have any reasources to clean up or memory to be released. Meaning we can drop those lines too
 2023-08-05 20:22:18 +00:00
Alexander Lohnau
83888412a9 Simplify and optimize some string usages 
- Using QLatin1String when concatinating strings is faster, because they
  are more lightweight. For the resulting string, we need to allocate
  new memory anyway
- Use QLatin1String overloads where they are provided by Qt APIs
- Just use const char* for log messages, the quoting of QStrings is not
  needed
- Make sure to reuse string results when possible
 2023-08-05 20:22:18 +00:00
l10n daemon script
b356c742c2 GIT_SILENT Sync po/docbooks with svn 2023-08-05 01:46:30 +00:00
Albert Vaca Cintora
21b245cd71 Avoid starting more than 1 connection to the same device 
Since we close old connections when a new connection is received, due to
race conditions we could end up without a valid connection in this case.

Equivalent to https://invent.kde.org/network/kdeconnect-android/-/merge_requests/382
 2023-08-04 08:25:45 +00:00
l10n daemon script
d2d9c224ae GIT_SILENT Sync po/docbooks with svn 2023-08-04 01:46:44 +00:00
Albert Vaca Cintora
abb6dfcc6e plugins: Add context-aware logging in case of errors 
Also clean up some unneeded statements
 2023-08-03 20:54:38 +02:00
Alexander Lohnau
1631ada5b3 Simplify KDEConnectPlugin::recievePacket 
- We do not need the return type. If a plugin declares it can handle the
  packet it should do so. We don't have any fallback logic in place and
  the packet types are namespaced with the plugin IDs anyway.

- Provide a default implementation with a warning, not all plugins need
  to overwrite this
 2023-08-03 20:49:44 +02:00
l10n daemon script
2edc139522 GIT_SILENT Sync po/docbooks with svn 2023-08-03 02:07:02 +00:00
l10n daemon script
d39bbd7e99 GIT_SILENT Sync po/docbooks with svn 2023-08-02 01:54:18 +00:00
l10n daemon script
4dd5528bb5 GIT_SILENT Sync po/docbooks with svn 2023-08-01 01:57:11 +00:00
l10n daemon script
b0a122089d SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-08-01 01:39:50 +00:00
Albert Vaca Cintora
94903b6957 Actually fix the MacOS build 2023-07-31 23:04:08 +02:00
Albert Vaca Cintora
829fb8db79 Remove .h file in target_sources 2023-07-31 22:08:28 +02:00
Albert Vaca Cintora
135e3df17b Hopefully fix the MacOS build 2023-07-31 22:01:32 +02:00
Albert Vaca Cintora
b82b88840d Disable mpriscontrol plugin on Mac 2023-07-31 11:19:06 +02:00
Alexander Lohnau
b165a03909 plugins/pausemusic: Clean up/modernize CMake code 2023-07-31 06:39:08 +00:00
Alexander Lohnau
6300e9d0c6 Enable Qt6 CI 2023-07-31 06:39:08 +00:00
Alexander Lohnau
6fbecf28da Remove trailing / for KPluginMetaData::findPlugins 
This is not needed and pretty much all usages of this method don't do it too
 2023-07-31 06:39:08 +00:00
Alexander Lohnau
399d279e83 KDEConnectPluginConfig: Remove unneeded check for delete 
Deleting a nullptr is a noop
 2023-07-31 06:39:08 +00:00
Alexander Lohnau
b54f0e2467 Modernize plugin loading code 
Use the new utility-methods and improve the logging.
 2023-07-31 06:39:08 +00:00
l10n daemon script
20d8c41a4f GIT_SILENT Sync po/docbooks with svn 2023-07-31 02:08:00 +00:00