f1843cb492
Better patch to replace !218. - Auto and quick detection of previous D-Bus instance; - Remove private D-Bus compile definition, only use it on macOS without an existing D-Bus instance; - Safe reboot after crashes because the indicator is not relating on the kdeconnectd to run a D-Bus session; - Safe exit after clicking on `Quit` in the systray. More details in commit logs: Only enable private D-Bus on macOS because the other platforms do not need them. The app should be able to easily detect the session bus from the env DBUS_LAUNCHD_SESSION_BUS_SOCKET from launchd through launchctl. Because https://gitlab.freedesktop.org/dbus/dbus/-/blob/master/dbus/dbus-sysdeps-unix.c#L4392 shows that it is the only probing method on macOS with launchd. The D-Bus session bus can be easily found from launchd/launchctl with DBUS_LAUNCHD_SESSION_BUS_SOCKET env. It can be an external one (installed from HomeBrew) or an internal one (launched by a previous instance followed by a crash). The indicator helper on macOS can now automatically detect whether we can use a potentially (with launchd/launchctl env set, or KDE Connect macOS private_bus_address set) existed and usable session bus. If previous bus is usable, just try to launch the kdeconnectd with us. Otherwise, launch a private D-Bus daemon, export the launchd/launchctl env, and run a kdeconnectd instance. Everything works better and quicker now :) |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| kdeconnect_mpriscontrol.json | ||
| mpriscontrolplugin-win.cpp | ||
| mpriscontrolplugin-win.h | ||
| mpriscontrolplugin.cpp | ||
| mpriscontrolplugin.h | ||
| org.freedesktop.DBus.Properties.xml | ||
| org.mpris.MediaPlayer2.Player.xml | ||
| org.mpris.MediaPlayer2.xml | ||
| README | ||
This plugin controls the playback of mpris-enabled applications in this device, commanded by its counterpart in the other device that acts as a remote control. That means both plugins are not symmetrical. This plugins receives and sends packages with type kdeconnect.mpris. It keeps a list of detected players it can control via MPRIS. When it receives a package that contains the boolean "requestPlayerList" set to true, it will send back the list of players in an array named "playerList". If a new player is detected or a known one dissappears, it should also send this list. Note that players are identified only by its name (its MPRIS Identity), so there can not be two players with the same display name. This plugins also reports the current song, extracted from MPRIS Metadata. It should send it when it changes or when receiving a package containing a boolean "requestNowPlaying" set to true. The remote devices can send packages with commands to one of the players. Those packages will contain a string "player" with the name of the player they want to command and a string "action" with the name of an MPRIS call (like "Play", "Next"...). This plugin can also control the system volume. The peer device can send a package with "requestVolume" set to true to ask for the current volume, or send a package with "setVolume" set to an integer in the range [0,100] to change it.