tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kdeconnect-kde/plugins
History
Simon Redman 74ba660cad Cache and delete old ConversationsDbusInterfaces to avoid memory leak 
Summary:
After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one

This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?

Test Plan:
- Run daemon
- Hopefully experience no crashes after many phone reconnects

Reviewers: #kde_connect, apol, albertvaka

Reviewed By: #kde_connect, apol, albertvaka

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16553
2019-01-21 12:01:26 -07:00
..
battery SVN_SILENT made messages (.desktop file) - always resolve ours 2018-11-21 05:40:27 +01:00
clipboard SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-06 05:29:27 +01:00
contacts SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
findmyphone SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
findthisdevice SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
lockdevice SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
mousepad SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
mpriscontrol [mpriscontrol] add primitive windows support 2018-12-21 19:24:06 +01:00
mprisremote SVN_SILENT made messages (.desktop file) - always resolve ours 2018-10-24 05:55:51 +02:00
notifications SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
pausemusic SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
ping SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-06 05:29:27 +01:00
remotecommands SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
remotecontrol SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
remotekeyboard Don't make signals const 2018-11-26 13:23:37 +01:00
remotesystemvolume SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-14 05:31:55 +01:00
runcommand SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
screensaver-inhibit SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
sendnotifications Fix container detach warnings from clazy 2018-11-26 13:21:39 +01:00
sftp Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all 2019-01-16 14:56:24 +01:00
share Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
sms Cache and delete old ConversationsDbusInterfaces to avoid memory leak 2019-01-21 12:01:26 -07:00
systemvolume SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-09 05:31:18 +01:00
telephony SVN_SILENT made messages (.desktop file) - always resolve ours 2018-11-21 05:40:27 +01:00
CMakeLists.txt [mpriscontrol] add primitive windows support 2018-12-21 19:24:06 +01:00
kdeconnect.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2019-01-06 05:29:27 +01:00
kdeconnect_plugin.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-10-10 06:19:16 +02:00
Messages.sh Figure out Messages.sh after code refactoring 2014-06-17 18:45:47 +02:00
README.txt Fix typos 2018-07-27 15:00:23 +02:00

README.txt 

Writing a plugin for KDE Connect
=================================

For the desktop client (this project):
--------------------------------------

1. Enter the "plugins" directory.
2. Copy the "ping" under a different name ("findmyphone" in this example).
3. Add "add_subdirectory(findmyphone)" to CMakeLists.txt after the others "add_subdirectory".
1. Enter the new "findmyphone" directory.
5. Edit CMakeLists.txt by replacing "ping" with "findmyphone".
6. Rename other files in this directory by replacing "ping" with "findmyphone"
7. Write a description of your plugin into "README"
8. Edit findmyphoneplugin.cpp and findmyphoneplugin.h.
  A. Change license header.
  B. Replace (case sensitive) "ping" with "findmyphone", "PingPlugin" with "FindMyPhonePlugin" and "PING" with "FINDMYPHONE".
9. Edit kdeconnect_findmyphone.desktop file:
  A. Replace "ping" with "findmyphone".
  B. Change name, description, icon, author, email, version, website, license info.
  C. Remove all the translations
  D. Set X-KDEConnect-SupportedPacketType and X-KDEConnect-OutgoingPacketType to the packet type your plugin will receive
     and send, respectively. In this example this is "kdeconnect.findmyphone". Make sure that this matches what is defined in
     the findmyplugin.h file (in the line "#define PACKET_TYPE_..."), and also in Android.
10. Now you have an empty skeleton to implement your new plugin logic.

For Android (project kdeconnect-android):
-----------------------------------------

1. Change directory to src/org/kde/kdeconnect/Plugins.
2. Copy "PingPlugin" under a different name ("FindMyPhonePlugin" in this example).
1. Enter the new "FindMyPhonePlugin" directory.
4. Rename "PingPlugin.java" to "FindMyPhonePlugin.java"
5. Edit it. Replace (case sensitive) "Ping" with "FindMyPhone", "ping" with "findmyphone", "PING" with "FINDMYPHONE"
   and "plugin_ping" with "plugin_findmyphone".
6. Open res/values/strings.xml. Find and copy the lines "pref_plugin_ping_desc" and "pref_plugin_ping" replacing "ping"
   with "findmyphone" and edit the plugin name and description between <string> </string>).
7. Open src/org/kde/kdeconnect/Plugins/PluginFactory.java.
  A. Copy "import … PingPlugin" line with replacing "PingPlugin" with "FindMyPhonePlugin".
  B. Copy "PluginFactory.registerPlugin(PingPlugin.class);" line with replacing "PingPlugin" with "FindMyPhonePlugin".
8. Open src/org/kde/kdeconnect/NetworkPacket.java. Copy a "public final static String PACKET_TYPE_PING = …" line
   replacing "PING" with the packet type you will be using (should match the desktop client).
9. Now you have an empty skeleton to implement your new plugin logic.