Commit graph

13 commits

Author SHA1 Message Date
Nicolas Fella
d9f427aaeb Move declarativeplugin to top-level dir
Summary: It's not only used by the plasmoid any more but also SFOS and the app use it.

Test Plan: Builds, App runs fine

Reviewers: #kde_connect, piggz, apol

Reviewed By: #kde_connect, piggz, apol

Subscribers: piggz, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14567
2018-08-03 02:24:58 +02:00
Jean Vincent
72535ecf48 Make member variable names, & placement and * placement more coherent
Summary:
Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
Place all references and pointers on the side of the type since it is the majority.

Basically:
 - mFoo -> m_foo
 - foo -> m_foo (if it is a member variable)
 - Type &ref -> Type& ref
 - Type *ptr -> Type* ptr

Reviewers: #kde_connect, nicolasfella, albertvaka

Reviewed By: #kde_connect, nicolasfella, albertvaka

Subscribers: albertvaka, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D7312
2017-09-03 21:45:08 +02:00
Aleix Pol
596e4484f4 Clean up use of virtual and override keywords
Only use virtual when actually virtual, to override just use override.
2016-06-20 19:22:29 +02:00
Aleix Pol
4730022810 Pass arguments as const-reference 2015-09-12 09:45:59 +02:00
Aleix Pol
d58f6314fe run Clang Modernize
Minus the auto change
2015-09-08 10:47:37 +02:00
Boris Egorov
1924173df2 Fix various krazy2 warnings
Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes], [normalize],
[postfixop], [spelling]

See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html
for details.

SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize

REVIEW: 124857
2015-08-21 22:38:54 +06:00
Aleix Pol
a1a560c469 First approach to a KF5 port of KDE Connect
Ported using KDELibs4Support, for a smaller delta, so we can keep
developing on master until we decide not to.

At the moment, it builds and installs but tests don't pass because
of a QCA2 initialization problem I didn't manage to debug yet.

CCMAIL: kdeconnect@kde.org
2014-06-16 20:02:07 +02:00
Samoilenko Yuri
fb8fa53f8d some fixes 2014-02-06 19:25:50 +04:00
Samoilenko Yuri
1ce8750093 simple bugfixes 2014-02-06 19:25:47 +04:00
Samoilenko Yuri
499b8b00b7 some fixes 2014-02-06 00:36:51 +04:00
Samoilenko Yuri
776543409d button works 2014-01-31 14:06:21 +04:00
Samoilenko Yuri
a54dd853ff play continues... 2014-01-30 20:25:22 +04:00
Samoilenko Yuri
42b927bcab hard experiments.. 2014-01-29 02:22:59 +04:00