Nicolas Fella
79164ca8ba
Replace manual include dir handling with interface target
...
We use kdeconnect-version.h in several places and therefore it needs to be in the include path. We currently do this by setting target_include_path in a few places. Replace this with an interface library that we can link against that sets up the correct include path. IMO it is cleaner this way.
2020-07-30 10:53:48 +02:00
Nicolas Fella
e2e303d7cc
[smsapp] Random cmake cleanup
...
Turn smshelper into a static library, which makes sense given it's only used internally at this point. This allows to get rid of some stuff.
Also cleanup other things.
2020-07-30 08:28:15 +00:00
Nicolas Fella
c0b35debe1
Remove dead code
...
We don't use sendreplydialog here any more
2020-07-30 00:43:08 +02:00
Nicolas Fella
9ae3ea631a
Use qdbus_cast
...
Let Qt do the boilerplat for us.
Does virtually the same under the hood (https://code.woboq.org/qt5/qtbase/src/dbus/qdbusargument.h.html#_Z10qdbus_castRK13QDBusArgumentPT_ )
2020-07-29 18:58:36 +02:00
Nicolas Fella
8f41be36dc
Remove unneeded destructor/copy constructor/copy assignment operator
...
We don't have a custom destructor and the copy ctor/assignment operator don't do anything special, so the default one will do the right thing.
This is in accordance with the rule of zero (https://cpppatterns.com/patterns/rule-of-zero.html )
2020-07-29 17:30:29 +02:00
Nicolas Fella
1bd59787e2
[sms] Change address type in DBus API from variant to variantlist
...
While mostly theoretical it makes for a more expressive API since it communicates that it is a list instead of a single value. It also allows to get rid of some conversion code.
This is also preparation work for potentially using the custom type capabilities that QtDBus offers.
2020-07-29 15:18:19 +00:00
Nicolas Fella
e38cdb111b
Add missing references to loop variable
2020-07-29 00:07:40 +02:00
Himanshu Rajput
3ca55ad794
Update plugins/runcommand/runcommand_config.cpp
2020-07-24 11:55:18 +00:00
l10n daemon script
ef73ce6f62
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-22 06:06:44 +02:00
Nicolas Fella
198789e6fc
Fix file dialog usage in app and plasmoid
...
fileDialog.open() does *not* block, so we need to move the sending to onAccepted. Not sure why I thought this ever worked.
BUG: 423975
2020-07-18 21:57:15 +00:00
Nicolas Fella
6cbaaa1a80
[app/mpris] Use property binding
2020-07-17 01:48:20 +02:00
Nicolas Fella
cefe6eec14
Add text to pair confirmation page
2020-07-17 01:31:16 +02:00
Nicolas Fella
a27d684f16
[app] Use subtitle in list item
2020-07-17 01:05:22 +02:00
l10n daemon script
d81a137682
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-15 05:44:49 +02:00
l10n daemon script
1f03064676
GIT_SILENT made messages (after extraction)
2020-07-15 02:15:43 +02:00
l10n daemon script
58d35ec881
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-13 05:32:17 +02:00
Nicolas Fella
3a309cc72f
[app] Port runcommand page to ScrollablePage
2020-07-12 02:25:38 +02:00
Aniket Kumar
af8a5bc49b
Enabled seding of multi-target messages in SMS app.
2020-07-08 14:23:13 +05:30
Aniket Kumar
0cee486a62
Fixed the wrapMode property value of TextArea from non existing TextArea.wrap to TextEdit.Wrap.
2020-07-08 14:15:30 +05:30
l10n daemon script
d2bf605a0c
GIT_SILENT made messages (after extraction)
2020-07-07 02:12:38 +02:00
Nicolas Fella
151f829308
[app] Rework device page
...
To achive the proper scrolling behaviour it needs to be a ScrollablePage. In order to do that correctly the listview needs to be the direct content item of the page. Therefore we need to get rid of the loader and the various placeholder messages are parented to the listview.
2020-07-06 10:50:01 +00:00
l10n daemon script
0c32010a28
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-06 05:30:08 +02:00
l10n daemon script
be3b89aa39
GIT_SILENT made messages (after extraction)
2020-07-06 02:07:08 +02:00
Nicolas Fella
4531cebe18
[app] Add placeholder message around pair button
2020-07-05 20:00:29 +02:00
Nicolas Fella
48688b3ef4
Merge branch 'release/20.04'
2020-07-05 15:52:44 +02:00
Nicolas Fella
bc5863f68f
Add explanatory comment
2020-07-05 15:52:17 +02:00
Nicolas Fella
c8a87db367
Merge branch 'release/20.04'
2020-07-05 15:49:58 +02:00
Fabian Vogt
b699372d38
Prefer qdbus-qt5 if found
...
On some distros, this is how qdbus is called to allow for coinstallability
with Qt 4 and Qt 6+.
2020-07-05 13:45:28 +00:00
Ashvin Nihalani
74c6b71e04
UI Improvements
...
Removed Clutter Single Party Conversation
Added Name ti Multiparty
Changed Default Icon in Conversation List
2020-07-05 12:51:01 +00:00
Nicolas Fella
1315d9b9eb
[smsapp] Switch displayName and shortDescription
...
The former is used as the window title and as title in the about page. I think 'KDE Connect SMS' is more appropriate there.
2020-07-05 12:32:03 +00:00
Simon Redman
b1276795a1
Bump Frameworks version to 5.71 as required for Kirigami.Avatar
2020-07-05 12:31:07 +00:00
Ashvin Nihalani
c333f2af17
[SMS App] Select Message Text
...
Switched from QT Label to Text Edit as QA Label is not allowed to select text
https://stackoverflow.com/questions/49784099/qml-how-to-make-text-or-label-selectable
https://bugreports.qt.io/browse/QTBUG-14077
BUG: 418630 - Cannot select text in messaging app
2020-07-05 00:49:31 +00:00
l10n daemon script
aef817e786
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-02 05:57:52 +02:00
Nicolas Fella
752070add9
Enable highdpi icons
2020-07-01 22:33:08 +02:00
Nicolas Fella
166a88072b
[smsapp] Rework message items
...
The current implementation seems to have an issue with an undetected binding loop that causes lockup. During investigation I figured that the code was way to complex and brittle for what we need.
This is a cleaner reimplementation. It also replaces the custom Avatar component with the one from Kirigami.
The looks are subject to tweaking of course
2020-07-01 19:15:45 +00:00
l10n daemon script
d0443e2e6b
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-01 06:01:31 +02:00
Aniket Kumar
2b8e95caac
[smsapp] Replace custom ListItem with Kirigami's BasicListItem
2020-06-27 18:22:00 +02:00
l10n daemon script
588c01eb0f
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-27 05:41:57 +02:00
Jonah Brüchert
e5c6003399
app: Elide device name in global drawer
2020-06-22 18:58:32 +02:00
l10n daemon script
e44e4a4c19
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-20 05:10:40 +02:00
l10n daemon script
e046b8829b
GIT_SILENT made messages (after extraction)
2020-06-20 02:08:16 +02:00
l10n daemon script
373557cd26
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-18 08:27:38 +02:00
l10n daemon script
dbc476e995
GIT_SILENT made messages (after extraction)
2020-06-18 07:13:50 +02:00
l10n daemon script
653a708727
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-18 05:39:20 +02:00
l10n daemon script
9fc921c557
GIT_SILENT made messages (after extraction)
2020-06-18 02:18:34 +02:00
l10n daemon script
5fe8d7ea90
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-17 16:50:11 +02:00
l10n daemon script
d48849d7cc
GIT_SILENT made messages (after extraction)
2020-06-17 15:34:37 +02:00
l10n daemon script
e873eddcde
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-17 14:06:59 +02:00
l10n daemon script
c850f59910
GIT_SILENT made messages (after extraction)
2020-06-17 11:32:03 +02:00
Nicolas Fella
c4f4f8d408
[app/mousepad] Prevent page change during input
2020-06-16 17:59:36 +02:00