tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3982 commits 81 branches 117 tags 12 MiB
Commit graph

3982 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alexander Lohnau
75a8db1ec5 Use pragma once in plugins 
For non-library code, this is simpler and more concise
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
f1c2202591 Port plasmoid metadata to JSON format 
This is needed for Plasma6 and avoids deprecation warnings/performance penalties in Plasma5
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
b7cf34c11f Simplify slots of some KCMs 
Remove Q_SLOTS where not needed, use lambda if we only connect/call it in one place
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
f483c1449c Use simpler K_PLUGIN_CLASS macro for KCMs 2023-07-22 20:51:19 +00:00
Alexander Lohnau
ede9e37b40 Use KPluginMetaData::pluginId for getting config plugin name 
By removing the postfix we consistently use, we get exactly the same string as before

However, all our pluginId logic is now done as part of the buildsystem.
Before, they were in the JSON metadata, the buildsystem and the string constructor parameter

KPluginFactory has the KPluginMetaData object in any case, do using it
doesn't create any overhead.
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
e894f7c000 PluginModel: Do not call begin/end resetModel in constructor 
This is only needed if we update the data afterward
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
98040c3ffe GIT_SILENT Re-run clang-format 2023-07-22 20:51:19 +00:00
Alexander Lohnau
35a450f366 Port to new PMF connect syntax 
This way we catch missing methods/mismatching arguments at compile and
not at runtime.
This fixes some Qt6 regressions due to the removal of deprecated methods.
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
c61fad5561 Do not make virtual methods of KCModule Q_SLOT 
We do not need those methods to be marked as slots and the KCMUtils
classes like KPluginWidget also don't need it.
Meaning it just results in more moc code being generated.
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
9fdc2901b2 Use target-centric CMake approach rest of logging categories 2023-07-22 20:51:19 +00:00
Alexander Lohnau
41d474b1a5 findthisdeviceplugin_config: Check for URL before trying to play sound 
Having a clear button and then emitting a warning if an enabled button is clicked doesn't really make sense.
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
f740a8bda8 Use target-centric CMake approach for declaring debug category 
This makes it easier to read, because we do not have to handle a list of
files that get added to the targets. In other KDE projects, we also
prefer the target centric approach.

In case one wants to reuse the same category in multiple places, it
would be best to create a small static lib. But for now, this is not
needed.
 2023-07-22 20:51:19 +00:00
Alexander Lohnau
999f8e00de Remove explicit plugin Id 
The one derived from the filename is identical. Deriving it from the filename is the preferred approach.
In KF6, log messages are printed out if the Id is needlessly specified.
A mismatching Id vs basename would print out a warning.
 2023-07-22 20:51:19 +00:00
Albert Vaca Cintora
dd4831f823 Add missing NOTIFY to properties 2023-07-22 20:09:46 +02:00
Albert Astals Cid
4fa2e93246 Improve/change "Pair" i18n messages 2023-07-22 18:05:25 +00:00
Albert Vaca Cintora
46cac0bf61 Fix qml runtime warning when accessing property without NOTIFIY 2023-07-22 19:58:56 +02:00
Alexander Lohnau
23f4b848a2 Remove KRunner plugin leftovers 
I plan to revive it later on, but as a DBus runner
 2023-07-22 19:16:18 +02:00
Alexander Lohnau
7d66b07ef7 Remove unused createId methods 2023-07-22 19:12:33 +02:00
Alexander Lohnau
319696c445 Remove version and website metadata for plugins 
The plugin version doesn't matter, because all plugins are shipped as
part of kdeconnect and not separately.
The website was also set inconsistently, some pointed to a custom blog,
the KDE homepage or a broken link. If we want to make announcements more
visible, we should have a link in a more central place.
 2023-07-22 19:12:33 +02:00
Alexander Lohnau
4ca8f98b7d Remove obsolete ServiceTypes definitions 
Task: https://phabricator.kde.org/T14483
 2023-07-22 19:12:33 +02:00
Alexander Lohnau
f066946a84 Remove unused categories from metadata 2023-07-22 19:12:32 +02:00
Alexander Lohnau
f3998e4b5f Fix windows build issues 
- Add dummy args param to QProcess::startDetached
- Remove logging category from inline snippet. This was removed due to
  being unused in non-windows builds.
 2023-07-22 19:12:28 +02:00
Alexander Lohnau
ac3d439a2a Clean up unneeded version checks 
With the min. version bumped, those can be safely removed
 2023-07-22 16:17:24 +02:00
Alexander Lohnau
1ee75463e0 Get rid of QOverload/static_cast for overloaded signals 
By exclusing deprecated API in the KF5 build, the deprecated signal no
longer cause an ambiguity
 2023-07-22 16:17:24 +02:00
Alexander Lohnau
e97af9dc15 Provide default implementation for KdeConnectPlugin::connected 
In most plugins, we just provided a dummy implementation
 2023-07-22 16:06:21 +02:00
Alexander Lohnau
7b15a5eab7 Fix warnings about old style QML connections 2023-07-22 16:03:24 +02:00
Alexander Lohnau
0b99c3a637 Remove unneeded destructors from plugins 
We already have a destructor from the baseclass and don't need to clean
up any resources in the affected plugins
 2023-07-22 16:01:21 +02:00
Albert Vaca Cintora
32abeb8ed0 Fix typo causing us to intersect with the wrong set 2023-07-22 15:21:26 +02:00
Albert Vaca Cintora
a33eb46d9b Fix crash due to begin and end belonging to different iterators 2023-07-22 15:13:34 +02:00
Alexander Lohnau
d8d9d62ac1 Remove unused, download missing licenses 
`reuse lint` doesn't complain about missing or unused licenses with this change.
 2023-07-22 14:22:59 +02:00
l10n daemon script
b7c84d3398 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-07-22 01:45:05 +00:00
l10n daemon script
0fdc5d4879 GIT_SILENT Sync po/docbooks with svn 2023-07-21 02:03:19 +00:00
l10n daemon script
2b67cefe39 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2023-07-21 01:47:33 +00:00
Albert Vaca Cintora
c3a2665477 Do not call first() on a temporary list 2023-07-20 23:36:05 +02:00
Albert Vaca Cintora
6c1b81a384 Use nullptr instead of 0 2023-07-20 18:26:24 +02:00
Albert Vaca Cintora
382ace9c69 Remove check for Qt > 5.14 when minimum is 5.15 2023-07-20 18:23:45 +02:00
Albert Vaca Cintora
8c97e56f23 Remove duplicated target_link_libraries 2023-07-20 18:23:14 +02:00
Albert Vaca Cintora
0e2d2af402 Bump KDE compiler settings to latest 
This already uses C++17 and C99, so no need to set it manually
 2023-07-20 15:47:27 +00:00
Nicolas Fella
d1d3e47eab Enable PIC for static lib 
Otherwise it doesn't link
 2023-07-20 16:17:56 +02:00
Alexander Lohnau
e9063d168d LanLinkProvider: Restore previous network change behavior 2023-07-20 13:32:17 +03:00
Alexander Lohnau
8ea717b363 Make PulseAudioQt required dependency when WITH_PULSEAUDIO option is set 2023-07-20 13:32:17 +03:00
Alexander Lohnau
b8c6e529ba Port QMultiMedia usage for Qt6 2023-07-20 13:32:17 +03:00
Alexander Lohnau
5456f726af Do not use empty QStringLiteral macro 
QString is recommended instead
 2023-07-20 13:32:16 +03:00
Alexander Lohnau
1dadbd47b2 lanlinkprovider: Load backend explicitly to avoid nullptr warning 
This is needed to make it work properly with Qt6 at runtime
 2023-07-20 13:32:16 +03:00
Alexander Lohnau
f57d59e605 Fix runtime issues with Qt6 
To have the code bits reusable, they are defined as cmake variables.
In order to make the relative paths work and avoid touching every line
from the QRC, the resulting file is put into the source dir.
 2023-07-20 13:32:07 +03:00
Alexander Lohnau
131ed9a079 Port away from deprecated signal param injection 2023-07-20 11:16:04 +03:00
Alexander Lohnau
5b5265f7a8 Port away from deprecated QtNetwork classes 2023-07-20 11:16:04 +03:00
Alexander Lohnau
b3163d8725 dbushelper: Use QRegularExpression instead of QRegExp 
The pattern does not contain any wildcard specific text
 2023-07-20 11:16:04 +03:00
Alexander Lohnau
042adebd0a Port to updeprecated KJob::processedAmountChanged signal 2023-07-20 11:16:04 +03:00
Alexander Lohnau
3effb006f3 interfaces: Build lib in Qt6 STATIC 
Otherwise, the Q_OBJECT stuff is not properly exported and will result in linker errors
 2023-07-20 11:16:04 +03:00