Commit graph

2192 commits

Author SHA1 Message Date
Nicolas Fella
56ebd3f889 Fix with calculation 2018-11-02 15:47:52 +01:00
Nicolas Fella
cefc743307 Only show addCommand button when adding commands is supported 2018-11-02 15:44:14 +01:00
Nicolas Fella
e0766ba532 Align buttons 2018-11-02 15:38:52 +01:00
Nicolas Fella
e66817928f Actually include desktop file 2018-11-02 03:22:05 +01:00
Nicolas Fella
a53d99a8ad Thunar integration
Summary: Add desktop file for integration into Thunar

Test Plan: Run Thunar, Right-click file -> Send to -> Send via KDE Connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16604
2018-11-02 03:21:03 +01:00
Nicolas Fella
9a56d7531b Add contract file
Summary:
This allows sending files from ElementaryOS apps such as their file manager.

Create a data dir for similar files

Test Plan: run contractor; run pantheon-files, right-click file -> Send via KDE Connect

Reviewers: #kde_connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16603
2018-11-02 03:00:39 +01:00
Billy Laws
eaea0ab667 Add support for sharing files from plasmoid
Summary: This allows you to share a local file on your device to a remote device running kde connect.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16552
2018-11-01 18:33:39 +01:00
Simon Redman
787e76ee91 Change SmsPlugin qDebug to qCDebug 2018-11-01 09:36:43 -06:00
l10n daemon script
0faa5c5f18 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-01 05:51:47 +01:00
Billy Laws
5c86da54aa Add QML support for shareplugin
Summary: This will allow it to be used in the plasmoid and QML app via dbus.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16551
2018-10-31 19:40:10 +01:00
Nicolas Fella
bf03990b75 Add editorconfig file
Summary: editorconfig is a cross-editor way of keeping basic coding style standards, e.g. indentation

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: apol, albertvaka, sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16533
2018-10-31 16:51:32 +01:00
Nicolas Fella
1359a9c059 Don't use deprecated ApplicationHeader
Summary:
Use the implicit header

This makes the Add commands action show up in the top bar on desktop

Desktop
{F6375830}

Mobile
{F6375831}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16548
2018-10-31 16:50:52 +01:00
Simon Redman
70926fbeaf [SMS App] Clean up runtime warning about undefined behavior
Summary: Move ColumnLayout containing text elements inside of the graphical bounding rectangle

Test Plan:
Pre patch:
 - Launch messaging app
 - Open conversation
 - Notice huge spew of warnings like: "qrc:/qml/ChatMessage.qml:84:5: QML ColumnLayout: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead."
Post patch:
 - Launch messaging app
 - Open conversation
 - No warnings about undefined behavior

Reviewers: apol

Reviewed By: apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16534
2018-10-31 08:47:19 -06:00
Billy Laws
c546c77040 Add a button to open command setup menu in plasmoid
Summary: This patch adds a button to the plasmoid to allow adding commands by opening the menu on the remote device.

Reviewers: #vdg, nicolasfella, albertvaka

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16535
2018-10-30 23:42:56 +01:00
Bart Ribbers
43e6fed43d Fix build failure on musl based systems
Summary:
Musl lacks backtrace support, so this patch fixes the build by making sure it only gets compiled when using a glibc system.

Bug: 395161

Reviewers: #kde_connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13446
2018-10-30 22:04:14 +01:00
Simon Redman
e6d84ece34 Replaces tabs with spaces (properly) 2018-10-30 14:03:16 -06:00
Simon Redman
e9d5c9e27e Revert "Replace tabs with spaces in messaging app"
This reverts commit 6657dff8cf.
2018-10-30 14:01:13 -06:00
Simon Redman
6657dff8cf Replace tabs with spaces in messaging app 2018-10-30 13:58:50 -06:00
Jun Bo Bi
467ac64be7 [remoteinput] Added keyboard support for windows
Summary:
Added keyboard input support for Windows
Completes T6269

Test Plan:
  - Open Remote input
  - Type something in

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect, #kde_connect

Tags: #kde_connect, #windows

Differential Revision: https://phabricator.kde.org/D16501
2018-10-30 11:31:58 +01:00
Simon Redman
0f5c9cd96c Make NetworkPacket Metatype-capable
Summary: I am open to discussion for whether this is desireable. The use-case is for moving NetworkPacket receive handling to a thread other than the one handling the rest of the device. In order to do this, we need to use a QtConnectionType::QueuedConnection. In order for that to work (with NetworkPackets), NetworkPacket has to be registered in the Metatype system.

Test Plan: Nothing should be functionally different from before

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, apol, nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16469
2018-10-29 10:42:12 -06:00
Simon Redman
08b31ce258 Properly Assign LanLinkProvider as the Parent of its child objects
Summary: This is not a hugely important change. I noticed it while I was working on something else, and it seems like it ought to be this way

Test Plan: Nothing should be noticeably different

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16468
2018-10-29 09:48:09 -06:00
l10n daemon script
19bea39619 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-28 04:53:25 +01:00
Alex Kovrigin
4daf129cf3 Improve "No devices" warning
Summary:
Move the "No devices available" text in smsapp from combobox to the ConversationList.

P.S.
It's a GCI task.

Test Plan:
* Build and run smsapp
* Try pairing and unpairing the device
* See the difference

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16467
2018-10-27 14:49:39 -06:00
Simon Redman
b01652f54d Fix include guards
Summary:
Some plugins were copy/pasted from a template and forgot to change their include guards. Since plugin header files are never cross-referenced, this was not a serious issue, but it looks nicer to be correct

NotificationListener.h did not have an include guard. As before, this is not a problem currently, but it's best to have it fixed

Test Plan: Project should build, compile, and run as normal

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16437
2018-10-26 15:29:39 -06:00
l10n daemon script
6879cf14cd SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-24 05:55:51 +02:00
Adam Pigg
ee52c8cd03 use libkeepalive to wakeup daemon
Summary:
Main change is to use libkeepalive to wake up the system to ensure connections stay alive

Other minor changes are:
-Log daemon messages for debugging purposes
-Add way to forece refresh of device list
-Minor spec improvements

The keepalive changes certainly seem to help, not sure if it completely solves the problems
The logging changes are temporary, and I could use them locally, but they only affect sailfish users
Im not sure if the refresh method is correct, but seems to force the daemon to check for devices

Reviewers: #kde_connect, nicolasfella, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15414
2018-10-23 08:30:48 +01:00
l10n daemon script
a98533b8f4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-23 06:01:17 +02:00
Albert Vaca
1e9a1f93ed Fix license header for smsapp 2018-10-11 22:52:42 +02:00
Nicolas Fella
7307cd2709 [App] Always show drawer on Desktop
Summary: A drawer is not good UX on the desktop. Only collapse it when on mobile or window is very narrow

Test Plan:
{F6319485}
{F6319492}

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16122
2018-10-11 16:30:02 +02:00
l10n daemon script
283211b4eb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-10 06:19:16 +02:00
l10n daemon script
164a9af9ad GIT_SILENT made messages (after extraction) 2018-10-10 03:54:37 +02:00
Nicolas Fella
8bfe093939 Don't show phonenumber if name is available
Summary:
Showing the number next to the name is neither pretty nor necessary IMHO.

My Android SMS app displays the number more subtle in an extra line below in gray. I could get behind something similar, but until this is implemented just don't show it

Depends on D16015

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16017
2018-10-08 20:37:49 +02:00
Nicolas Fella
45e966c290 Fix person name displaying in ConversationDisplay
Summary: Don't ask my why this works this way

Test Plan: I see Name: phonenumber for contacts and just phonenumber for non-contacts now

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16015
2018-10-08 20:36:35 +02:00
Aleix Pol
3a57d45f2b Define KPeopleVCard as a runtime dependency of smsapp 2018-10-08 16:55:56 +02:00
Simon Redman
a7db3ab5e1 [Desktop] Update conversation list when a new message arrives
Summary:
When a new message is delivered, the conversation list should update by changing the preview text and re-sorting the conversations

Bonus bug discovered and fixed:  previously, when the conversations list was being populated, it made a request for the first message in every conversation. This would be fine if the conversationdbusinterface pulled from local cache. However, this actually triggers a request to the phone for *every* conversation.

This should be handled differently in conversationdbusinterface's requestConversation as well, but that's a project for a later day (TODO comments added)

Test Plan:
 - Launch SMS app
 - Verify conversations list appears
 - Verify lack of massive stream of debug output indicating lots of messages for the wrong conversation are being received
 - Verify that opening a particular conversation shows the messages after a short delay while the backend fetches the content from the phone
 - Verify that receiving a new message into an existing conversation updates the conversation list

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15608
2018-10-07 21:46:39 -06:00
Simon Redman
ab33cce5a5 [SMS App] Improve contact matching
Summary: Improve contact matching by checking if the requested address ends with a candidate phone number, or vice-versa

Test Plan:
Check that *all* conversations which correspond to a contact are matched
 - All of mine match. If someone finds one which doesn't, I will need the particulars...

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15992
2018-10-07 21:34:07 -06:00
Yuri Chornoivan
5fe74ce041 Fix minor EBN issues and typos 2018-10-07 21:23:20 +03:00
Simon Redman
563dde9891 Correct braces and add contributors
Summary: Braces to start a method are on a newline, braces to begin an in-method block are on the same line

Test Plan: Pure source code cosmetic changes. Hopefully no functionality has changed!

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: apol, nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15978
2018-10-06 21:59:15 -06:00
l10n daemon script
d314758670 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-05 05:52:20 +02:00
Nicolas Fella
d7d2917e00 Use new icon for clearing notifications
Summary: {F6303876}

Reviewers: #kde_connect, ngraham, thsurrel

Reviewed By: ngraham

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15948
2018-10-04 19:25:53 +02:00
Matthijs Tijink
7cab490cc5 Fix receiving payloads using a bluetooth connection
Summary:
This fixes receiving payloads using the bluetooth backend.

This looks like some bug in Qt, but I couldn't figure out what happens exactly (will report a bug though).

Test Plan: Receiving files now works!

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect, nicolasfella, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12153
2018-10-04 19:05:34 +02:00
l10n daemon script
f145ef8833 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-30 05:50:17 +02:00
l10n daemon script
c1c206ebf5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-29 05:58:22 +02:00
Nicolas Fella
7a4bdcc62d [cli] Allow sharing files and URLs together
Summary:
Depends on D15787

Restricting sharing multiple urls to files seems unnecessary to me.

Test Plan: kdeconnect-cli --share foo.txt google.com

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15788
2018-09-28 15:13:05 +02:00
Nicolas Fella
518251342c [cli] Always take working dir into account when parsing url
Summary:
Bug: 399115

When using kdeconnect-cli --share the first argument was not recognised as a file when a relative path was specified.

Test Plan:
kdeconnect-cli --share File1.txt File2.txt : Check that both files are sent
kdeconnect-cli --sahre phabricator.kde.org : Check that web page is opend

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15787
2018-09-28 15:12:29 +02:00
Nicolas Fella
e9323452ca Merge icon CMake macros
Summary: If there was any reason to have it split please enlighten me

Test Plan: Remove icons from hicolor folder. sudo make install. Check for installed icons

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15765
2018-09-27 18:18:30 +02:00
Nicolas Fella
f82df1c461 [smsapp] Use ApplicationHeader instead of ToolbarApplicationHeader
Summary:
ToolbarApplicationHeader seems deprecated and is broken on Plasma Mobile

Before:
{F6286925}

After:
{F6286924}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15781
2018-09-27 18:17:51 +02:00
Nicolas Fella
bd5c3ca460 [App] Show message when no device is found
Summary: {F6286990}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15784
2018-09-27 18:16:39 +02:00
Nicolas Fella
5cc205b5de [App] Show text if no commands are defined 2018-09-24 21:49:18 +02:00
Thomas Surrel
5ae67e0feb [CLI] Unpair unreachable devices
Summary: You should be ableto unpair unreachable devices with the CLI

Reviewers: kdeconnect, albertvaka

Reviewed By: albertvaka

Subscribers: albertvaka

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15677
2018-09-24 15:59:08 +02:00