Commit graph

2843 commits

Author SHA1 Message Date
Simon Redman
3055f8367c Add localization contribution information to the desktop repository's readme
Closes #237
2020-04-14 20:34:05 -07:00
Philip Cohn-Cort
c315170be5 Finally, we have support for sending out Battery information.
## Summary

The core idea is as follows:

1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
    1. If the list is empty, we print a warning message and return quickly
    2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket

### Multi-battery Support

BUG: 357193

To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.

This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)

### Concerns

Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.

Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?

## Test Plan

We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 05:54:11 +00:00
Nicolas Fella
b3d78d6d07 [notifications] Drop no icon hack 2020-04-12 23:07:51 +00:00
Nicolas Fella
1a9c2dbc4c Fix coding style 2020-04-10 23:43:06 +02:00
Piyush Aggarwal
5000ae2cf6 update icon address for windowIcon 2020-04-10 22:42:04 +05:30
l10n daemon script
5ef95c7c25 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-09 06:26:57 +02:00
l10n daemon script
ab511646c8 GIT_SILENT made messages (after extraction) 2020-04-09 03:20:44 +02:00
Nicolas Fella
1013f23e1b Fix trailing whitespace 2020-04-08 10:48:12 +02:00
Nicolas Fella
570b8776c6 Use QString::isEmpty 2020-04-08 10:47:47 +02:00
Nicolas Fella
b35d96b471 Add some const 2020-04-08 10:46:35 +02:00
Nicolas Fella
f8674db931 Don't recreate QRegularExpression for leading zeroes each time
Creating a QRegularExpression is quite expensive and we use the same expression for each run. Sharing it between the runs leads to a significant performance improvement.
2020-04-08 10:25:34 +02:00
l10n daemon script
43ea8052fe SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-08 06:32:15 +02:00
l10n daemon script
6a67865618 GIT_SILENT made messages (after extraction) 2020-04-08 03:24:26 +02:00
Abdel-Rahman Abdel-Rahman
d3062cafd4 Receive SMS subscription ID and reply using it
This interprets the "sub_id" field to use it later for replying in
order to reply to SMS messages from the same SIM.
2020-04-07 20:01:18 +00:00
l10n daemon script
0e04769a43 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-07 06:11:40 +02:00
l10n daemon script
62a00df7ba GIT_SILENT made messages (after extraction) 2020-04-07 03:31:53 +02:00
l10n daemon script
b83a028435 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-06 06:09:41 +02:00
Noah Davis
ba76d449f9 Undo changes to sc-apps-kdeconnectindicator* icons 2020-04-03 17:57:56 -04:00
Noah Davis
e34988b051 Add 32px connected/disconnected/trusted icons for Bigscreen 2020-04-02 22:16:11 -04:00
Noah Davis
9ccef9f9b3 Update CMakeLists.txt with new file names 2020-04-02 20:39:56 -04:00
Noah Davis
da5c52a47a Replace 32px status icons with 16 and 22px icons 2020-04-02 20:39:30 -04:00
Noah Davis
beb293d8c2 Optimize SVGs 2020-04-02 20:36:59 -04:00
Noah Davis
404a2a3e1d Rename 22px kdeconnectindicator icons 2020-04-02 20:36:08 -04:00
Noah Davis
5ac1ac9abc Convert sc-apps-kdeconnect.svgz to svg 2020-04-02 19:47:19 -04:00
Noah Davis
c974877e0e Optimize SVGs 2020-04-02 19:47:19 -04:00
Noah Davis
5210d1aec3 Remove PNG icons 2020-04-02 19:47:19 -04:00
Albert Vaca Cintora
14cdd8e2b5 Exception doesn't have strerr
Fix crash when crashing when translation not found
2020-04-02 12:38:09 +02:00
l10n daemon script
e2d175f2a0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-01 06:36:16 +02:00
Kai Uwe Broulik
e48e34d776 Merge branch 'release/20.04' 2020-03-31 15:19:26 +02:00
Kai Uwe Broulik
310b0517ed Check for null notification
When starting a phone call on the phone, we enter "talking" state without having created a notification first leading to a crash.
2020-03-31 15:18:29 +02:00
l10n daemon script
d8029897d5 GIT_SILENT made messages (after extraction) 2020-03-31 03:24:43 +02:00
Aniket Kumar
520d2a5695 Move ConversationsSortFilterProxyModel class from conversationlistmodel files to its own files
## Summary

Currently `OurSortFilterProxyModel` class is implemented in the same file with `ConversationListModel` class, which would likely grow in the future.

This MR separates `OurSortFilterProxyModel` class into its own separate file renaming it to `ConversationsSortFilterProxyModel`

https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/229
2020-03-29 18:25:07 +00:00
Arjun Thekoot Harisankar
77e08ec70a Update README.txt in Plugins to include the current method to build a skeleton for a Plugin 2020-03-27 21:02:16 +05:30
Nicolas Fella
468bc4151d Merge branch 'release/20.04' 2020-03-23 17:23:57 +01:00
Nicolas Fella
cae69fe10e [fileitemactionplugin] Use async DBus call
Otherwise the call will block and freeze the calling process, e.g. dolphin or plasmashell

BUG: 419133
2020-03-23 17:22:47 +01:00
Jiří Wolker
365791dc59 Show remaining character count in SMS app
## Summary

This adds character counter below the “Send” button in SMS conversation. It
uses format XXX/Y where XXX is number of characters that can be added
without splitting the SMS into multiple messages (see article
Concatenated SMS on Wikipedia). Y is number of messages in in current
concatenated SMS. The counter is not visible when insertion of 10 7-bit
or 16-bit (depends on SMS encoding) does not create concatenated SMS.

SMS encoding is automatically guessed. 8-bit encodings are not
supported. If the message contains characters that are not supported by GSM 7-bit
encoding, counter automatically switches to UCS-2.

## Test Plan

Try entering some text that is longer than 150 characters in [GSM 03.38 encoding][1] or 60 characters in UCS-2. Number of remaining characters should be visible below the “Send” button. The character counter should show `0` at exactly 160 or 70 characters. Inserting one character should switch the counter to [Concatenated SMS][2] mode when number of messages is shown.

It should show exactly same number as SMS app in Android.

## Screenshots

These images are in APNG.

![grab.apng](/uploads/21ae23f2fa75c7aca487e61ddce94644/grab.apng)
![grab-cz.apng](/uploads/785e670a8598c5a65a4209f17e75f578/grab-cz.apng)

[1]: https://en.wikipedia.org/w/index.php?oldid=932080074#GSM_7-bit_default_alphabet_and_extension_table_of_3GPP_TS_23.038_/_GSM_03.38
[2]: https://en.wikipedia.org/w/index.php?oldid=943185255#Message_size
2020-03-22 18:47:12 +00:00
Aniket Kumar
f211d7e401 Add feature to start new conversation with existing contacts
## Summary

Start a conversation with contacts having no previous conversation with.

It is currently only possible to use the messaging app to send a message to a conversation which already exists.

This patch implements this feature by integrating all contacts having no prior conversation with the recent conversations in the recent conversation list and at the bottom in a sorted manner, something like this,

The contacts are stored in the recent conversation list model as a conversation but with INVALID conversation ID and INVALID conversation DATE.

## Testing

Testing just needs kdeconnect daemon to be recompiled and executed.
2020-03-21 22:57:28 +00:00
Simon Redman
2a2481fb6a Fix build 2020-03-21 15:44:13 -07:00
Simon Redman
b7643ecbad Delete flakey tests 2020-03-21 22:25:01 +00:00
Nicolas Fella
2725de9170 Improve call notification handling
Simplify the code, close the notification when talking.
2020-03-21 22:18:34 +01:00
Nicolas Fella
c807d84a44 Read payload size as qint64 2020-03-21 21:49:11 +01:00
Nicolas Fella
2e15294caf Merge branch 'release/20.04' 2020-03-21 21:27:28 +01:00
Nicolas Fella
9f1101c9c1 Use kdeconnect-settings for command configuration
Instead of relying on kde-cli-tools being installed.
2020-03-21 21:26:51 +01:00
Nicolas Fella
28e7e99100 Merge branch 'release/20.04' 2020-03-21 21:21:02 +01:00
Nicolas Fella
eac1e07e29 Revert "Make default name and device type customizable"
This causes a crash described in https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/206#note_37534

This reverts commit a39a2d562d.
2020-03-21 21:13:41 +01:00
l10n daemon script
08df418cc9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-03-21 09:48:57 +01:00
l10n daemon script
9673dbe6a5 GIT_SILENT made messages (after extraction) 2020-03-21 08:36:30 +01:00
l10n daemon script
782f2ffe72 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-03-21 05:50:32 +01:00
Albert Vaca Cintora
9feb4e5510 Merge branch 'strace/kdeconnect-kde-seamless_playback' 2020-03-21 00:24:49 +01:00
Nicolas Fella
2c8cf96a6c Read payload size as qint64 2020-03-20 19:54:47 +00:00