tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[clazy] Properly emit signals

Browse source 
Test Plan: Receive a file

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17166
This commit is contained in:
Nicolas Fella 2018-11-26 01:53:55 +01:00
parent d74edc33b9
commit ded463eb49
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/filetransferjob.cpp
View file

@ -59,7 +59,7 @@ void FileTransferJob::start()
void FileTransferJob::doStart() void FileTransferJob::doStart()
{ {
description(this, i18n("Receiving file over KDE Connect"), Q_EMIT description(this, i18n("Receiving file over KDE Connect"),
{ i18nc("File transfer origin", "From"), m_from } { i18nc("File transfer origin", "From"), m_from }
); );
@ -82,7 +82,7 @@ void FileTransferJob::startTransfer()
return; return;
setProcessedAmount(Bytes, 0); setProcessedAmount(Bytes, 0);
description(this, i18n("Receiving file over KDE Connect"), Q_EMIT description(this, i18n("Receiving file over KDE Connect"),
{ i18nc("File transfer origin", "From"), m_from }, { i18nc("File transfer origin", "From"), m_from },
{ i18nc("File transfer destination", "To"), m_destination.toLocalFile() }); { i18nc("File transfer destination", "To"), m_destination.toLocalFile() });

2
plugins/runcommand/runcommand_config.cpp
View file

@ -165,7 +165,7 @@ void RunCommandConfig::insertRow(int i, const QString& name, const QString& comm
void RunCommandConfig::onDataChanged(const QModelIndex& topLeft, const QModelIndex& bottomRight) void RunCommandConfig::onDataChanged(const QModelIndex& topLeft, const QModelIndex& bottomRight)
{ {
changed(true); Q_EMIT changed(true);
Q_UNUSED(topLeft); Q_UNUSED(topLeft);
if (bottomRight.row() == m_entriesModel->rowCount() - 1) { if (bottomRight.row() == m_entriesModel->rowCount() - 1) {
//TODO check both entries are still empty //TODO check both entries are still empty