From ded463eb49eaf7ff221f6d90f32fb1dab2164040 Mon Sep 17 00:00:00 2001 From: Nicolas Fella Date: Mon, 26 Nov 2018 01:53:55 +0100 Subject: [PATCH] [clazy] Properly emit signals Test Plan: Receive a file Reviewers: #kde_connect, albertvaka Reviewed By: #kde_connect, albertvaka Subscribers: kdeconnect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D17166 --- core/filetransferjob.cpp | 4 ++-- plugins/runcommand/runcommand_config.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/filetransferjob.cpp b/core/filetransferjob.cpp index 7fc5cbebc..ecf1495c6 100644 --- a/core/filetransferjob.cpp +++ b/core/filetransferjob.cpp @@ -59,7 +59,7 @@ void FileTransferJob::start() void FileTransferJob::doStart() { - description(this, i18n("Receiving file over KDE Connect"), + Q_EMIT description(this, i18n("Receiving file over KDE Connect"), { i18nc("File transfer origin", "From"), m_from } ); @@ -82,7 +82,7 @@ void FileTransferJob::startTransfer() return; setProcessedAmount(Bytes, 0); - description(this, i18n("Receiving file over KDE Connect"), + Q_EMIT description(this, i18n("Receiving file over KDE Connect"), { i18nc("File transfer origin", "From"), m_from }, { i18nc("File transfer destination", "To"), m_destination.toLocalFile() }); diff --git a/plugins/runcommand/runcommand_config.cpp b/plugins/runcommand/runcommand_config.cpp index 64cc46269..b8f904f70 100644 --- a/plugins/runcommand/runcommand_config.cpp +++ b/plugins/runcommand/runcommand_config.cpp @@ -165,7 +165,7 @@ void RunCommandConfig::insertRow(int i, const QString& name, const QString& comm void RunCommandConfig::onDataChanged(const QModelIndex& topLeft, const QModelIndex& bottomRight) { - changed(true); + Q_EMIT changed(true); Q_UNUSED(topLeft); if (bottomRight.row() == m_entriesModel->rowCount() - 1) { //TODO check both entries are still empty