Remove unneeded destructors from plugins

We already have a destructor from the baseclass and don't need to clean
up any resources in the affected plugins

plugins/bigscreen/bigscreenplugin.cpp

@@ -25,8 +25,6 @@ BigscreenPlugin::BigscreenPlugin(QObject *parent, const QVariantList &args)
 {
 }
 
-BigscreenPlugin::~BigscreenPlugin() = default;
-
 bool BigscreenPlugin::receivePacket(const NetworkPacket &np)
 {
     QString message = np.get<QString>(QStringLiteral("content"));

plugins/bigscreen/bigscreenplugin.h

@@ -19,7 +19,6 @@ class Q_DECL_EXPORT BigscreenPlugin : public KdeConnectPlugin
 
 public:
     explicit BigscreenPlugin(QObject *parent, const QVariantList &args);
-    ~BigscreenPlugin() override;
 
     bool receivePacket(const NetworkPacket &np) override;
     void connected() override{};

plugins/findmyphone/findmyphoneplugin.cpp

@@ -19,10 +19,6 @@ FindMyPhonePlugin::FindMyPhonePlugin(QObject *parent, const QVariantList &args)
 {
 }
 
-FindMyPhonePlugin::~FindMyPhonePlugin()
-{
-}
-
 bool FindMyPhonePlugin::receivePacket(const NetworkPacket &np)
 {
     Q_UNUSED(np);

plugins/findmyphone/findmyphoneplugin.h

@@ -20,7 +20,6 @@ class FindMyPhonePlugin : public KdeConnectPlugin
 
 public:
     explicit FindMyPhonePlugin(QObject *parent, const QVariantList &args);
-    ~FindMyPhonePlugin() override;
 
     Q_SCRIPTABLE void ring();
 

plugins/findthisdevice/findthisdeviceplugin.cpp

@@ -31,8 +31,6 @@ FindThisDevicePlugin::FindThisDevicePlugin(QObject *parent, const QVariantList &
 {
 }
 
-FindThisDevicePlugin::~FindThisDevicePlugin() = default;
-
 bool FindThisDevicePlugin::receivePacket(const NetworkPacket &np)
 {
     Q_UNUSED(np);

plugins/findthisdevice/findthisdeviceplugin.h

@@ -30,7 +30,6 @@ class FindThisDevicePlugin : public KdeConnectPlugin
 
 public:
     explicit FindThisDevicePlugin(QObject *parent, const QVariantList &args);
-    ~FindThisDevicePlugin() override;
 
     void connected() override{};
     QString dbusPath() const override;

plugins/lockdevice/lockdeviceplugin-win.cpp

@@ -27,10 +27,6 @@ LockDevicePlugin::LockDevicePlugin(QObject *parent, const QVariantList &args)
 {
 }
 
-LockDevicePlugin::~LockDevicePlugin()
-{
-}
-
 bool LockDevicePlugin::isLocked() const
 {
     return m_remoteLocked; // Windows doesn't support monitoring lock status, m_remoteLocked is never updated

plugins/lockdevice/lockdeviceplugin-win.h

@@ -22,7 +22,6 @@ class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin
 
 public:
     explicit LockDevicePlugin(QObject *parent, const QVariantList &args);
-    ~LockDevicePlugin() override;
 
     bool isLocked() const;
     Q_SCRIPTABLE void setLocked(bool);

plugins/lockdevice/lockdeviceplugin.cpp

@@ -55,10 +55,6 @@ LockDevicePlugin::LockDevicePlugin(QObject *parent, const QVariantList &args)
     m_localLocked = m_login1Interface.lockedHint();
 }
 
-LockDevicePlugin::~LockDevicePlugin()
-{
-}
-
 bool LockDevicePlugin::isLocked() const
 {
     return m_remoteLocked;

plugins/lockdevice/lockdeviceplugin.h

@@ -25,7 +25,6 @@ class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin
 
 public:
     explicit LockDevicePlugin(QObject *parent, const QVariantList &args);
-    ~LockDevicePlugin() override;
 
     bool isLocked() const;
     Q_SCRIPTABLE void setLocked(bool);

plugins/mousepad/waylandremoteinput.cpp

@@ -172,10 +172,6 @@ WaylandRemoteInput::WaylandRemoteInput(QObject *parent)
 {
 }
 
-WaylandRemoteInput::~WaylandRemoteInput()
-{
-}
-
 bool WaylandRemoteInput::handlePacket(const NetworkPacket &np)
 {
     if (!s_session->isValid()) {

plugins/mousepad/waylandremoteinput.h

@@ -42,7 +42,6 @@ class WaylandRemoteInput : public AbstractRemoteInput
 
 public:
     explicit WaylandRemoteInput(QObject *parent);
-    ~WaylandRemoteInput();
 
     bool handlePacket(const NetworkPacket &np) override;
     bool hasKeyboardSupport() override

plugins/mprisremote/mprisremoteplayermediaplayer2.cpp

@@ -15,8 +15,6 @@ MprisRemotePlayerMediaPlayer2::MprisRemotePlayerMediaPlayer2(MprisRemotePlayer *
 {
 }
 
-MprisRemotePlayerMediaPlayer2::~MprisRemotePlayerMediaPlayer2() = default;
-
 bool MprisRemotePlayerMediaPlayer2::CanQuit() const
 {
     return false;

plugins/mprisremote/mprisremoteplayermediaplayer2.h

@@ -25,7 +25,6 @@ class MprisRemotePlayerMediaPlayer2 : public QDBusAbstractAdaptor
 
 public:
     explicit MprisRemotePlayerMediaPlayer2(MprisRemotePlayer *parent, const MprisRemotePlugin *plugin);
-    ~MprisRemotePlayerMediaPlayer2() override;
 
 public Q_SLOTS:
     void Raise();

plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp

@@ -27,8 +27,6 @@ MprisRemotePlayerMediaPlayer2Player::MprisRemotePlayerMediaPlayer2Player(MprisRe
     connect(m_parent, &MprisRemotePlayer::playingChanged, this, &MprisRemotePlayerMediaPlayer2Player::playingChanged);
 }
 
-MprisRemotePlayerMediaPlayer2Player::~MprisRemotePlayerMediaPlayer2Player() = default;
-
 QString MprisRemotePlayerMediaPlayer2Player::PlaybackStatus() const
 {
     if (m_parent->playing()) {

plugins/mprisremote/mprisremoteplayermediaplayer2player.h

@@ -33,7 +33,6 @@ class MprisRemotePlayerMediaPlayer2Player : public QDBusAbstractAdaptor
 
 public:
     explicit MprisRemotePlayerMediaPlayer2Player(MprisRemotePlayer *parent, MprisRemotePlugin *plugin);
-    ~MprisRemotePlayerMediaPlayer2Player() override;
 
 public Q_SLOTS:
     void Next();

plugins/mprisremote/mprisremoteplugin.cpp

@@ -18,12 +18,6 @@ K_PLUGIN_CLASS_WITH_JSON(MprisRemotePlugin, "kdeconnect_mprisremote.json")
 
 MprisRemotePlugin::MprisRemotePlugin(QObject *parent, const QVariantList &args)
     : KdeConnectPlugin(parent, args)
-    , m_currentPlayer()
-    , m_players()
-{
-}
-
-MprisRemotePlugin::~MprisRemotePlugin()
 {
 }
 

plugins/mprisremote/mprisremoteplugin.h

@@ -33,7 +33,6 @@ class Q_DECL_EXPORT MprisRemotePlugin : public KdeConnectPlugin
 
 public:
     explicit MprisRemotePlugin(QObject *parent, const QVariantList &args);
-    ~MprisRemotePlugin() override;
 
     long position() const;
     int volume() const;

plugins/notifications/notification.cpp

@@ -61,10 +61,6 @@ Notification::Notification(const NetworkPacket &np, const Device *device, QObjec
     });
 }
 
-Notification::~Notification()
-{
-}
-
 void Notification::dismiss()
 {
     if (m_dismissable) {

plugins/notifications/notification.h

@@ -33,7 +33,6 @@ class Notification : public QObject
 
 public:
     Notification(const NetworkPacket &np, const Device *device, QObject *parent);
-    ~Notification() override;
 
     QString internalId() const
     {

plugins/photo/photoplugin.cpp

@@ -20,10 +20,6 @@ PhotoPlugin::PhotoPlugin(QObject *parent, const QVariantList &args)
 {
 }
 
-PhotoPlugin::~PhotoPlugin()
-{
-}
-
 bool PhotoPlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.get<bool>(QStringLiteral("cancel"))) {

plugins/photo/photoplugin.h

@@ -21,7 +21,6 @@ class Q_DECL_EXPORT PhotoPlugin : public KdeConnectPlugin
 
 public:
     explicit PhotoPlugin(QObject *parent, const QVariantList &args);
-    ~PhotoPlugin() override;
 
     Q_SCRIPTABLE void requestPhoto(const QString &url);
 

plugins/presenter/presenterplugin.cpp

@@ -58,10 +58,6 @@ PresenterPlugin::PresenterPlugin(QObject *parent, const QVariantList &args)
     m_timer->setSingleShot(true);
 }
 
-PresenterPlugin::~PresenterPlugin()
-{
-}
-
 bool PresenterPlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.get<bool>(QStringLiteral("stop"), false)) {

plugins/presenter/presenterplugin.h

@@ -24,8 +24,6 @@ class Q_DECL_EXPORT PresenterPlugin : public KdeConnectPlugin
 
 public:
     explicit PresenterPlugin(QObject *parent, const QVariantList &args);
-    ~PresenterPlugin() override;
-
     bool receivePacket(const NetworkPacket &np) override;
     void connected() override
     {

plugins/remotecommands/remotecommandsplugin.cpp

@@ -24,8 +24,6 @@ RemoteCommandsPlugin::RemoteCommandsPlugin(QObject *parent, const QVariantList &
 {
 }
 
-RemoteCommandsPlugin::~RemoteCommandsPlugin() = default;
-
 bool RemoteCommandsPlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.has(QStringLiteral("commandList"))) {

plugins/remotecommands/remotecommandsplugin.h

@@ -22,7 +22,6 @@ class Q_DECL_EXPORT RemoteCommandsPlugin : public KdeConnectPlugin
 
 public:
     explicit RemoteCommandsPlugin(QObject *parent, const QVariantList &args);
-    ~RemoteCommandsPlugin() override;
 
     Q_SCRIPTABLE void triggerCommand(const QString &key);
     Q_SCRIPTABLE void editCommands();

plugins/remotecontrol/remotecontrolplugin.cpp

@@ -23,10 +23,6 @@ RemoteControlPlugin::RemoteControlPlugin(QObject *parent, const QVariantList &ar
 {
 }
 
-RemoteControlPlugin::~RemoteControlPlugin()
-{
-}
-
 void RemoteControlPlugin::moveCursor(const QPoint &p)
 {
     NetworkPacket np(PACKET_TYPE_MOUSEPAD_REQUEST, {{QStringLiteral("dx"), p.x()}, {QStringLiteral("dy"), p.y()}});

plugins/remotecontrol/remotecontrolplugin.h

@@ -20,7 +20,6 @@ class Q_DECL_EXPORT RemoteControlPlugin : public KdeConnectPlugin
 
 public:
     explicit RemoteControlPlugin(QObject *parent, const QVariantList &args);
-    ~RemoteControlPlugin() override;
 
     bool receivePacket(const NetworkPacket & /*np*/) override
     {

plugins/remotekeyboard/remotekeyboardplugin.cpp

@@ -58,10 +58,6 @@ RemoteKeyboardPlugin::RemoteKeyboardPlugin(QObject *parent, const QVariantList &
 {
 }
 
-RemoteKeyboardPlugin::~RemoteKeyboardPlugin()
-{
-}
-
 bool RemoteKeyboardPlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.type() == PACKET_TYPE_MOUSEPAD_ECHO) {

plugins/remotekeyboard/remotekeyboardplugin.h

@@ -28,7 +28,6 @@ private:
 
 public:
     explicit RemoteKeyboardPlugin(QObject *parent, const QVariantList &args);
-    ~RemoteKeyboardPlugin() override;
 
     bool receivePacket(const NetworkPacket &np) override;
     QString dbusPath() const override;

plugins/remotesystemvolume/remotesystemvolumeplugin.cpp

@@ -26,10 +26,6 @@ RemoteSystemVolumePlugin::RemoteSystemVolumePlugin(QObject *parent, const QVaria
 {
 }
 
-RemoteSystemVolumePlugin::~RemoteSystemVolumePlugin()
-{
-}
-
 bool RemoteSystemVolumePlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.has(QStringLiteral("sinkList"))) {

plugins/remotesystemvolume/remotesystemvolumeplugin.h

@@ -23,7 +23,6 @@ class Q_DECL_EXPORT RemoteSystemVolumePlugin : public KdeConnectPlugin
 
 public:
     explicit RemoteSystemVolumePlugin(QObject *parent, const QVariantList &args);
-    ~RemoteSystemVolumePlugin() override;
 
     bool receivePacket(const NetworkPacket &np) override;
     void connected() override;

plugins/runcommand/runcommand_config.cpp

@@ -93,10 +93,6 @@ RunCommandConfig::RunCommandConfig(QObject *parent, const QVariantList &args)
     m_entriesModel->setHorizontalHeaderLabels(QStringList() << i18n("Name") << i18n("Command"));
 }
 
-RunCommandConfig::~RunCommandConfig()
-{
-}
-
 void RunCommandConfig::exportCommands()
 {
     QString filePath = QFileDialog::getSaveFileName(widget(), i18n("Export Commands"), QDir::homePath(), QStringLiteral("JSON (*.json)"));

plugins/runcommand/runcommand_config.h

@@ -17,7 +17,6 @@ class RunCommandConfig : public KdeConnectPluginKcm
     Q_OBJECT
 public:
     RunCommandConfig(QObject *parent, const QVariantList &);
-    ~RunCommandConfig() override;
 
 public Q_SLOTS:
     void save() override;

plugins/runcommand/runcommandplugin.cpp

@@ -37,10 +37,6 @@ RunCommandPlugin::RunCommandPlugin(QObject *parent, const QVariantList &args)
     connect(config(), &KdeConnectPluginConfig::configChanged, this, &RunCommandPlugin::configChanged);
 }
 
-RunCommandPlugin::~RunCommandPlugin()
-{
-}
-
 bool RunCommandPlugin::receivePacket(const NetworkPacket &np)
 {
     if (np.get<bool>(QStringLiteral("requestCommandList"), false)) {

plugins/runcommand/runcommandplugin.h

@@ -22,7 +22,6 @@ class Q_DECL_EXPORT RunCommandPlugin : public KdeConnectPlugin
 
 public:
     explicit RunCommandPlugin(QObject *parent, const QVariantList &args);
-    ~RunCommandPlugin() override;
 
     bool receivePacket(const NetworkPacket &np) override;
     void connected() override;

plugins/sendnotifications/notifyingapplicationmodel.cpp

@@ -21,10 +21,6 @@ NotifyingApplicationModel::NotifyingApplicationModel(QObject *parent)
 {
 }
 
-NotifyingApplicationModel::~NotifyingApplicationModel()
-{
-}
-
 QVector<NotifyingApplication> NotifyingApplicationModel::apps()
 {
     return m_apps;

plugins/sendnotifications/notifyingapplicationmodel.h

@@ -17,7 +17,6 @@ class NotifyingApplicationModel : public QAbstractTableModel
 
 public:
     explicit NotifyingApplicationModel(QObject *parent = nullptr);
-    ~NotifyingApplicationModel() override;
 
     QVariant data(const QModelIndex &index, int role) const override;
     bool setData(const QModelIndex &index, const QVariant &value, int role) override;

plugins/sftp/sftpplugin-win.cpp

@@ -25,10 +25,6 @@ SftpPlugin::SftpPlugin(QObject *parent, const QVariantList &args)
 {
 }
 
-SftpPlugin::~SftpPlugin()
-{
-}
-
 bool SftpPlugin::startBrowsing()
 {
     NetworkPacket np(PACKET_TYPE_SFTP_REQUEST, {{QStringLiteral("startBrowsing"), true}});

plugins/sftp/sftpplugin-win.h

@@ -22,7 +22,6 @@ class SftpPlugin : public KdeConnectPlugin
 
 public:
     explicit SftpPlugin(QObject *parent, const QVariantList &args);
-    ~SftpPlugin() override;
 
     bool receivePacket(const NetworkPacket &np) override;
     void connected() override