From 0b99c3a63789bcdc1e7e8bc31d2b115ed3ae49c7 Mon Sep 17 00:00:00 2001 From: Alexander Lohnau Date: Sat, 22 Jul 2023 10:38:48 +0200 Subject: [PATCH] Remove unneeded destructors from plugins We already have a destructor from the baseclass and don't need to clean up any resources in the affected plugins --- plugins/bigscreen/bigscreenplugin.cpp | 2 -- plugins/bigscreen/bigscreenplugin.h | 1 - plugins/findmyphone/findmyphoneplugin.cpp | 4 ---- plugins/findmyphone/findmyphoneplugin.h | 1 - plugins/findthisdevice/findthisdeviceplugin.cpp | 2 -- plugins/findthisdevice/findthisdeviceplugin.h | 1 - plugins/lockdevice/lockdeviceplugin-win.cpp | 4 ---- plugins/lockdevice/lockdeviceplugin-win.h | 1 - plugins/lockdevice/lockdeviceplugin.cpp | 4 ---- plugins/lockdevice/lockdeviceplugin.h | 1 - plugins/mousepad/waylandremoteinput.cpp | 4 ---- plugins/mousepad/waylandremoteinput.h | 1 - plugins/mprisremote/mprisremoteplayermediaplayer2.cpp | 2 -- plugins/mprisremote/mprisremoteplayermediaplayer2.h | 1 - plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp | 2 -- plugins/mprisremote/mprisremoteplayermediaplayer2player.h | 1 - plugins/mprisremote/mprisremoteplugin.cpp | 6 ------ plugins/mprisremote/mprisremoteplugin.h | 1 - plugins/notifications/notification.cpp | 4 ---- plugins/notifications/notification.h | 1 - plugins/photo/photoplugin.cpp | 4 ---- plugins/photo/photoplugin.h | 1 - plugins/presenter/presenterplugin.cpp | 4 ---- plugins/presenter/presenterplugin.h | 2 -- plugins/remotecommands/remotecommandsplugin.cpp | 2 -- plugins/remotecommands/remotecommandsplugin.h | 1 - plugins/remotecontrol/remotecontrolplugin.cpp | 4 ---- plugins/remotecontrol/remotecontrolplugin.h | 1 - plugins/remotekeyboard/remotekeyboardplugin.cpp | 4 ---- plugins/remotekeyboard/remotekeyboardplugin.h | 1 - plugins/remotesystemvolume/remotesystemvolumeplugin.cpp | 4 ---- plugins/remotesystemvolume/remotesystemvolumeplugin.h | 1 - plugins/runcommand/runcommand_config.cpp | 4 ---- plugins/runcommand/runcommand_config.h | 1 - plugins/runcommand/runcommandplugin.cpp | 4 ---- plugins/runcommand/runcommandplugin.h | 1 - plugins/sendnotifications/notifyingapplicationmodel.cpp | 4 ---- plugins/sendnotifications/notifyingapplicationmodel.h | 1 - plugins/sftp/sftpplugin-win.cpp | 4 ---- plugins/sftp/sftpplugin-win.h | 1 - 40 files changed, 93 deletions(-) diff --git a/plugins/bigscreen/bigscreenplugin.cpp b/plugins/bigscreen/bigscreenplugin.cpp index 86e817660..08921cc80 100644 --- a/plugins/bigscreen/bigscreenplugin.cpp +++ b/plugins/bigscreen/bigscreenplugin.cpp @@ -25,8 +25,6 @@ BigscreenPlugin::BigscreenPlugin(QObject *parent, const QVariantList &args) { } -BigscreenPlugin::~BigscreenPlugin() = default; - bool BigscreenPlugin::receivePacket(const NetworkPacket &np) { QString message = np.get(QStringLiteral("content")); diff --git a/plugins/bigscreen/bigscreenplugin.h b/plugins/bigscreen/bigscreenplugin.h index 83275ecd4..d1d67d25c 100644 --- a/plugins/bigscreen/bigscreenplugin.h +++ b/plugins/bigscreen/bigscreenplugin.h @@ -19,7 +19,6 @@ class Q_DECL_EXPORT BigscreenPlugin : public KdeConnectPlugin public: explicit BigscreenPlugin(QObject *parent, const QVariantList &args); - ~BigscreenPlugin() override; bool receivePacket(const NetworkPacket &np) override; void connected() override{}; diff --git a/plugins/findmyphone/findmyphoneplugin.cpp b/plugins/findmyphone/findmyphoneplugin.cpp index 589526a0f..8508c1a86 100644 --- a/plugins/findmyphone/findmyphoneplugin.cpp +++ b/plugins/findmyphone/findmyphoneplugin.cpp @@ -19,10 +19,6 @@ FindMyPhonePlugin::FindMyPhonePlugin(QObject *parent, const QVariantList &args) { } -FindMyPhonePlugin::~FindMyPhonePlugin() -{ -} - bool FindMyPhonePlugin::receivePacket(const NetworkPacket &np) { Q_UNUSED(np); diff --git a/plugins/findmyphone/findmyphoneplugin.h b/plugins/findmyphone/findmyphoneplugin.h index 1d10dd77a..95c4aad1f 100644 --- a/plugins/findmyphone/findmyphoneplugin.h +++ b/plugins/findmyphone/findmyphoneplugin.h @@ -20,7 +20,6 @@ class FindMyPhonePlugin : public KdeConnectPlugin public: explicit FindMyPhonePlugin(QObject *parent, const QVariantList &args); - ~FindMyPhonePlugin() override; Q_SCRIPTABLE void ring(); diff --git a/plugins/findthisdevice/findthisdeviceplugin.cpp b/plugins/findthisdevice/findthisdeviceplugin.cpp index 37e214b1b..42a2243b2 100644 --- a/plugins/findthisdevice/findthisdeviceplugin.cpp +++ b/plugins/findthisdevice/findthisdeviceplugin.cpp @@ -31,8 +31,6 @@ FindThisDevicePlugin::FindThisDevicePlugin(QObject *parent, const QVariantList & { } -FindThisDevicePlugin::~FindThisDevicePlugin() = default; - bool FindThisDevicePlugin::receivePacket(const NetworkPacket &np) { Q_UNUSED(np); diff --git a/plugins/findthisdevice/findthisdeviceplugin.h b/plugins/findthisdevice/findthisdeviceplugin.h index 1e6a06828..340d8798e 100644 --- a/plugins/findthisdevice/findthisdeviceplugin.h +++ b/plugins/findthisdevice/findthisdeviceplugin.h @@ -30,7 +30,6 @@ class FindThisDevicePlugin : public KdeConnectPlugin public: explicit FindThisDevicePlugin(QObject *parent, const QVariantList &args); - ~FindThisDevicePlugin() override; void connected() override{}; QString dbusPath() const override; diff --git a/plugins/lockdevice/lockdeviceplugin-win.cpp b/plugins/lockdevice/lockdeviceplugin-win.cpp index 15a86869d..99b08c74c 100644 --- a/plugins/lockdevice/lockdeviceplugin-win.cpp +++ b/plugins/lockdevice/lockdeviceplugin-win.cpp @@ -27,10 +27,6 @@ LockDevicePlugin::LockDevicePlugin(QObject *parent, const QVariantList &args) { } -LockDevicePlugin::~LockDevicePlugin() -{ -} - bool LockDevicePlugin::isLocked() const { return m_remoteLocked; // Windows doesn't support monitoring lock status, m_remoteLocked is never updated diff --git a/plugins/lockdevice/lockdeviceplugin-win.h b/plugins/lockdevice/lockdeviceplugin-win.h index 371bbd371..f6c18da33 100644 --- a/plugins/lockdevice/lockdeviceplugin-win.h +++ b/plugins/lockdevice/lockdeviceplugin-win.h @@ -22,7 +22,6 @@ class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin public: explicit LockDevicePlugin(QObject *parent, const QVariantList &args); - ~LockDevicePlugin() override; bool isLocked() const; Q_SCRIPTABLE void setLocked(bool); diff --git a/plugins/lockdevice/lockdeviceplugin.cpp b/plugins/lockdevice/lockdeviceplugin.cpp index facb03bca..612e03332 100644 --- a/plugins/lockdevice/lockdeviceplugin.cpp +++ b/plugins/lockdevice/lockdeviceplugin.cpp @@ -55,10 +55,6 @@ LockDevicePlugin::LockDevicePlugin(QObject *parent, const QVariantList &args) m_localLocked = m_login1Interface.lockedHint(); } -LockDevicePlugin::~LockDevicePlugin() -{ -} - bool LockDevicePlugin::isLocked() const { return m_remoteLocked; diff --git a/plugins/lockdevice/lockdeviceplugin.h b/plugins/lockdevice/lockdeviceplugin.h index 01a21681c..ff08fcc23 100644 --- a/plugins/lockdevice/lockdeviceplugin.h +++ b/plugins/lockdevice/lockdeviceplugin.h @@ -25,7 +25,6 @@ class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin public: explicit LockDevicePlugin(QObject *parent, const QVariantList &args); - ~LockDevicePlugin() override; bool isLocked() const; Q_SCRIPTABLE void setLocked(bool); diff --git a/plugins/mousepad/waylandremoteinput.cpp b/plugins/mousepad/waylandremoteinput.cpp index eb10810bb..6e6c4b64d 100644 --- a/plugins/mousepad/waylandremoteinput.cpp +++ b/plugins/mousepad/waylandremoteinput.cpp @@ -172,10 +172,6 @@ WaylandRemoteInput::WaylandRemoteInput(QObject *parent) { } -WaylandRemoteInput::~WaylandRemoteInput() -{ -} - bool WaylandRemoteInput::handlePacket(const NetworkPacket &np) { if (!s_session->isValid()) { diff --git a/plugins/mousepad/waylandremoteinput.h b/plugins/mousepad/waylandremoteinput.h index 44648506a..de9e4fff7 100644 --- a/plugins/mousepad/waylandremoteinput.h +++ b/plugins/mousepad/waylandremoteinput.h @@ -42,7 +42,6 @@ class WaylandRemoteInput : public AbstractRemoteInput public: explicit WaylandRemoteInput(QObject *parent); - ~WaylandRemoteInput(); bool handlePacket(const NetworkPacket &np) override; bool hasKeyboardSupport() override diff --git a/plugins/mprisremote/mprisremoteplayermediaplayer2.cpp b/plugins/mprisremote/mprisremoteplayermediaplayer2.cpp index ef383c592..9b3e74284 100644 --- a/plugins/mprisremote/mprisremoteplayermediaplayer2.cpp +++ b/plugins/mprisremote/mprisremoteplayermediaplayer2.cpp @@ -15,8 +15,6 @@ MprisRemotePlayerMediaPlayer2::MprisRemotePlayerMediaPlayer2(MprisRemotePlayer * { } -MprisRemotePlayerMediaPlayer2::~MprisRemotePlayerMediaPlayer2() = default; - bool MprisRemotePlayerMediaPlayer2::CanQuit() const { return false; diff --git a/plugins/mprisremote/mprisremoteplayermediaplayer2.h b/plugins/mprisremote/mprisremoteplayermediaplayer2.h index f227a40b4..1e3ce1fa3 100644 --- a/plugins/mprisremote/mprisremoteplayermediaplayer2.h +++ b/plugins/mprisremote/mprisremoteplayermediaplayer2.h @@ -25,7 +25,6 @@ class MprisRemotePlayerMediaPlayer2 : public QDBusAbstractAdaptor public: explicit MprisRemotePlayerMediaPlayer2(MprisRemotePlayer *parent, const MprisRemotePlugin *plugin); - ~MprisRemotePlayerMediaPlayer2() override; public Q_SLOTS: void Raise(); diff --git a/plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp b/plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp index bdc64a116..b42e583b3 100644 --- a/plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp +++ b/plugins/mprisremote/mprisremoteplayermediaplayer2player.cpp @@ -27,8 +27,6 @@ MprisRemotePlayerMediaPlayer2Player::MprisRemotePlayerMediaPlayer2Player(MprisRe connect(m_parent, &MprisRemotePlayer::playingChanged, this, &MprisRemotePlayerMediaPlayer2Player::playingChanged); } -MprisRemotePlayerMediaPlayer2Player::~MprisRemotePlayerMediaPlayer2Player() = default; - QString MprisRemotePlayerMediaPlayer2Player::PlaybackStatus() const { if (m_parent->playing()) { diff --git a/plugins/mprisremote/mprisremoteplayermediaplayer2player.h b/plugins/mprisremote/mprisremoteplayermediaplayer2player.h index be0028b9b..7937ab09c 100644 --- a/plugins/mprisremote/mprisremoteplayermediaplayer2player.h +++ b/plugins/mprisremote/mprisremoteplayermediaplayer2player.h @@ -33,7 +33,6 @@ class MprisRemotePlayerMediaPlayer2Player : public QDBusAbstractAdaptor public: explicit MprisRemotePlayerMediaPlayer2Player(MprisRemotePlayer *parent, MprisRemotePlugin *plugin); - ~MprisRemotePlayerMediaPlayer2Player() override; public Q_SLOTS: void Next(); diff --git a/plugins/mprisremote/mprisremoteplugin.cpp b/plugins/mprisremote/mprisremoteplugin.cpp index 6631afbe0..d3cc1fc64 100644 --- a/plugins/mprisremote/mprisremoteplugin.cpp +++ b/plugins/mprisremote/mprisremoteplugin.cpp @@ -18,12 +18,6 @@ K_PLUGIN_CLASS_WITH_JSON(MprisRemotePlugin, "kdeconnect_mprisremote.json") MprisRemotePlugin::MprisRemotePlugin(QObject *parent, const QVariantList &args) : KdeConnectPlugin(parent, args) - , m_currentPlayer() - , m_players() -{ -} - -MprisRemotePlugin::~MprisRemotePlugin() { } diff --git a/plugins/mprisremote/mprisremoteplugin.h b/plugins/mprisremote/mprisremoteplugin.h index d7723d58d..b07638050 100644 --- a/plugins/mprisremote/mprisremoteplugin.h +++ b/plugins/mprisremote/mprisremoteplugin.h @@ -33,7 +33,6 @@ class Q_DECL_EXPORT MprisRemotePlugin : public KdeConnectPlugin public: explicit MprisRemotePlugin(QObject *parent, const QVariantList &args); - ~MprisRemotePlugin() override; long position() const; int volume() const; diff --git a/plugins/notifications/notification.cpp b/plugins/notifications/notification.cpp index 61cca8333..ded40ed20 100644 --- a/plugins/notifications/notification.cpp +++ b/plugins/notifications/notification.cpp @@ -61,10 +61,6 @@ Notification::Notification(const NetworkPacket &np, const Device *device, QObjec }); } -Notification::~Notification() -{ -} - void Notification::dismiss() { if (m_dismissable) { diff --git a/plugins/notifications/notification.h b/plugins/notifications/notification.h index e64a0c640..20c567417 100644 --- a/plugins/notifications/notification.h +++ b/plugins/notifications/notification.h @@ -33,7 +33,6 @@ class Notification : public QObject public: Notification(const NetworkPacket &np, const Device *device, QObject *parent); - ~Notification() override; QString internalId() const { diff --git a/plugins/photo/photoplugin.cpp b/plugins/photo/photoplugin.cpp index 3ab7f855d..85b500c39 100644 --- a/plugins/photo/photoplugin.cpp +++ b/plugins/photo/photoplugin.cpp @@ -20,10 +20,6 @@ PhotoPlugin::PhotoPlugin(QObject *parent, const QVariantList &args) { } -PhotoPlugin::~PhotoPlugin() -{ -} - bool PhotoPlugin::receivePacket(const NetworkPacket &np) { if (np.get(QStringLiteral("cancel"))) { diff --git a/plugins/photo/photoplugin.h b/plugins/photo/photoplugin.h index 79f8db19a..582fee32d 100644 --- a/plugins/photo/photoplugin.h +++ b/plugins/photo/photoplugin.h @@ -21,7 +21,6 @@ class Q_DECL_EXPORT PhotoPlugin : public KdeConnectPlugin public: explicit PhotoPlugin(QObject *parent, const QVariantList &args); - ~PhotoPlugin() override; Q_SCRIPTABLE void requestPhoto(const QString &url); diff --git a/plugins/presenter/presenterplugin.cpp b/plugins/presenter/presenterplugin.cpp index 53b209a60..325b2de78 100644 --- a/plugins/presenter/presenterplugin.cpp +++ b/plugins/presenter/presenterplugin.cpp @@ -58,10 +58,6 @@ PresenterPlugin::PresenterPlugin(QObject *parent, const QVariantList &args) m_timer->setSingleShot(true); } -PresenterPlugin::~PresenterPlugin() -{ -} - bool PresenterPlugin::receivePacket(const NetworkPacket &np) { if (np.get(QStringLiteral("stop"), false)) { diff --git a/plugins/presenter/presenterplugin.h b/plugins/presenter/presenterplugin.h index 877400032..d66495390 100644 --- a/plugins/presenter/presenterplugin.h +++ b/plugins/presenter/presenterplugin.h @@ -24,8 +24,6 @@ class Q_DECL_EXPORT PresenterPlugin : public KdeConnectPlugin public: explicit PresenterPlugin(QObject *parent, const QVariantList &args); - ~PresenterPlugin() override; - bool receivePacket(const NetworkPacket &np) override; void connected() override { diff --git a/plugins/remotecommands/remotecommandsplugin.cpp b/plugins/remotecommands/remotecommandsplugin.cpp index 717420de7..2a7ce24a7 100644 --- a/plugins/remotecommands/remotecommandsplugin.cpp +++ b/plugins/remotecommands/remotecommandsplugin.cpp @@ -24,8 +24,6 @@ RemoteCommandsPlugin::RemoteCommandsPlugin(QObject *parent, const QVariantList & { } -RemoteCommandsPlugin::~RemoteCommandsPlugin() = default; - bool RemoteCommandsPlugin::receivePacket(const NetworkPacket &np) { if (np.has(QStringLiteral("commandList"))) { diff --git a/plugins/remotecommands/remotecommandsplugin.h b/plugins/remotecommands/remotecommandsplugin.h index 96d0e8722..7dfc0f854 100644 --- a/plugins/remotecommands/remotecommandsplugin.h +++ b/plugins/remotecommands/remotecommandsplugin.h @@ -22,7 +22,6 @@ class Q_DECL_EXPORT RemoteCommandsPlugin : public KdeConnectPlugin public: explicit RemoteCommandsPlugin(QObject *parent, const QVariantList &args); - ~RemoteCommandsPlugin() override; Q_SCRIPTABLE void triggerCommand(const QString &key); Q_SCRIPTABLE void editCommands(); diff --git a/plugins/remotecontrol/remotecontrolplugin.cpp b/plugins/remotecontrol/remotecontrolplugin.cpp index eedfcf3ac..e2862fb1b 100644 --- a/plugins/remotecontrol/remotecontrolplugin.cpp +++ b/plugins/remotecontrol/remotecontrolplugin.cpp @@ -23,10 +23,6 @@ RemoteControlPlugin::RemoteControlPlugin(QObject *parent, const QVariantList &ar { } -RemoteControlPlugin::~RemoteControlPlugin() -{ -} - void RemoteControlPlugin::moveCursor(const QPoint &p) { NetworkPacket np(PACKET_TYPE_MOUSEPAD_REQUEST, {{QStringLiteral("dx"), p.x()}, {QStringLiteral("dy"), p.y()}}); diff --git a/plugins/remotecontrol/remotecontrolplugin.h b/plugins/remotecontrol/remotecontrolplugin.h index 5ec0c7ffd..8da1946ec 100644 --- a/plugins/remotecontrol/remotecontrolplugin.h +++ b/plugins/remotecontrol/remotecontrolplugin.h @@ -20,7 +20,6 @@ class Q_DECL_EXPORT RemoteControlPlugin : public KdeConnectPlugin public: explicit RemoteControlPlugin(QObject *parent, const QVariantList &args); - ~RemoteControlPlugin() override; bool receivePacket(const NetworkPacket & /*np*/) override { diff --git a/plugins/remotekeyboard/remotekeyboardplugin.cpp b/plugins/remotekeyboard/remotekeyboardplugin.cpp index 1985efccf..d24a0191b 100644 --- a/plugins/remotekeyboard/remotekeyboardplugin.cpp +++ b/plugins/remotekeyboard/remotekeyboardplugin.cpp @@ -58,10 +58,6 @@ RemoteKeyboardPlugin::RemoteKeyboardPlugin(QObject *parent, const QVariantList & { } -RemoteKeyboardPlugin::~RemoteKeyboardPlugin() -{ -} - bool RemoteKeyboardPlugin::receivePacket(const NetworkPacket &np) { if (np.type() == PACKET_TYPE_MOUSEPAD_ECHO) { diff --git a/plugins/remotekeyboard/remotekeyboardplugin.h b/plugins/remotekeyboard/remotekeyboardplugin.h index 901d09107..f5001fa3d 100644 --- a/plugins/remotekeyboard/remotekeyboardplugin.h +++ b/plugins/remotekeyboard/remotekeyboardplugin.h @@ -28,7 +28,6 @@ private: public: explicit RemoteKeyboardPlugin(QObject *parent, const QVariantList &args); - ~RemoteKeyboardPlugin() override; bool receivePacket(const NetworkPacket &np) override; QString dbusPath() const override; diff --git a/plugins/remotesystemvolume/remotesystemvolumeplugin.cpp b/plugins/remotesystemvolume/remotesystemvolumeplugin.cpp index e9fd7607d..35a843abf 100644 --- a/plugins/remotesystemvolume/remotesystemvolumeplugin.cpp +++ b/plugins/remotesystemvolume/remotesystemvolumeplugin.cpp @@ -26,10 +26,6 @@ RemoteSystemVolumePlugin::RemoteSystemVolumePlugin(QObject *parent, const QVaria { } -RemoteSystemVolumePlugin::~RemoteSystemVolumePlugin() -{ -} - bool RemoteSystemVolumePlugin::receivePacket(const NetworkPacket &np) { if (np.has(QStringLiteral("sinkList"))) { diff --git a/plugins/remotesystemvolume/remotesystemvolumeplugin.h b/plugins/remotesystemvolume/remotesystemvolumeplugin.h index 87d6dac56..a9721b092 100644 --- a/plugins/remotesystemvolume/remotesystemvolumeplugin.h +++ b/plugins/remotesystemvolume/remotesystemvolumeplugin.h @@ -23,7 +23,6 @@ class Q_DECL_EXPORT RemoteSystemVolumePlugin : public KdeConnectPlugin public: explicit RemoteSystemVolumePlugin(QObject *parent, const QVariantList &args); - ~RemoteSystemVolumePlugin() override; bool receivePacket(const NetworkPacket &np) override; void connected() override; diff --git a/plugins/runcommand/runcommand_config.cpp b/plugins/runcommand/runcommand_config.cpp index 21e6a0f0f..101fb8a62 100644 --- a/plugins/runcommand/runcommand_config.cpp +++ b/plugins/runcommand/runcommand_config.cpp @@ -93,10 +93,6 @@ RunCommandConfig::RunCommandConfig(QObject *parent, const QVariantList &args) m_entriesModel->setHorizontalHeaderLabels(QStringList() << i18n("Name") << i18n("Command")); } -RunCommandConfig::~RunCommandConfig() -{ -} - void RunCommandConfig::exportCommands() { QString filePath = QFileDialog::getSaveFileName(widget(), i18n("Export Commands"), QDir::homePath(), QStringLiteral("JSON (*.json)")); diff --git a/plugins/runcommand/runcommand_config.h b/plugins/runcommand/runcommand_config.h index 72ba0c0f2..b76c559a4 100644 --- a/plugins/runcommand/runcommand_config.h +++ b/plugins/runcommand/runcommand_config.h @@ -17,7 +17,6 @@ class RunCommandConfig : public KdeConnectPluginKcm Q_OBJECT public: RunCommandConfig(QObject *parent, const QVariantList &); - ~RunCommandConfig() override; public Q_SLOTS: void save() override; diff --git a/plugins/runcommand/runcommandplugin.cpp b/plugins/runcommand/runcommandplugin.cpp index b2a00abf5..6c566d586 100644 --- a/plugins/runcommand/runcommandplugin.cpp +++ b/plugins/runcommand/runcommandplugin.cpp @@ -37,10 +37,6 @@ RunCommandPlugin::RunCommandPlugin(QObject *parent, const QVariantList &args) connect(config(), &KdeConnectPluginConfig::configChanged, this, &RunCommandPlugin::configChanged); } -RunCommandPlugin::~RunCommandPlugin() -{ -} - bool RunCommandPlugin::receivePacket(const NetworkPacket &np) { if (np.get(QStringLiteral("requestCommandList"), false)) { diff --git a/plugins/runcommand/runcommandplugin.h b/plugins/runcommand/runcommandplugin.h index 1bcb2816f..e8d21da1c 100644 --- a/plugins/runcommand/runcommandplugin.h +++ b/plugins/runcommand/runcommandplugin.h @@ -22,7 +22,6 @@ class Q_DECL_EXPORT RunCommandPlugin : public KdeConnectPlugin public: explicit RunCommandPlugin(QObject *parent, const QVariantList &args); - ~RunCommandPlugin() override; bool receivePacket(const NetworkPacket &np) override; void connected() override; diff --git a/plugins/sendnotifications/notifyingapplicationmodel.cpp b/plugins/sendnotifications/notifyingapplicationmodel.cpp index e4d4758d1..0309ad5ec 100644 --- a/plugins/sendnotifications/notifyingapplicationmodel.cpp +++ b/plugins/sendnotifications/notifyingapplicationmodel.cpp @@ -21,10 +21,6 @@ NotifyingApplicationModel::NotifyingApplicationModel(QObject *parent) { } -NotifyingApplicationModel::~NotifyingApplicationModel() -{ -} - QVector NotifyingApplicationModel::apps() { return m_apps; diff --git a/plugins/sendnotifications/notifyingapplicationmodel.h b/plugins/sendnotifications/notifyingapplicationmodel.h index aee545613..e0cf164f8 100644 --- a/plugins/sendnotifications/notifyingapplicationmodel.h +++ b/plugins/sendnotifications/notifyingapplicationmodel.h @@ -17,7 +17,6 @@ class NotifyingApplicationModel : public QAbstractTableModel public: explicit NotifyingApplicationModel(QObject *parent = nullptr); - ~NotifyingApplicationModel() override; QVariant data(const QModelIndex &index, int role) const override; bool setData(const QModelIndex &index, const QVariant &value, int role) override; diff --git a/plugins/sftp/sftpplugin-win.cpp b/plugins/sftp/sftpplugin-win.cpp index da9c45ba2..09cae9e90 100644 --- a/plugins/sftp/sftpplugin-win.cpp +++ b/plugins/sftp/sftpplugin-win.cpp @@ -25,10 +25,6 @@ SftpPlugin::SftpPlugin(QObject *parent, const QVariantList &args) { } -SftpPlugin::~SftpPlugin() -{ -} - bool SftpPlugin::startBrowsing() { NetworkPacket np(PACKET_TYPE_SFTP_REQUEST, {{QStringLiteral("startBrowsing"), true}}); diff --git a/plugins/sftp/sftpplugin-win.h b/plugins/sftp/sftpplugin-win.h index 4f3331088..67185a39a 100644 --- a/plugins/sftp/sftpplugin-win.h +++ b/plugins/sftp/sftpplugin-win.h @@ -22,7 +22,6 @@ class SftpPlugin : public KdeConnectPlugin public: explicit SftpPlugin(QObject *parent, const QVariantList &args); - ~SftpPlugin() override; bool receivePacket(const NetworkPacket &np) override; void connected() override