tristan/ZealOS
1
0
Fork 0
mirror of https://github.com/Zeal-Operating-System/ZealOS.git synced 2025-01-13 16:16:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update DiskAHCI.ZC debug fixme comment.

Browse source
This commit is contained in:
TomAwezome 2022-10-16 19:35:23 -04:00
parent 5b6b84202f
commit 41e5901934
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/Kernel/BlkDev/DiskAHCI.ZC
View file

@ -7,10 +7,12 @@
- AHCIATAPISetMaxSpeed needs to be implemented - AHCIATAPISetMaxSpeed needs to be implemented
- TODO FIXME: certain Bt() and Bts() on AHCI memory areas, and variable casting, - TODO FIXME: Variable casting into AHCI memory-mapped areas caused strange crashes
caused strange crashes on a Ryzen with Gigabyte brand motherboard. Bit test on a Ryzen with Gigabyte brand motherboard, all PCI devices AMD brand.
function implementation and compiler casting internal functionality need Compiler casting internal functionality needs to be researched to fix those bugs.
to be researched to fix those bugs. Example line that caused crashes with Page Faults and bad memory address on Ryzen:
cmd_header = &port->cmd_list_base(CPortCmdHeader *)[i];
*/ */
I64 AHCI_DEBUG = FALSE; I64 AHCI_DEBUG = FALSE;
@ -584,7 +586,6 @@ U0 AHCIPortIdentify(CBlkDev *bd)
AHCIPortWait(bd->port_num, tS + 2); AHCIPortWait(bd->port_num, tS + 2);
Bts(&port->cmd_issue, cmd_slot); //Issue the command. Bts(&port->cmd_issue, cmd_slot); //Issue the command.
AHCIPortCmdWait(bd->port_num, cmd_slot); AHCIPortCmdWait(bd->port_num, cmd_slot);
Free(bd->dev_id_record); Free(bd->dev_id_record);