From 41e590193499dac35dfb4c230bb4d27832703e25 Mon Sep 17 00:00:00 2001 From: TomAwezome Date: Sun, 16 Oct 2022 19:35:23 -0400 Subject: [PATCH] Update DiskAHCI.ZC debug fixme comment. --- src/Kernel/BlkDev/DiskAHCI.ZC | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Kernel/BlkDev/DiskAHCI.ZC b/src/Kernel/BlkDev/DiskAHCI.ZC index ec08cf4f..ba66bf91 100755 --- a/src/Kernel/BlkDev/DiskAHCI.ZC +++ b/src/Kernel/BlkDev/DiskAHCI.ZC @@ -7,10 +7,12 @@ - AHCIATAPISetMaxSpeed needs to be implemented -- TODO FIXME: certain Bt() and Bts() on AHCI memory areas, and variable casting, - caused strange crashes on a Ryzen with Gigabyte brand motherboard. Bit test - function implementation and compiler casting internal functionality need - to be researched to fix those bugs. +- TODO FIXME: Variable casting into AHCI memory-mapped areas caused strange crashes + on a Ryzen with Gigabyte brand motherboard, all PCI devices AMD brand. + Compiler casting internal functionality needs to be researched to fix those bugs. + Example line that caused crashes with Page Faults and bad memory address on Ryzen: + cmd_header = &port->cmd_list_base(CPortCmdHeader *)[i]; + */ I64 AHCI_DEBUG = FALSE; @@ -584,7 +586,6 @@ U0 AHCIPortIdentify(CBlkDev *bd) AHCIPortWait(bd->port_num, tS + 2); Bts(&port->cmd_issue, cmd_slot); //Issue the command. - AHCIPortCmdWait(bd->port_num, cmd_slot); Free(bd->dev_id_record);