tristan/rustlings
1
0
Fork 0
mirror of https://github.com/rust-lang/rustlings.git synced 2024-12-27 15:56:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
915 commits 2 branches 51 tags 33 MiB
Commit graph

93 commits

Author SHA1 Message Date
Taylor Yu
882d535ba8 feat: add advanced_errs1 
New section and exercise to demonstrate the `From` trait for errors
and its usefulness with the `?` operator.
 2021-09-25 11:18:21 +02:00
Taylor Yu
2dc93cadda fix(from_str, try_from_into): custom error types 
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.

Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
 2021-06-24 21:33:41 -05:00
marisa
a3ea37b76e
Merge pull request #771 from tlyu/iterators5-trait-tweak 
fix(iterators5): derive Clone, Copy
 2021-06-24 14:17:05 +02:00
Taylor Yu
b7ddd09fab address review feedback 
Adjust error text and naming to conform with best practices.
Use `map_err()` instead of `or()`. Wrap lower-level errors instead of
ignoring their details.

Also, don't "cheat" by bypassing the `new()` function in tests.

Fix a dangling reference in the try_from_into hints.
 2021-06-09 23:27:53 -05:00
Taylor Yu
68d3ac567c feature: improve error_handling exercises 
Add new exercises errors5 and errors6, to introduce boxed errors and
custom error enums more gently. Delete errorsn, because it tried to do
too much too soon.
 2021-06-06 23:08:57 -05:00
Taylor Yu
50ab289da6 fix: rename result1 to errors4 
Also put it in the ERROR HANDLING section where it probably belongs.
 2021-06-06 23:08:54 -05:00
Taylor Yu
4e079fdd08 chore(iterators5): conciseness hint 2021-06-06 17:45:35 -05:00
Taylor Yu
1b85828548 fix: move_semantics5 hints 
Improve the hints for move_semantics5, as well as the explanatory
comments in the code.

Previously, it was not clear what possible changes were allowed.
It seems that reordering the statements might be the intended solution.
The previous comment about not "adding newlines" doesn't make sense,
so treating it as "adding new lines" makes it more clear.
 2021-05-22 22:09:58 -05:00
Taylor Yu
4c46e5e1a3 chore: minor typos in move_semantics5 hints 2021-05-22 21:56:14 -05:00
Sateesh
399ab328d8
feat: Add move_semantics5 exercise. (#746) 
* feat: Add move_semantics5 exercise.

* feat: Add option3 exercise

* Address review comments. Fix typos, sentence formatting.

* Remove unwanted newline.

* Address review comments: make comment inline, fix format in print.
 2021-05-17 14:10:40 +02:00
Taylor Yu
11d2cf0d60 fix(try_from_into, from_str): hints for dyn Error 
Add hints about how to return the correct type for functions that
return `Result<_, Box<dyn Error>`. Some feedback from Discord suggests
that people run into trouble with that.
 2021-05-15 14:01:17 -05:00
Brandon Macer
81be404487
feat(arc1): Add more details to description and hint (#710) 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
 2021-04-21 14:50:03 +02:00
marisa
79cc657917
Merge pull request #646 from apogeeoak/iterator 
Added iterators5.rs exercise.
 2021-04-21 10:10:50 +02:00
apogeeoak
9c88ea9126 Improved iterators5.rs explanation. 2021-04-20 18:55:04 -04:00
marisa
2b766ef9f9
Merge pull request #648 from apogeeoak/iterator2 
Moved iterators2.rs errors out of tests.
 2021-04-20 11:24:10 +02:00
marisa
bd3d9ac9d5
Merge pull request #649 from apogeeoak/iterator3 
Enabled iterators3.rs to run without commented out tests.
 2021-04-20 11:22:39 +02:00
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming 
Update collections exercises naming
 2021-04-13 10:39:18 -04:00
Taylor Yu
c3e7b83178 fix: use trait objects for from_str 
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate 
errors.
 2021-04-04 18:56:10 -05:00
Mickael Fortunato
bef39b1259 fix(collections): Naming exercises for vectors and hashmap 2021-03-18 19:11:04 +01:00
apogeeoak
96c56ab08a
chore: changed errors3 mode from test to compile 2021-03-12 20:04:29 +01:00
Cyrus Wyett
5157f56875
chore: fix typo 
is however some --> are however some
 2021-03-12 15:38:28 +01:00
apogeeoak
c6712dfccd fix(iterators3): Enabled iterators3.rs to run without commented out tests. 2021-02-12 15:36:53 -05:00
apogeeoak
baf4ba175b fix(iterators2): Moved errors out of tests. 
Closes #359
 2021-02-11 21:24:32 -05:00
apogeeoak
b29ea17ea9 feat: Added iterators5.rs exercise. 2021-02-10 18:03:29 -05:00
John Baber-Lucero
cddc1e86e7
fix(info): Fix typo (#635) 
Co-authored-by: John Baber-Lucero <git@frundle.com>
 2021-01-30 17:12:06 +01:00
fmoko
5772589dc3
Merge pull request #615 from wsh/docfixes 
docs: mention flatten in the options2 hint
 2021-01-04 14:12:11 +01:00
Will Hayworth
e9b42bbc2a docs: mention flatten in the options2 hint 2021-01-03 03:42:39 -08:00
JuliaCao
90cfb6ff28 fix: added missing exercises to info.toml 2020-12-12 10:34:59 -08:00
JuliaCao
033bf1198f
feat: match exercise order to book chapters (#541) 
Added exercise to book chapter mapping table to exercise README
 2020-12-07 15:37:19 +01:00
Brock
9334783da3
fix(structs1): Adjust wording (#573) 
Co-authored-by: fmoko <mokou@posteo.de>
 2020-11-08 10:31:45 +01:00
sazid
633c00cf80 feat: Add HashMap exercises 2020-10-31 01:11:04 +06:00
sazid
0c12fa31c5 feat: Add Vec exercises 2020-10-31 01:10:49 +06:00
Rastamo
e6bde22f9c
chore: primitive_types6 mode changed to test (#559) 
primitive_types6 exercise was changed to test yesterday, but info.toml file wasn't updated.
I think this change should fix it.
 2020-10-11 14:00:03 +02:00
fmoko
0f16463794
Merge pull request #489 from mukundbhudia/iterators1 2020-09-18 15:23:28 +02:00
Mukund Bhudia
8ff5fde88e
Update info.toml for typo fix 
Co-authored-by: Andrew Marquez <andy2mgcc@gmail.com>
 2020-09-18 10:40:11 +01:00
Ryan McQuen
3286c5ec19
fix(using_as): Add test so that proper type is returned. (#512) 2020-09-07 19:09:27 +02:00
Koalab99
ee7cdc66b3
chore: Removed extra whitespaces 
Co-authored-by: Corentin ARNOULD <corentin.arn@gmail.com>
 2020-08-27 19:51:19 +02:00
Mukund Bhudia
9642f5a3f6 feat: Added iterators1.rs exercise 2020-08-04 12:57:01 +01:00
iamcastelli
ddd98ad75d
fix: Change then to than 
`than` makes more grammatical sense than `then` in this context.
 2020-06-27 15:58:53 +04:00
fmoko
e1e453075f
Merge pull request #422 from AbdouSeck/show-tests-prints 2020-06-12 23:04:51 +02:00
Alexx Roche
e6bd8021d9
fix(generics2): Guide students to the answer (#430) 2020-06-09 13:54:18 +02:00
Abdou Seck
8ad5f9bf53 feat: Add a --nocapture option to display test harnesses' outputs 
This new feature can be accessed by invoking rustlings with --nocapture.

Both unit and integration tests added.

closes #262

BREAKING CHANGES:
The following function take a new boolean argument:
	* `run`
	* `verify`
	* `test`
	* `compile_and_test`
 2020-06-04 11:18:26 -04:00
Alexx Roche
0dd1c6ca6b
fix: rename quiz1 to tests1 in info (#420) 
`rustlings run tests1` wasn't working because of this typo.
 2020-06-03 20:07:06 +02:00
fmoko
5f0806967c
Merge pull request #409 from AlexandruGG/feature/box-exercise 2020-05-30 17:58:16 +02:00
Allan Soares Duarte
500422d594
chore: Update variables6.rs book link 2020-05-28 09:33:15 +02:00
AlexandruGG
df81141d6f Address PR feedback: add tests 2020-05-27 10:03:59 +01:00
AlexandruGG
7479a4737b feat: Add box1.rs exercise 2020-05-26 21:46:24 +01:00
Sanjay K
010a045692
feat: renames test to quiz, fixes #244 
BREAKING CHANGE

* changed test to quiz: fixes issues in #244
* fixed info.toml: #244
* fixed naming related issues
 2020-05-19 18:47:44 +02:00
IkaR49
763aa6e378
feat: Rewrite try_from_into (#393) 2020-05-15 23:02:57 +02:00
Jawaad Mahmood
9f75554f2a
fix(options1): Add hint about Array Initialization (#389) 2020-05-10 13:21:29 +02:00