kdeconnect-kde/indicator
Ryan Adolf 531418c7d2 Change tray icon so it is the right color on MacOS
## Summary

On MacOS the system tray icon is off-color because it uses the gray-colored `kdeconnectindicatordark` icon which does not match the rest of MacOS.

![image](/uploads/430933399d9570dc1c59807e4715e87b/image.png)

BUG: 430226

I've used two patches to fix this:
1. Always use the status `KStatusNotifierItem::Passive` on MacOS. `KStatusNotifierItem` will only mark the icon as a mask (which is needed to allow it to dynamically switch between light and dark theme) [if the status is passive](cff7c337ab/src/kstatusnotifieritem.cpp (L1079-1081)).
2. The above should theoretically be enough to fix the issue and I swear at one point it was all that was needed. However, to fix this issue in my dev environment I also needed to pass in a `QIcon` with `setIsMask(true)` instead of setting the icon by its name. And I also use the `kdeconnectindicator` instead of `kdeconnectindicatordark` icon.

## Test Plan

The icon now renders in the correct color, regardless of whether devices are connected:

![image](/uploads/5010a07cbb5f23a286ece641c6b3879c/image.png) ![image](/uploads/2ae5d3d8aa633ebafb260febe313057c/image.png)

## Future work

Once I've verified this PR is working in the right direction, I want to look into making the icon gray (and hopefully a much easier-to-see gray) when no devices are connected!

For example, WireGuard, when not connected, looks like this:

![image](/uploads/43c2ef6bc7261431e878c9c1c05174f9/image.png) ![image](/uploads/f7587190648606df77ad3e3dde84098f/image.png)

P.S. I've been testing off the v21.12.2 tag since the master branch doesn't compile for me, so I haven't tested this change on the latest dev commit. But there should be no conflicts.
2022-03-02 12:06:36 +00:00
..
systray_actions connectivity_action: replace manual ifs with code 2021-07-13 23:25:02 +05:30
CMakeLists.txt indicator: add connectivity action 2021-06-17 15:03:21 +00:00
deviceindicator.cpp deviceindicator: add path to look in for kdeconnect-handler.exe 2021-06-25 14:15:02 +05:30
deviceindicator.h Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
indicatorhelper.cpp Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
indicatorhelper.h indicatorhelper_win: make sure we kill all kdeconnect executables when Quit is triggered 2021-06-15 13:34:17 +05:30
indicatorhelper_mac.cpp Change tray icon so it is the right color on MacOS 2022-03-02 12:06:36 +00:00
indicatorhelper_win.cpp indicatorhelper_win: make sure we kill all kdeconnect executables when Quit is triggered 2021-06-15 13:34:17 +05:30
Info.plist Add "Send File via KDE Connect" Finder integration on macOS 2020-05-19 13:41:02 +00:00
main.cpp Change tray icon so it is the right color on MacOS 2022-03-02 12:06:36 +00:00
Messages.sh Fix i18n: extract messages 2019-12-21 16:16:33 +02:00
org.kde.kdeconnect.nonplasma.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2022-02-20 01:45:04 +00:00
serviceregister_mac.h Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
serviceregister_mac.mm Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00