c315170be5
## Summary The core idea is as follows: 1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries. 1. If the list is empty, we print a warning message and return quickly 2. Otherwise, we connect *two signals* to every object in that list 2. We send out a single new NetworkPacket as soon as we've processed that list 3. When either of those two signals emits, we send another new NetworkPacket ### Multi-battery Support BUG: 357193 To handle devices with multiple batteries (requested in that bug), we average together the battery percentages. This also includes a new field in the packet for 'number of batteries' called `batteryQuantity`. For backwards compatibility, we can assume it has a default value of one. This should ensure we support - devices with no batteries at all (like many desktop machines) - devices with hot-pluggable batteries (like those laptops with detachable screens) ### Concerns Note that the implementation isn't perfect. We'll need some new localizable text to make it clear that we now support sending battery status information. Then there's a rather significant question: maybe we should have two battery plugins on each client, like we do for the `findmyphone`/`findthisdevice` plugins? ## Test Plan We need to ensure that other clients (including those using the Android codebase) will respond correctly. The main things to look at are 1. are these new packets sent when the plugin is enabled, and not sent when it's disabled? 2. is the charge percentage accurate? 3. is the charge state (charging, discharging, or full) accurate? and 4. do we see the correct number of warnings for low-battery?
62 lines
2 KiB
C++
62 lines
2 KiB
C++
/**
|
|
* Copyright 2013 Albert Vaca <albertvaka@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef BATTERYPLUGIN_H
|
|
#define BATTERYPLUGIN_H
|
|
|
|
#include <QLoggingCategory>
|
|
#include <core/kdeconnectplugin.h>
|
|
|
|
#define PACKET_TYPE_BATTERY QStringLiteral("kdeconnect.battery")
|
|
#define PACKET_TYPE_BATTERY_REQUEST QStringLiteral("kdeconnect.battery.request")
|
|
|
|
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_BATTERY)
|
|
class BatteryDbusInterface;
|
|
|
|
class BatteryPlugin
|
|
: public KdeConnectPlugin
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit BatteryPlugin(QObject* parent, const QVariantList& args);
|
|
~BatteryPlugin() override;
|
|
|
|
bool receivePacket(const NetworkPacket& np) override;
|
|
void connected() override;
|
|
|
|
// NB: This may be connected to zero or two signals in Solid::Battery -
|
|
// chargePercentageChanged and chargeStatusChanged.
|
|
// See inline comments for further details
|
|
void chargeChanged();
|
|
|
|
private:
|
|
// Keep these values in sync with THRESHOLD* constants in
|
|
// kdeconnect-android:BatteryPlugin.java
|
|
// see README for their meaning
|
|
enum ThresholdBatteryEvent {
|
|
ThresholdNone = 0,
|
|
ThresholdBatteryLow = 1
|
|
};
|
|
|
|
BatteryDbusInterface* batteryDbusInterface;
|
|
};
|
|
|
|
#endif
|