kdeconnect-kde/core/backends/bluetooth/bluetoothdevicelink.cpp
Ali Abdel-Qader bbac0aa085 Use explicit constructor for QSslCertificate with value initialized
argument

Previously the BluetoothDeviceLink::certificate() method was returning a
value initialized object which I believe default initializes the object.
However, Clang throws a build error at this because QSslCertificate has
explicit constructors. This change uses one of those constructors and
uses value intialization to default construct/initialize the argument
for it. It fixes the build and hopefully doesn't break anything since
this is a TODO anyways!

BUG: 469428

Signed-off-by: Ali Abdel-Qader <abdelqaderali@protonmail.com>
2023-05-06 15:51:53 -04:00

103 lines
3.3 KiB
C++

/**
* SPDX-FileCopyrightText: 2016 Saikrishna Arcot <saiarcot895@gmail.com>
*
* SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
*/
#include "bluetoothdevicelink.h"
#include "../linkprovider.h"
#include "bluetoothdownloadjob.h"
#include "bluetoothlinkprovider.h"
#include "bluetoothuploadjob.h"
#include "connectionmultiplexer.h"
#include "core_debug.h"
#include "multiplexchannel.h"
BluetoothDeviceLink::BluetoothDeviceLink(const QString &deviceId,
LinkProvider *parent,
ConnectionMultiplexer *connection,
QSharedPointer<MultiplexChannel> socket)
: DeviceLink(deviceId, parent)
, mSocketReader(new DeviceLineReader(socket.data(), this))
, mConnection(connection)
, mChannel(socket)
, mPairingHandler(new BluetoothPairingHandler(this))
{
connect(mSocketReader, &DeviceLineReader::readyRead, this, &BluetoothDeviceLink::dataReceived);
// We take ownership of the connection.
// When the link provider destroys us,
// the socket (and the reader) will be
// destroyed as well
mConnection->setParent(this);
connect(socket.data(), &MultiplexChannel::aboutToClose, this, &QObject::deleteLater);
}
QString BluetoothDeviceLink::name()
{
return QStringLiteral("BluetoothLink"); // Should be same in both android and kde version
}
bool BluetoothDeviceLink::sendPacket(NetworkPacket &np)
{
if (np.hasPayload()) {
BluetoothUploadJob *uploadJob = new BluetoothUploadJob(np.payload(), mConnection, this);
np.setPayloadTransferInfo(uploadJob->transferInfo());
uploadJob->start();
}
// TODO: handle too-big packets
int written = mSocketReader->write(np.serialize());
return (written != -1);
}
void BluetoothDeviceLink::userRequestsPair()
{
mPairingHandler->requestPairing();
}
void BluetoothDeviceLink::userRequestsUnpair()
{
mPairingHandler->unpair();
}
bool BluetoothDeviceLink::linkShouldBeKeptAlive()
{
return pairStatus() == Paired;
}
void BluetoothDeviceLink::dataReceived()
{
if (mSocketReader->bytesAvailable() == 0)
return;
const QByteArray serializedPacket = mSocketReader->readLine();
// qCDebug(KDECONNECT_CORE) << "BluetoothDeviceLink dataReceived" << packet;
NetworkPacket packet((QString()));
NetworkPacket::unserialize(serializedPacket, &packet);
if (packet.type() == PACKET_TYPE_PAIR) {
// TODO: Handle pair/unpair requests and forward them (to the pairing handler?)
mPairingHandler->packetReceived(packet);
return;
}
if (packet.hasPayloadTransferInfo()) {
BluetoothDownloadJob *downloadJob = new BluetoothDownloadJob(mConnection, packet.payloadTransferInfo(), this);
downloadJob->start();
packet.setPayload(downloadJob->payload(), packet.payloadSize());
}
Q_EMIT receivedPacket(packet);
if (mSocketReader->bytesAvailable() > 0) {
QMetaObject::invokeMethod(this, &BluetoothDeviceLink::dataReceived, Qt::QueuedConnection);
}
}
QSslCertificate BluetoothDeviceLink::certificate() const
{
return QSslCertificate({}); // TODO Not sure what to do here. For LanDeviceLink we use the SSL connection's certificate, but we don't have that here
}