kdeconnect-kde/core/backends/lan
Erik Duisters 9f5cdf1a21 Do not close m_socket in socketError()
Summary:
When android closes the payload socket (cancel share) calling m_socket.close() results
in a recursive call to onError eventually leading to a segmentation violation

Test Plan:
Install D16491, share a large file from desktop to android and cancel the share on Android through
 the notification. kdeconnectd crashes almost 100% of the time. (It doesn't crash when it detects
 a disconnect in sendNextPacket)

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17628
2019-01-06 12:43:10 +01:00
..
CMakeLists.txt Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
compositeuploadjob.cpp Do not close m_socket in socketError() 2019-01-06 12:43:10 +01:00
compositeuploadjob.h Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
landevicelink.cpp Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
landevicelink.h Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
lanlinkprovider.cpp Fix minor typos 2018-12-11 19:23:06 +02:00
lanlinkprovider.h Fix minor EBN issues and typos 2018-10-07 21:23:20 +03:00
lanpairinghandler.cpp Rename NetworkPackage -> NetworkPacket 2018-03-05 20:03:23 +01:00
lanpairinghandler.h Rename NetworkPackage -> NetworkPacket 2018-03-05 20:03:23 +01:00
server.cpp QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection 2018-11-19 14:13:41 +01:00
server.h QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection 2018-11-19 14:13:41 +01:00
socketlinereader.cpp Rename NetworkPackage -> NetworkPacket 2018-03-05 20:03:23 +01:00
socketlinereader.h Rename NetworkPackage -> NetworkPacket 2018-03-05 20:03:23 +01:00
uploadjob.cpp Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00
uploadjob.h Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown 2018-11-30 08:26:00 +01:00