02d97aabf4
The rationale is explained in https://planet.kde.org/friedrich-kossebau-2023-06-28-include-also-moc-files-of-headers/ In case of KDEConnect, it impressively speeds up compilation. Before it took 390 seconds on a clean build and with this change it took 330 seconds. This is due to the mocs_compilation having to include the header files and thus all their headers. Due to the lots of small plugins we have, this means that the same headers must be compiled plenty of times. When we include the moc files directly in the C++ file, they are already available.
77 lines
2 KiB
C++
77 lines
2 KiB
C++
/**
|
|
* SPDX-FileCopyrightText: 2013 Albert Vaca <albertvaka@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
|
|
*/
|
|
|
|
#include "kdeconnectplugin.h"
|
|
|
|
#include "core_debug.h"
|
|
|
|
struct KdeConnectPluginPrivate {
|
|
Device *m_device;
|
|
QString m_pluginName;
|
|
QSet<QString> m_outgoingCapabilties;
|
|
KdeConnectPluginConfig *m_config = nullptr;
|
|
QString iconName;
|
|
};
|
|
|
|
KdeConnectPlugin::KdeConnectPlugin(QObject *parent, const QVariantList &args)
|
|
: QObject(parent)
|
|
, d(new KdeConnectPluginPrivate)
|
|
{
|
|
Q_ASSERT(args.length() == 4);
|
|
d->m_device = qvariant_cast<Device *>(args.at(0));
|
|
d->m_pluginName = args.at(1).toString();
|
|
|
|
const QStringList cap = args.at(2).toStringList();
|
|
d->m_outgoingCapabilties = QSet(cap.begin(), cap.end());
|
|
d->iconName = args.at(3).toString();
|
|
}
|
|
|
|
KdeConnectPluginConfig *KdeConnectPlugin::config() const
|
|
{
|
|
// Create on demand, because not every plugin will use it
|
|
if (!d->m_config) {
|
|
d->m_config = new KdeConnectPluginConfig(d->m_device->id(), d->m_pluginName);
|
|
}
|
|
return d->m_config;
|
|
}
|
|
|
|
KdeConnectPlugin::~KdeConnectPlugin()
|
|
{
|
|
delete d->m_config;
|
|
}
|
|
|
|
const Device *KdeConnectPlugin::device()
|
|
{
|
|
return d->m_device;
|
|
}
|
|
|
|
Device const *KdeConnectPlugin::device() const
|
|
{
|
|
return d->m_device;
|
|
}
|
|
|
|
bool KdeConnectPlugin::sendPacket(NetworkPacket &np) const
|
|
{
|
|
if (!d->m_outgoingCapabilties.contains(np.type())) {
|
|
qCWarning(KDECONNECT_CORE) << metaObject()->className() << "tried to send an unsupported packet type" << np.type()
|
|
<< ". Supported:" << d->m_outgoingCapabilties;
|
|
return false;
|
|
}
|
|
// qCWarning(KDECONNECT_CORE) << metaObject()->className() << "sends" << np.type() << ". Supported:" << d->mOutgoingTypes;
|
|
return d->m_device->sendPacket(np);
|
|
}
|
|
|
|
QString KdeConnectPlugin::dbusPath() const
|
|
{
|
|
return {};
|
|
}
|
|
|
|
QString KdeConnectPlugin::iconName() const
|
|
{
|
|
return d->iconName;
|
|
}
|
|
|
|
#include "moc_kdeconnectplugin.cpp"
|