kdeconnect-kde/core/filetransferjob.h
Kai Uwe Broulik 77ad9336b6 [FileTransferJob] Fix division by null and use elapsed timer
When sending multiple files from my phone to my PC, kdeconnectd usually received a SIGFPE.
To get the transfer speed it divides the number of bytes received by the elapsed time which can be zero.

Also, since we're only interested in the time that has elapsed, use QElapsedTimer,
which is exactly for this. QTime::elapsed() also needs to take into account potentially
ocurred timezone or DST changes.

REVIEW: 128861
2016-09-10 22:52:03 +02:00

77 lines
2.3 KiB
C++

/*
* Copyright 2013 Albert Vaca <albertvaka@gmail.com>
* Copyright 2015 Aleix Pol i Gonzalez <aleixpol@kde.org>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of
* the License or (at your option) version 3 or any later version
* accepted by the membership of KDE e.V. (or its successor approved
* by the membership of KDE e.V.), which shall act as a proxy
* defined in Section 14 of version 3 of the license.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef FILETRANSFERJOB_H
#define FILETRANSFERJOB_H
#include <KJob>
#include <QElapsedTimer>
#include <QIODevice>
#include <QSharedPointer>
#include <QUrl>
#include <QNetworkReply>
#include "kdeconnectcore_export.h"
/**
* @short It will stream a device into a url destination
*
* Given a QIODevice, the file transfer job will use the system's QNetworkAccessManager
* for putting the stream into the requested location.
*/
class KDECONNECTCORE_EXPORT FileTransferJob
: public KJob
{
Q_OBJECT
public:
/**
* @p origin specifies the data to read from.
* @p size specifies the expected size of the stream we're reading.
* @p destination specifies where these contents should be stored
*/
FileTransferJob(const QSharedPointer<QIODevice>& origin, qint64 size, const QUrl &destination);
void start() override;
QUrl destination() const { return mDestination; }
void setOriginName(QString from) { mFrom = from; }
private Q_SLOTS:
void doStart();
protected:
bool doKill() override;
private:
void startTransfer();
void transferFailed(QNetworkReply::NetworkError error);
void transferFinished();
QSharedPointer<QIODevice> mOrigin;
QNetworkReply* mReply;
QString mFrom;
QUrl mDestination;
QElapsedTimer mTimer;
qulonglong mSpeedBytes;
qint64 mWritten;
};
#endif