kdeconnect-kde/core/filetransferjob.cpp
Kai Uwe Broulik 77ad9336b6 [FileTransferJob] Fix division by null and use elapsed timer
When sending multiple files from my phone to my PC, kdeconnectd usually received a SIGFPE.
To get the transfer speed it divides the number of bytes received by the elapsed time which can be zero.

Also, since we're only interested in the time that has elapsed, use QElapsedTimer,
which is exactly for this. QTime::elapsed() also needs to take into account potentially
ocurred timezone or DST changes.

REVIEW: 128861
2016-09-10 22:52:03 +02:00

132 lines
4.2 KiB
C++

/*
* Copyright 2013 Albert Vaca <albertvaka@gmail.com>
* Copyright 2015 Aleix Pol i Gonzalez <aleixpol@kde.org>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of
* the License or (at your option) version 3 or any later version
* accepted by the membership of KDE e.V. (or its successor approved
* by the membership of KDE e.V.), which shall act as a proxy
* defined in Section 14 of version 3 of the license.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "filetransferjob.h"
#include "daemon.h"
#include <core_debug.h>
#include <qalgorithms.h>
#include <QFileInfo>
#include <QDebug>
#include <KLocalizedString>
FileTransferJob::FileTransferJob(const QSharedPointer<QIODevice>& origin, qint64 size, const QUrl& destination)
: KJob()
, mOrigin(origin)
, mReply(Q_NULLPTR)
, mFrom("KDE Connect")
, mDestination(destination)
, mSpeedBytes(0)
, mWritten(0)
{
Q_ASSERT(mOrigin);
Q_ASSERT(mOrigin->isReadable());
if (mDestination.scheme().isEmpty()) {
qCWarning(KDECONNECT_CORE) << "Destination QUrl" << mDestination << "lacks a scheme. Setting its scheme to 'file'.";
mDestination.setScheme("file");
}
if (size >= 0) {
setTotalAmount(Bytes, size);
}
setCapabilities(Killable);
qCDebug(KDECONNECT_CORE) << "FileTransferJob Downloading payload to" << destination;
}
void FileTransferJob::start()
{
QMetaObject::invokeMethod(this, "doStart", Qt::QueuedConnection);
//qCDebug(KDECONNECT_CORE) << "FileTransferJob start";
}
void FileTransferJob::doStart()
{
description(this, i18n("Receiving file over KDE Connect"),
{ i18nc("File transfer origin", "From"), mFrom }
);
if (mDestination.isLocalFile() && QFile::exists(mDestination.toLocalFile())) {
setError(2);
setErrorText(i18n("Filename already present"));
emitResult();
return;
}
if (mOrigin->bytesAvailable())
startTransfer();
connect(mOrigin.data(), &QIODevice::readyRead, this, &FileTransferJob::startTransfer);
}
void FileTransferJob::startTransfer()
{
setProcessedAmount(Bytes, 0);
mTimer.start();
description(this, i18n("Receiving file over KDE Connect"),
{ i18nc("File transfer origin", "From"), mFrom },
{ i18nc("File transfer destination", "To"), mDestination.toLocalFile() });
QNetworkRequest req(mDestination);
req.setHeader(QNetworkRequest::ContentLengthHeader, totalAmount(Bytes));
mReply = Daemon::instance()->networkAccessManager()->put(req, mOrigin.data());
connect(mReply, &QNetworkReply::uploadProgress, this, [this](qint64 bytesSent, qint64 /*bytesTotal*/) {
setProcessedAmount(Bytes, bytesSent);
const auto elapsed = mTimer.elapsed();
if (elapsed > 0) {
emitSpeed(bytesSent / elapsed);
}
});
connect(mReply, static_cast<void (QNetworkReply::*)(QNetworkReply::NetworkError)>(&QNetworkReply::error),
this, &FileTransferJob::transferFailed);
connect(mReply, &QNetworkReply::finished, this, &FileTransferJob::transferFinished);
}
void FileTransferJob::transferFailed(QNetworkReply::NetworkError error)
{
qCDebug(KDECONNECT_CORE) << "Couldn't transfer the file successfully" << error << mReply->errorString();
setError(error);
setErrorText(i18n("Received incomplete file: %1", mReply->errorString()));
emitResult();
mReply->close();
}
void FileTransferJob::transferFinished()
{
//TODO: MD5-check the file
qCDebug(KDECONNECT_CORE) << "Finished transfer" << mDestination;
emitResult();
}
bool FileTransferJob::doKill()
{
if (mReply) {
mReply->close();
}
if (mOrigin) {
mOrigin->close();
}
return true;
}