kdeconnect-kde

History

Friedrich W. H. Kossebau 72fc67ee05 MPRIS control: do not accumulate interface objects Summary: If MPRIS players were appearing and disappearing multiple times, the OrgFreedesktopDBusPropertiesInterface & OrgMprisMediaPlayer2PlayerInterface instances created for listening to the signals had been accumulating and thus resulting in X signals per X restarted player, because the instances were not deleted when a player disappeared. Additionally were instances of them created on the fly on the stack in some of the methods, instead of reusing the existing ones. This patch changes that by introducing a class MprisPlayer which holds all data & instances per player. This allows to look up the respective interfaces instances to reuse them as well as properly controlling their lifetime. Test Plan: Starting and restarting multiple MPRIS players (incl. multiple instances of the same player app) works as expected as befire. They are listed on the Android Media control as well as have proper states there when selected. Additionally no longer multiple change signals are emitted if restarting a player. Reviewers: #kde_connect, mtijink Reviewed By: #kde_connect, mtijink Subscribers: mtijink Differential Revision: https://phabricator.kde.org/D11389		2018-03-16 23:53:40 +01:00
..
battery	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
clipboard	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
findmyphone	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
lockdevice	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
mousepad	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
mousepad_windows	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
mpriscontrol	MPRIS control: do not accumulate interface objects	2018-03-16 23:53:40 +01:00
mprisremote	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
notifications	Make sure we don't request multiple times the notification icon	2018-03-16 00:06:47 +01:00
pausemusic	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
ping	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
remotecommands	SVN_SILENT made messages (.desktop file) - always resolve ours	2018-03-13 05:16:27 +01:00
remotecontrol	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
remotekeyboard	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
runcommand	SVN_SILENT made messages (.desktop file) - always resolve ours	2018-03-13 05:16:27 +01:00
screensaver-inhibit	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
sendnotifications	SVN_SILENT made messages (.desktop file) - always resolve ours	2018-03-13 05:16:27 +01:00
sftp	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
share	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
telephony	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00
CMakeLists.txt	Remote command host can only be used from the qml app	2017-08-02 02:05:01 +02:00
kdeconnect.notifyrc	SVN_SILENT made messages (.desktop file) - always resolve ours	2018-01-29 05:02:00 +01:00
kdeconnect_plugin.desktop	SVN_SILENT made messages (.desktop file) - always resolve ours	2017-09-19 04:58:52 +02:00
Messages.sh	Figure out Messages.sh after code refactoring	2014-06-17 18:45:47 +02:00
README.txt	Rename NetworkPackage -> NetworkPacket	2018-03-05 20:03:23 +01:00

README.txt

Writting a plugin for KDE Connect
=================================

For the desktop client (this project):
--------------------------------------

1. Enter the "plugins" directory.
2. Copy the "ping" under a different name ("findmyphone" in this example).
3. Add "add_subdirectory(findmyphone)" to CMakeLists.txt after the others "add_subdirectory".
1. Enter the new "findmyphone" directory.
5. Edit CMakeLists.txt by replacing "ping" with "findmyphone".
6. Rename other files in this directory by replacing "ping" with "findmyphone"
7. Write a description of your plugin into "README"
8. Edit findmyphoneplugin.cpp and findmyphoneplugin.h.
  A. Change license header.
  B. Replace (case sensitive) "ping" with "findmyphone", "PingPlugin" with "FindMyPhonePlugin" and "PING" with "FINDMYPHONE".
9. Edit kdeconnect_findmyphone.desktop file:
  A. Replace "ping" with "findmyphone".
  B. Change name, description, icon, author, email, version, website, license info.
  C. Remove all the translations
  D. Set X-KDEConnect-SupportedPacketType and X-KDEConnect-OutgoingPacketType to the packet type your plugin will receive
     and send, respectively. In this example this is "kdeconnect.findmyphone". Make sure that this matches what is defined in
     the findmyplugin.h file (in the line "#define PACKET_TYPE_..."), and also in Android.
10. Now you have an empty skeleton to implement your new plugin logic.

For Android (project kdeconnect-android):
-----------------------------------------

1. Change directory to src/org/kde/kdeconnect/Plugins.
2. Copy "PingPlugin" under a different name ("FindMyPhonePlugin" in this example).
1. Enter the new "FindMyPhonePlugin" directory.
4. Rename "PingPlugin.java" to "FindMyPhonePlugin.java"
5. Edit it. Replace (case sensitive) "Ping" with "FindMyPhone", "ping" with "findmyphone", "PING" with "FINDMYPHONE"
   and "plugin_ping" with "plugin_findmyphone".
6. Open res/values/strings.xml. Find and copy the lines "pref_plugin_ping_desc" and "pref_plugin_ping" replacing "ping"
   with "findmyphone" and edit the plugin name and description between <string> </string>).
7. Open src/org/kde/kdeconnect/Plugins/PluginFactory.java.
  A. Copy "import … PingPlugin" line with replacing "PingPlugin" with "FindMyPhonePlugin".
  B. Copy "PluginFactory.registerPlugin(PingPlugin.class);" line with replacing "PingPlugin" with "FindMyPhonePlugin".
8. Open src/org/kde/kdeconnect/NetworkPacket.java. Copy a "public final static String PACKET_TYPE_PING = …" line
   replacing "PING" with the packet type you will be using (should match the desktop client).
9. Now you have an empty skeleton to implement your new plugin logic.