kdeconnect-kde/plugins/sms/kdeconnect_sms.json
Simon Redman 64062b3cc9 [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin
Summary:
Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway

Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_*

Update TELEPHONY plugin packet description to point to SMS plugin

Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field

Please see Android-side patch here: D15544

Test Plan:
I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision:
 - New Android vs. New Desktop
   - Supported and works for me
 - New Android vs. Old Desktop
   - Supported and works for me
 - Old Android vs. New Desktop
   - Not supported - Download a new app from the Play store or F-Droid
 - Old Android vs. Old Desktop
   - If this is broken, it is not my fault :)

In the supported use cases:
 - Test SMS reply
   - Receive SMS (or MMS!) message
   - Verify that the //notification// plugin forwards a replyable notification and that replying works
 - Test incoming call ringer mute
   - Enable ringer volume (not vibrate)
   - Receive phone call
   - Verify a desktop notification with a Mute button appears
   - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected)

Reviewers: #kde_connect, albertvaka, nicolasfella

Reviewed By: #kde_connect, albertvaka, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15543
2018-09-16 16:06:53 -06:00

39 lines
1.3 KiB
JSON
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

{
"KPlugin": {
"Authors": [
{
"Email": "simon@ergotech.com",
"Name": "Simon Redman",
"Name[x-test]": "xxSimon Redmanxx"
}
],
"Description": "Send and receive SMS",
"Description[ca@valencia]": "Envia i rep SMS",
"Description[ca]": "Envia i rep SMS",
"Description[cs]": "Posílat a přijímat SMS",
"Description[nl]": "SMS verzenden en ontvangen",
"Description[pt]": "Enviar e receber SMS's",
"Description[pt_BR]": "Envia e recebe SMS",
"Description[uk]": "Надсилання і отримання SMS",
"Description[x-test]": "xxSend and receive SMSxx",
"EnabledByDefault": true,
"Icon": "mail-message-new-list",
"Id": "kdeconnect_sms",
"License": "GPL",
"Name": "SMS",
"Name[x-test]": "xxSMSxx",
"ServiceTypes": [
"KdeConnect/Plugin"
],
"Version": "0.1",
"Website": "https://nicolasfella.wordpress.com"
},
"X-KdeConnect-OutgoingPacketType": [
"kdeconnect.sms.request",
"kdeconnect.sms.request_conversations",
"kdeconnect.sms.request_conversation"
],
"X-KdeConnect-SupportedPacketType": [
"kdeconnect.sms.messages"
]
}