kdeconnect-kde/plugins/runcommand
Jean Vincent c864267f04 Replace Q_FOREACH with C++11 range-for
Summary:
The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.

I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).

I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.

(This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)

Reviewers: #kde_connect, nicolasfella, apol

Reviewed By: #kde_connect, nicolasfella, apol

Subscribers: albertvaka, apol, nicolasfella

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6724
2017-07-21 09:57:19 +02:00
..
CMakeLists.txt First implementation of runcommand plugin 2015-09-12 03:38:44 -07:00
kdeconnect_runcommand.json SVN_SILENT made messages (.desktop file) - always resolve ours 2017-07-19 08:33:01 +02:00
kdeconnect_runcommand_config.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2017-06-04 04:17:49 +02:00
runcommand_config.cpp Replace Q_FOREACH with C++11 range-for 2017-07-21 09:57:19 +02:00
runcommand_config.h Clean up use of virtual and override keywords 2016-06-20 19:22:29 +02:00
runcommandplugin.cpp Clazy says all this QStringLiteral and QLatin1String were missing/wrong 2016-11-26 16:21:29 +01:00
runcommandplugin.h Reduce API exposed through dbus 2017-01-10 18:15:01 +01:00