tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kdeconnect-kde/plugins/sendnotifications
History
Jean Vincent c864267f04 Replace Q_FOREACH with C++11 range-for 
Summary:
The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.

I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).

I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.

(This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)

Reviewers: #kde_connect, nicolasfella, apol

Reviewed By: #kde_connect, nicolasfella, apol

Subscribers: albertvaka, apol, nicolasfella

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6724
2017-07-21 09:57:19 +02:00
..
CMakeLists.txt Fix build after merge 2016-05-31 17:48:55 +02:00
kdeconnect_sendnotifications.json SVN_SILENT made messages (.desktop file) - always resolve ours 2017-06-08 04:52:02 +02:00
kdeconnect_sendnotifications_config.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2017-06-04 04:17:49 +02:00
notificationslistener.cpp Replace Q_FOREACH with C++11 range-for 2017-07-21 09:57:19 +02:00
notificationslistener.h sendnotifications: also sync icon-data from notfication hints 2016-08-27 13:59:25 +02:00
notifyingapplication.cpp Split plugins for sending and receiving notifications 2016-05-25 12:49:13 -06:00
notifyingapplication.h More unused includes cleanup 2016-07-05 14:27:53 +02:00
notifyingapplicationmodel.cpp Clazy says all this QStringLiteral and QLatin1String were missing/wrong 2016-11-26 16:21:29 +01:00
notifyingapplicationmodel.h Clean up use of virtual and override keywords 2016-06-20 19:22:29 +02:00
sendnotification_debug.h Split plugins for sending and receiving notifications 2016-05-25 12:49:13 -06:00
sendnotifications_config.cpp Known size, reserve. 2016-11-26 16:36:34 +01:00
sendnotifications_config.h Clean up use of virtual and override keywords 2016-06-20 19:22:29 +02:00
sendnotifications_config.ui Split plugins for sending and receiving notifications 2016-05-25 12:49:13 -06:00
sendnotificationsplugin.cpp Split plugins for sending and receiving notifications 2016-05-25 12:49:13 -06:00
sendnotificationsplugin.h Reduce API exposed through dbus 2017-01-10 18:15:01 +01:00