64062b3cc9
Summary: Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_* Update TELEPHONY plugin packet description to point to SMS plugin Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field Please see Android-side patch here: D15544 Test Plan: I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision: - New Android vs. New Desktop - Supported and works for me - New Android vs. Old Desktop - Supported and works for me - Old Android vs. New Desktop - Not supported - Download a new app from the Play store or F-Droid - Old Android vs. Old Desktop - If this is broken, it is not my fault :) In the supported use cases: - Test SMS reply - Receive SMS (or MMS!) message - Verify that the //notification// plugin forwards a replyable notification and that replying works - Test incoming call ringer mute - Enable ringer volume (not vibrate) - Receive phone call - Verify a desktop notification with a Mute button appears - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected) Reviewers: #kde_connect, albertvaka, nicolasfella Reviewed By: #kde_connect, albertvaka, nicolasfella Subscribers: nicolasfella, kdeconnect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D15543
79 lines
2.4 KiB
C++
79 lines
2.4 KiB
C++
/**
|
|
* Copyright 2013 Albert Vaca <albertvaka@gmail.com>
|
|
* Copyright 2018 Simon Redman <simon@ergotech.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef TELEPHONYPLUGIN_H
|
|
#define TELEPHONYPLUGIN_H
|
|
|
|
#include <QLoggingCategory>
|
|
#include <QDBusInterface>
|
|
|
|
#include <KNotification>
|
|
|
|
#include <core/kdeconnectplugin.h>
|
|
|
|
/**
|
|
* Packet used for simple telephony events
|
|
*
|
|
* It contains the key "event" which maps to a string indicating the type of event:
|
|
* - "ringing" - A phone call is incoming
|
|
* - "missedCall" - An incoming call was not answered
|
|
*
|
|
* Historically, "sms" was a valid event, but support for that has been dropped in favour
|
|
* of the SMS plugin's more expressive interfaces
|
|
*
|
|
* Depending on the event, other fields may be defined
|
|
*/
|
|
#define PACKET_TYPE_TELEPHONY QStringLiteral("kdeconnect.telephony")
|
|
|
|
#define PACKET_TYPE_TELEPHONY_REQUEST_MUTE QStringLiteral("kdeconnect.telephony.request_mute")
|
|
|
|
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_TELEPHONY)
|
|
|
|
class TelephonyPlugin
|
|
: public KdeConnectPlugin
|
|
{
|
|
Q_OBJECT
|
|
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.telephony")
|
|
|
|
public:
|
|
explicit TelephonyPlugin(QObject* parent, const QVariantList& args);
|
|
~TelephonyPlugin() override;
|
|
|
|
bool receivePacket(const NetworkPacket& np) override;
|
|
void connected() override {}
|
|
QString dbusPath() const override;
|
|
|
|
public:
|
|
Q_SIGNALS:
|
|
|
|
private Q_SLOTS:
|
|
void sendMutePacket();
|
|
|
|
private:
|
|
/**
|
|
* Create a notification for:
|
|
* - Incoming call (with the option to mute the ringing)
|
|
* - Missed call
|
|
*/
|
|
KNotification* createNotification(const NetworkPacket& np);
|
|
};
|
|
|
|
#endif
|