31e93ef7bf
Summary: For real usecases of SMS support, we will almost always need access to the message history in some way Specifically resolve T8338 Incidentally resolve T6651 since Telephony shall no longer create a notification Test Plan: Setup: - Build corresponding Android-side diff (D11698) - Build this diff Step 1: Does anything at all work? - Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object - Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations() - Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation Step 2: DBus - Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId> - Poke activeConversations and verify an empty array is returned - Poke requestAllConversationThreads - Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds - Use a conversationId to call getFirstFromConversation - Verify that the returned Message object is one which you recognize - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!" Step 3: SMS App - Use ccmake (or similar) to set SMSAPP_ENABLE to ON - Build the project - Run ./bin/kdeconnect-sms - Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out) - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number Reviewers: #kde_connect, nicolasfella, apol Reviewed By: #kde_connect, nicolasfella, apol Subscribers: andyholmes, apol, nicolasfella, #kde_connect Tags: #kde_connect Maniphest Tasks: T8338, T6651 Differential Revision: https://phabricator.kde.org/D11854
118 lines
3.4 KiB
C++
118 lines
3.4 KiB
C++
/*
|
|
* This file is part of KDE Telepathy Chat
|
|
*
|
|
* Copyright (C) 2018 Aleix Pol Gonzalez <aleixpol@kde.org>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef CONVERSATIONLISTMODEL_H
|
|
#define CONVERSATIONLISTMODEL_H
|
|
|
|
#include <QStandardItemModel>
|
|
#include <QLoggingCategory>
|
|
#include <QQmlParserStatus>
|
|
#include <KPeople/kpeople/personsmodel.h>
|
|
#include <KPeople/kpeople/persondata.h>
|
|
|
|
#include "interfaces/conversationmessage.h"
|
|
#include "interfaces/dbusinterfaces.h"
|
|
|
|
#include "interfaces/kdeconnectinterfaces_export.h"
|
|
|
|
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_SMS_CONVERSATIONS_LIST_MODEL)
|
|
|
|
|
|
class OurSortFilterProxyModel : public QSortFilterProxyModel, public QQmlParserStatus
|
|
{
|
|
Q_OBJECT
|
|
Q_INTERFACES(QQmlParserStatus)
|
|
Q_PROPERTY(Qt::SortOrder sortOrder READ sortOrder WRITE setSortOrder)
|
|
public:
|
|
|
|
Qt::SortOrder sortOrder() const { return m_sortOrder; }
|
|
void setSortOrder(Qt::SortOrder sortOrder) {
|
|
if (m_sortOrder != sortOrder) {
|
|
m_sortOrder = sortOrder;
|
|
sortNow();
|
|
}
|
|
}
|
|
void classBegin() override {}
|
|
void componentComplete() override {
|
|
m_completed = true;
|
|
sortNow();
|
|
}
|
|
|
|
private:
|
|
void sortNow() {
|
|
if (m_completed && dynamicSortFilter())
|
|
sort(0, m_sortOrder);
|
|
}
|
|
|
|
bool m_completed = false;
|
|
Qt::SortOrder m_sortOrder = Qt::AscendingOrder;
|
|
};
|
|
|
|
class KDECONNECTINTERFACES_EXPORT ConversationListModel
|
|
: public QStandardItemModel
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(QString deviceId READ deviceId WRITE setDeviceId)
|
|
|
|
public:
|
|
ConversationListModel(QObject* parent = nullptr);
|
|
~ConversationListModel();
|
|
|
|
enum Roles {
|
|
FromMeRole = Qt::UserRole,
|
|
PersonUriRole,
|
|
AddressRole,
|
|
ConversationIdRole,
|
|
DateRole,
|
|
};
|
|
Q_ENUM(Roles)
|
|
|
|
QString deviceId() const { return m_deviceId; }
|
|
void setDeviceId(const QString &/*deviceId*/);
|
|
|
|
public Q_SLOTS:
|
|
void handleCreatedConversation(const QString& conversationId);
|
|
void createRowFromMessage(const QVariantMap& message, int row);
|
|
void printDBusError(const QDBusError& error);
|
|
|
|
private:
|
|
/**
|
|
* Get all conversations currently known by the conversationsInterface, if any
|
|
*/
|
|
void prepareConversationsList();
|
|
|
|
/**
|
|
* Get the data for a particular person given their contact address
|
|
*/
|
|
KPeople::PersonData* lookupPersonByAddress(const QString& address);
|
|
|
|
/**
|
|
* Simplify a phone number to a known form
|
|
*/
|
|
QString canonicalizePhoneNumber(const QString& phoneNumber);
|
|
|
|
QStandardItem* conversationForThreadId(qint32 threadId);
|
|
|
|
DeviceConversationsDbusInterface* m_conversationsInterface;
|
|
QString m_deviceId;
|
|
KPeople::PersonsModel m_people;
|
|
};
|
|
|
|
#endif // CONVERSATIONLISTMODEL_H
|