kdeconnect-kde/smsapp
Simon Redman 5b213e6144 [SMS App] Improve filter
Summary:
- Allow filter box to handle keystrokes passed to the ListView
 - This is a little cheesy, but fixes T8341

- Pin filter box to always be visible

- Clear filter on Esc

Test Plan:
- Try typing a contact you would like to search for
 - Before: Every time you type a new letter, the filter box would lose focus and you would have to click it to give it focus again
 - Now: You can type smoothly

- Try scrolling the list
 - Before: The filter box disappeared off the top of the screen
 - Now: The filter box is always visible

- Try pressing escape
 - Before: Nothing
 - Now: Filter clears

- Bonus: When using the arrow keys to navigate, before the filter was manually handling those and the view would not loop. Now, the view loops if you try to select an item past the beginning or end (Easiest to see with highlighting from D17612)

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Maniphest Tasks: T8341

Differential Revision: https://phabricator.kde.org/D17614
2018-12-17 09:25:56 -07:00
..
qml [SMS App] Improve filter 2018-12-17 09:25:56 -07:00
CMakeLists.txt (WIP) Upgrade Telephony plugin to read SMS history (KDE side) 2018-06-09 13:35:26 -06:00
conversationlistmodel.cpp Fix license header for smsapp 2018-10-11 22:52:42 +02:00
conversationlistmodel.h Fix license header for smsapp 2018-10-11 22:52:42 +02:00
conversationmodel.cpp [SMS App] Make requestMoreMessages asynchronous, blocking, and caching 2018-12-12 22:42:56 -07:00
conversationmodel.h Un-break build. Apparently I didn't test as I thought I had. 2018-12-12 22:49:33 -07:00
main.cpp Fix license header for smsapp 2018-10-11 22:52:42 +02:00
org.kde.kdeconnect.sms.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2018-12-02 05:23:51 +01:00
resources.qrc Refine SMS conversation view 2018-08-06 00:09:46 +02:00