39fe270cd1
It's more expressive in the sense that it makes clear that the user should not delete the object
454 lines
16 KiB
C++
454 lines
16 KiB
C++
/**
|
|
* Copyright 2015 Vineet Garg <grgvineet@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License or (at your option) version 3 or any later version
|
|
* accepted by the membership of KDE e.V. (or its successor approved
|
|
* by the membership of KDE e.V.), which shall act as a proxy
|
|
* defined in Section 14 of version 3 of the license.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
// This class tests the behaviour of the class LanLinkProvider, be sure to kill process kdeconnectd to avoid any port binding issues
|
|
|
|
|
|
#include "../core/backends/lan/lanlinkprovider.h"
|
|
#include "../core/backends/lan/server.h"
|
|
#include "../core/backends/lan/socketlinereader.h"
|
|
#include "../core/kdeconnectconfig.h"
|
|
|
|
#include <QAbstractSocket>
|
|
#include <QSslSocket>
|
|
#include <QtTest>
|
|
#include <QSslKey>
|
|
#include <QUdpSocket>
|
|
#include <QtCrypto>
|
|
#include <QMetaEnum>
|
|
|
|
/*
|
|
* This class tests the working of LanLinkProvider under different conditions that when identity packet is received over TCP, over UDP and same when the device is paired.
|
|
* It depends on KdeConnectConfig since LanLinkProvider internally uses it.
|
|
*/
|
|
class LanLinkProviderTest : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit LanLinkProviderTest()
|
|
: m_lanLinkProvider(true)
|
|
, m_server(nullptr)
|
|
, m_reader(nullptr)
|
|
, m_udpSocket(nullptr)
|
|
{
|
|
QStandardPaths::setTestModeEnabled(true);
|
|
}
|
|
|
|
public Q_SLOTS:
|
|
void initTestCase();
|
|
void init();
|
|
void cleanup();
|
|
|
|
private Q_SLOTS:
|
|
/**
|
|
* Test that the LanLinkProvider will send an identity packet to a non-default port
|
|
*/
|
|
void testChangedUDPBroadcastPort();
|
|
/**
|
|
* Test that the LanLinkProvider will receive an identity packet on a non-default port
|
|
*/
|
|
void testChangedUDPListenPort();
|
|
|
|
void pairedDeviceTcpPacketReceived();
|
|
void pairedDeviceUdpPacketReceived();
|
|
|
|
void unpairedDeviceTcpPacketReceived();
|
|
void unpairedDeviceUdpPacketReceived();
|
|
|
|
|
|
private:
|
|
const int TEST_PORT = 8520;
|
|
// Add some private fields here
|
|
LanLinkProvider m_lanLinkProvider;
|
|
Server* m_server;
|
|
SocketLineReader* m_reader;
|
|
QUdpSocket* m_udpSocket;
|
|
QString m_identityPacket;
|
|
|
|
// Attributes for test device
|
|
QString m_deviceId;
|
|
QString m_name;
|
|
QCA::PrivateKey m_privateKey;
|
|
QSslCertificate m_certificate;
|
|
|
|
QSslCertificate generateCertificate(QString&, QCA::PrivateKey&);
|
|
void addTrustedDevice();
|
|
void removeTrustedDevice();
|
|
void setSocketAttributes(QSslSocket* socket);
|
|
void testIdentityPacket(QByteArray& identityPacket);
|
|
void socketBindErrorFail(const QUdpSocket& socket);
|
|
};
|
|
|
|
void LanLinkProviderTest::initTestCase()
|
|
{
|
|
removeTrustedDevice(); // Remove trusted device if left by chance by any test
|
|
|
|
m_deviceId = QStringLiteral("testdevice");
|
|
m_name = QStringLiteral("Test Device");
|
|
m_privateKey = QCA::KeyGenerator().createRSA(2048);
|
|
m_certificate = generateCertificate(m_deviceId, m_privateKey);
|
|
|
|
m_identityPacket = QStringLiteral("{\"id\":1439365924847,\"type\":\"kdeconnect.identity\",\"body\":{\"deviceId\":\"testdevice\",\"deviceName\":\"Test Device\",\"protocolVersion\":6,\"deviceType\":\"phone\",\"tcpPort\":") + QString::number(TEST_PORT) + QStringLiteral("}}");
|
|
}
|
|
|
|
void LanLinkProviderTest::init()
|
|
{
|
|
m_lanLinkProvider.onStart();
|
|
}
|
|
|
|
void LanLinkProviderTest::cleanup()
|
|
{
|
|
m_lanLinkProvider.onStop();
|
|
}
|
|
|
|
void LanLinkProviderTest::testChangedUDPBroadcastPort()
|
|
{
|
|
quint16 udpListenPort = LanLinkProvider::UDP_PORT;
|
|
quint16 udpBroadcastPort = LanLinkProvider::UDP_PORT + 1;
|
|
|
|
m_lanLinkProvider.onStop();
|
|
LanLinkProvider testlanLinkProvider(true, udpBroadcastPort, udpListenPort);
|
|
testlanLinkProvider.onStart();
|
|
|
|
QUdpSocket mUdpServer;
|
|
bool bindSuccessful = mUdpServer.bind(QHostAddress::LocalHost, udpBroadcastPort, QUdpSocket::ShareAddress | QUdpSocket::ReuseAddressHint);
|
|
if (!bindSuccessful) {
|
|
socketBindErrorFail(mUdpServer);
|
|
}
|
|
|
|
QSignalSpy spy(&mUdpServer, SIGNAL(readyRead()));
|
|
testlanLinkProvider.onNetworkChange();
|
|
QVERIFY2(!spy.isEmpty() || spy.wait(), "Did not receive UDP packet");
|
|
}
|
|
|
|
void LanLinkProviderTest::testChangedUDPListenPort()
|
|
{
|
|
quint16 udpListenPort = LanLinkProvider::UDP_PORT + 1;
|
|
quint16 udpBroadcastPort = LanLinkProvider::UDP_PORT;
|
|
|
|
m_lanLinkProvider.onStop();
|
|
LanLinkProvider testlanLinkProvider(true, udpBroadcastPort, udpListenPort);
|
|
testlanLinkProvider.onStart();
|
|
|
|
m_server = new Server(this);
|
|
QUdpSocket testUdpSocket;
|
|
|
|
m_server->listen(QHostAddress::LocalHost, TEST_PORT);
|
|
|
|
QSignalSpy spy(m_server, SIGNAL(newConnection()));
|
|
|
|
// Write an identity packet to udp socket here. We do not broadcast it here.
|
|
qint64 bytesWritten = testUdpSocket.writeDatagram(m_identityPacket.toLatin1(), QHostAddress::LocalHost, udpListenPort);
|
|
QCOMPARE(bytesWritten, m_identityPacket.size());
|
|
|
|
// In response to receiving an identity packet, the LanLinkProvider should try to open a TCP connection to us
|
|
QVERIFY(!spy.isEmpty() || spy.wait());
|
|
|
|
QSslSocket* serverSocket = m_server->nextPendingConnection();
|
|
|
|
QVERIFY2(serverSocket != 0, "Server socket is null");
|
|
QVERIFY2(serverSocket->isOpen(), "Server socket already closed");
|
|
|
|
delete m_server;
|
|
}
|
|
|
|
void LanLinkProviderTest::pairedDeviceTcpPacketReceived()
|
|
{
|
|
quint16 udpListenPort = LanLinkProvider::UDP_PORT;
|
|
quint16 udpBroadcastPort = LanLinkProvider::UDP_PORT + 1;
|
|
|
|
m_lanLinkProvider.onStop();
|
|
LanLinkProvider testlanLinkProvider(true, udpBroadcastPort, udpListenPort);
|
|
testlanLinkProvider.onStart();
|
|
|
|
addTrustedDevice();
|
|
|
|
QUdpSocket* mUdpServer = new QUdpSocket;
|
|
bool bindSuccessful = mUdpServer->bind(QHostAddress::LocalHost, udpBroadcastPort, QUdpSocket::ShareAddress);
|
|
if (!bindSuccessful) {
|
|
socketBindErrorFail(*mUdpServer);
|
|
}
|
|
|
|
QSignalSpy spy(mUdpServer, SIGNAL(readyRead()));
|
|
testlanLinkProvider.onNetworkChange();
|
|
QVERIFY(!spy.isEmpty() || spy.wait());
|
|
|
|
QByteArray datagram;
|
|
datagram.resize(mUdpServer->pendingDatagramSize());
|
|
QHostAddress sender;
|
|
|
|
mUdpServer->readDatagram(datagram.data(), datagram.size(), &sender);
|
|
|
|
testIdentityPacket(datagram);
|
|
|
|
QJsonDocument jsonDocument = QJsonDocument::fromJson(datagram);
|
|
QJsonObject body = jsonDocument.object().value(QStringLiteral("body")).toObject();
|
|
int tcpPort = body.value(QStringLiteral("tcpPort")).toInt();
|
|
|
|
QSslSocket socket;
|
|
QSignalSpy spy2(&socket, SIGNAL(connected()));
|
|
|
|
socket.connectToHost(sender, tcpPort);
|
|
QVERIFY(spy2.wait());
|
|
|
|
QVERIFY2(socket.isOpen(), "Socket disconnected immediately");
|
|
|
|
socket.write(m_identityPacket.toLatin1());
|
|
socket.waitForBytesWritten(2000);
|
|
|
|
QSignalSpy spy3(&socket, SIGNAL(encrypted()));
|
|
|
|
setSocketAttributes(&socket);
|
|
socket.addCaCertificate(KdeConnectConfig::instance().certificate());
|
|
socket.setPeerVerifyMode(QSslSocket::VerifyPeer);
|
|
socket.setPeerVerifyName(KdeConnectConfig::instance().name());
|
|
|
|
socket.startServerEncryption();
|
|
QVERIFY(spy3.wait());
|
|
|
|
QCOMPARE(socket.sslErrors().size(), 0);
|
|
QVERIFY2(socket.isValid(), "Server socket disconnected");
|
|
QVERIFY2(socket.isEncrypted(), "Server socket not yet encrypted");
|
|
QVERIFY2(!socket.peerCertificate().isNull(), "Peer certificate is null");
|
|
|
|
removeTrustedDevice();
|
|
delete mUdpServer;
|
|
}
|
|
|
|
void LanLinkProviderTest::pairedDeviceUdpPacketReceived()
|
|
{
|
|
addTrustedDevice();
|
|
|
|
m_server = new Server(this);
|
|
m_udpSocket = new QUdpSocket(this);
|
|
|
|
m_server->listen(QHostAddress::LocalHost, TEST_PORT);
|
|
|
|
QSignalSpy spy(m_server, SIGNAL(newConnection()));
|
|
|
|
qint64 bytesWritten = m_udpSocket->writeDatagram(m_identityPacket.toLatin1(), QHostAddress::LocalHost, LanLinkProvider::UDP_PORT); // write an identity packet to udp socket here, we do not broadcast it here
|
|
QCOMPARE(bytesWritten, m_identityPacket.size());
|
|
|
|
// We should have an incoming connection now, wait for incoming connection
|
|
QVERIFY(!spy.isEmpty() || spy.wait());
|
|
|
|
QSslSocket* serverSocket = m_server->nextPendingConnection();
|
|
|
|
QVERIFY2(serverSocket != 0, "Server socket is null");
|
|
QVERIFY2(serverSocket->isOpen(), "Server socket already closed");
|
|
|
|
m_reader = new SocketLineReader(serverSocket, this);
|
|
QSignalSpy spy2(m_reader, SIGNAL(readyRead()));
|
|
QVERIFY(spy2.wait());
|
|
|
|
QByteArray receivedPacket = m_reader->readLine();
|
|
testIdentityPacket(receivedPacket);
|
|
// Received identity packet from LanLinkProvider now start ssl
|
|
|
|
QSignalSpy spy3(serverSocket, SIGNAL(encrypted()));
|
|
QVERIFY(connect(serverSocket, static_cast<void(QAbstractSocket::*)(QAbstractSocket::SocketError)>(&QSslSocket::error),
|
|
this, [](QAbstractSocket::SocketError error){ qDebug() << "error:" << error; }));
|
|
|
|
setSocketAttributes(serverSocket);
|
|
serverSocket->addCaCertificate(KdeConnectConfig::instance().certificate());
|
|
serverSocket->setPeerVerifyMode(QSslSocket::VerifyPeer);
|
|
serverSocket->setPeerVerifyName(KdeConnectConfig::instance().deviceId());
|
|
|
|
serverSocket->startClientEncryption(); // Its TCP server. but SSL client
|
|
QVERIFY(!serverSocket->isEncrypted());
|
|
spy3.wait(2000);
|
|
qDebug() << "xxxxxxxxx" << serverSocket->sslErrors();
|
|
|
|
QCOMPARE(serverSocket->sslErrors().size(), 0);
|
|
QVERIFY2(serverSocket->isValid(), "Server socket disconnected");
|
|
QVERIFY2(serverSocket->isEncrypted(), "Server socket not yet encrypted");
|
|
QVERIFY2(!serverSocket->peerCertificate().isNull(), "Peer certificate is null");
|
|
|
|
removeTrustedDevice();
|
|
|
|
delete m_server;
|
|
delete m_udpSocket;
|
|
}
|
|
|
|
void LanLinkProviderTest::unpairedDeviceTcpPacketReceived()
|
|
{
|
|
quint16 udpListenPort = LanLinkProvider::UDP_PORT;
|
|
quint16 udpBroadcastPort = LanLinkProvider::UDP_PORT + 1;
|
|
|
|
m_lanLinkProvider.onStop();
|
|
LanLinkProvider testlanLinkProvider(true, udpBroadcastPort, udpListenPort);
|
|
testlanLinkProvider.onStart();
|
|
|
|
QUdpSocket* mUdpServer = new QUdpSocket;
|
|
bool bindSuccessful = mUdpServer->bind(QHostAddress::LocalHost, udpBroadcastPort, QUdpSocket::ShareAddress);
|
|
if (!bindSuccessful) {
|
|
socketBindErrorFail(*mUdpServer);
|
|
}
|
|
|
|
QSignalSpy spy(mUdpServer, SIGNAL(readyRead()));
|
|
testlanLinkProvider.onNetworkChange();
|
|
QVERIFY(!spy.isEmpty() || spy.wait());
|
|
|
|
QByteArray datagram;
|
|
datagram.resize(mUdpServer->pendingDatagramSize());
|
|
QHostAddress sender;
|
|
|
|
mUdpServer->readDatagram(datagram.data(), datagram.size(), &sender);
|
|
|
|
testIdentityPacket(datagram);
|
|
|
|
QJsonDocument jsonDocument = QJsonDocument::fromJson(datagram);
|
|
QJsonObject body = jsonDocument.object().value(QStringLiteral("body")).toObject();
|
|
int tcpPort = body.value(QStringLiteral("tcpPort")).toInt();
|
|
|
|
QSslSocket socket;
|
|
QSignalSpy spy2(&socket, SIGNAL(connected()));
|
|
|
|
socket.connectToHost(sender, tcpPort);
|
|
QVERIFY(spy2.wait());
|
|
|
|
QVERIFY2(socket.isOpen(), "Socket disconnected immediately");
|
|
|
|
socket.write(m_identityPacket.toLatin1());
|
|
socket.waitForBytesWritten(2000);
|
|
|
|
QSignalSpy spy3(&socket, SIGNAL(encrypted()));
|
|
// We don't take care for sslErrors signal here, but signal will emit still we will get successful connection
|
|
|
|
setSocketAttributes(&socket);
|
|
socket.setPeerVerifyMode(QSslSocket::QueryPeer);
|
|
|
|
socket.startServerEncryption();
|
|
|
|
QVERIFY(spy3.wait());
|
|
|
|
QVERIFY2(socket.isValid(), "Server socket disconnected");
|
|
QVERIFY2(socket.isEncrypted(), "Server socket not yet encrypted");
|
|
QVERIFY2(!socket.peerCertificate().isNull(), "Peer certificate is null");
|
|
|
|
delete mUdpServer;
|
|
}
|
|
|
|
void LanLinkProviderTest::unpairedDeviceUdpPacketReceived()
|
|
{
|
|
m_server = new Server(this);
|
|
m_udpSocket = new QUdpSocket(this);
|
|
|
|
m_server->listen(QHostAddress::LocalHost, TEST_PORT);
|
|
|
|
QSignalSpy spy(m_server, &Server::newConnection);
|
|
qint64 bytesWritten = m_udpSocket->writeDatagram(m_identityPacket.toLatin1(), QHostAddress::LocalHost, LanLinkProvider::UDP_PORT); // write an identity packet to udp socket here, we do not broadcast it here
|
|
QCOMPARE(bytesWritten, m_identityPacket.size());
|
|
|
|
QVERIFY(!spy.isEmpty() || spy.wait());
|
|
|
|
QSslSocket* serverSocket = m_server->nextPendingConnection();
|
|
|
|
QVERIFY2(serverSocket != 0, "Server socket is null");
|
|
QVERIFY2(serverSocket->isOpen(), "Server socket already closed");
|
|
|
|
m_reader = new SocketLineReader(serverSocket, this);
|
|
QSignalSpy spy2(m_reader, &SocketLineReader::readyRead);
|
|
QVERIFY(spy2.wait());
|
|
|
|
QByteArray receivedPacket = m_reader->readLine();
|
|
QVERIFY2(!receivedPacket.isEmpty(), "Empty packet received");
|
|
|
|
testIdentityPacket(receivedPacket);
|
|
|
|
// Received identity packet from LanLinkProvider now start ssl
|
|
|
|
QSignalSpy spy3(serverSocket, SIGNAL(encrypted()));
|
|
|
|
setSocketAttributes(serverSocket);
|
|
serverSocket->setPeerVerifyMode(QSslSocket::QueryPeer);
|
|
serverSocket->startClientEncryption(); // Its TCP server. but SSL client
|
|
QVERIFY(spy3.wait());
|
|
|
|
QVERIFY2(serverSocket->isValid(), "Server socket disconnected");
|
|
QVERIFY2(serverSocket->isEncrypted(), "Server socket not yet encrypted");
|
|
QVERIFY2(!serverSocket->peerCertificate().isNull(), "Peer certificate is null");
|
|
|
|
delete m_server;
|
|
delete m_udpSocket;
|
|
}
|
|
|
|
void LanLinkProviderTest::testIdentityPacket(QByteArray& identityPacket)
|
|
{
|
|
QJsonDocument jsonDocument = QJsonDocument::fromJson(identityPacket);
|
|
QJsonObject jsonObject = jsonDocument.object();
|
|
QJsonObject body = jsonObject.value(QStringLiteral("body")).toObject();
|
|
|
|
QCOMPARE(jsonObject.value(QStringLiteral("type")).toString(), QStringLiteral("kdeconnect.identity"));
|
|
QVERIFY2(body.contains(QStringLiteral("deviceName")), "Device name not found in identity packet");
|
|
QVERIFY2(body.contains(QStringLiteral("deviceId")), "Device id not found in identity packet");
|
|
QVERIFY2(body.contains(QStringLiteral("protocolVersion")), "Protocol version not found in identity packet");
|
|
QVERIFY2(body.contains(QStringLiteral("deviceType")), "Device type not found in identity packet");
|
|
}
|
|
|
|
QSslCertificate LanLinkProviderTest::generateCertificate(QString& commonName, QCA::PrivateKey& privateKey)
|
|
{
|
|
QDateTime startTime = QDateTime::currentDateTime();
|
|
QDateTime endTime = startTime.addYears(10);
|
|
QCA::CertificateInfo certificateInfo;
|
|
certificateInfo.insert(QCA::CommonName,commonName);
|
|
certificateInfo.insert(QCA::Organization,QStringLiteral("KDE"));
|
|
certificateInfo.insert(QCA::OrganizationalUnit,QStringLiteral("Kde connect"));
|
|
|
|
QCA::CertificateOptions certificateOptions(QCA::PKCS10);
|
|
certificateOptions.setSerialNumber(10);
|
|
certificateOptions.setInfo(certificateInfo);
|
|
certificateOptions.setValidityPeriod(startTime, endTime);
|
|
certificateOptions.setFormat(QCA::PKCS10);
|
|
|
|
QSslCertificate certificate = QSslCertificate(QCA::Certificate(certificateOptions, privateKey).toPEM().toLatin1());
|
|
return certificate;
|
|
}
|
|
|
|
void LanLinkProviderTest::setSocketAttributes(QSslSocket* socket)
|
|
{
|
|
socket->setPrivateKey(QSslKey(m_privateKey.toPEM().toLatin1(), QSsl::Rsa));
|
|
socket->setLocalCertificate(m_certificate);
|
|
}
|
|
|
|
void LanLinkProviderTest::addTrustedDevice()
|
|
{
|
|
KdeConnectConfig::instance().addTrustedDevice(m_deviceId, m_name, QStringLiteral("phone"));
|
|
KdeConnectConfig::instance().setDeviceProperty(m_deviceId, QStringLiteral("certificate"), QString::fromLatin1(m_certificate.toPem()));
|
|
}
|
|
|
|
void LanLinkProviderTest::removeTrustedDevice()
|
|
{
|
|
KdeConnectConfig::instance().removeTrustedDevice(m_deviceId);
|
|
}
|
|
|
|
void LanLinkProviderTest::socketBindErrorFail(const QUdpSocket& socket)
|
|
{
|
|
QAbstractSocket::SocketError sockErr = socket.error();
|
|
// Refer to https://doc.qt.io/qt-5/qabstractsocket.html#SocketError-enum to decode socket error number
|
|
QString errorMessage = QLatin1String("Failed to bind UDP socket with error ");
|
|
errorMessage = errorMessage + QString::fromLatin1(QMetaEnum::fromType<QAbstractSocket::SocketError>().valueToKey(sockErr));
|
|
QFAIL(errorMessage.toLocal8Bit().data());
|
|
}
|
|
|
|
|
|
QTEST_GUILESS_MAIN(LanLinkProviderTest)
|
|
|
|
#include "lanlinkprovidertest.moc"
|