tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kdeconnect-kde/plugins
History
Nicolas Fella f39a03fe13 [plugins/notifications] Prevent crash when default notification action is invoked. 
When the notification's default action is activated, i.e. the notification is clicked, activated with index 0 is emitted.
This will lead to a crash since m_actions[-1] will be accessed.

This does not happen on Plasma since we don't specify that we have a default action and thus the notification isn't clickable.
However on LXDE the notification is clickable regardless and we get the according signal.

This arguably works around a bug in LXDE, but given that the workaround is cheap and other systems may behave this way too I think it's reasonable to do this.

BUG: 427717
2020-12-07 19:50:04 +00:00
..
battery initialize battery plugin members to fix crashing on Windows 2020-10-31 20:18:42 +00:00
bigscreen bigscreen: add comment on how this plugin is used 2020-11-16 12:55:47 +00:00
clipboard SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
contacts SVN_SILENT made messages (.desktop file) - always resolve ours 2020-10-17 06:06:46 +02:00
findmyphone SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
findthisdevice SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
lockdevice lockdeviceplugin: make plugin useful through CLI by --lock and --unlock 2020-11-23 21:22:46 +00:00
mousepad Fix build with libfakekey 2020-11-17 14:34:20 +01:00
mpriscontrol SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
mprisremote SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
notifications [plugins/notifications] Prevent crash when default notification action is invoked. 2020-12-07 19:50:04 +00:00
pausemusic SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
photo SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
ping SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
presenter SVN_SILENT made messages (.desktop file) - always resolve ours 2020-10-17 06:06:46 +02:00
remotecommands SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
remotecontrol SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
remotekeyboard SVN_SILENT made messages (.desktop file) - always resolve ours 2020-09-19 06:10:24 +02:00
remotesystemvolume SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
runcommand SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
screensaver-inhibit [plugins/screensaver] Port away from QDBusInterface 2020-10-13 23:55:31 +00:00
sendnotifications SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
sftp Port from KRun (deprecated) to OpenUrlJob 2020-10-09 19:30:09 +00:00
share SVN_SILENT made messages (.desktop file) - always resolve ours 2020-11-29 06:09:21 +01:00
sms [SMS App] Use interface for querying a range of messages 2020-11-02 16:40:58 +00:00
systemvolume Fixed kdeconnectd deadlock on Windows caused by systemvolumeplugin 2020-11-19 23:28:44 +03:00
telephony CMake cleanup 2020-11-16 12:21:07 +00:00
CMakeLists.txt Remove obsolete kservicetypes file 2020-11-16 12:21:24 +00:00
kdeconnect.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 2020-12-07 06:11:38 +01:00
Messages.sh Figure out Messages.sh after code refactoring 2014-06-17 18:45:47 +02:00
README.txt Update README.txt in Plugins to include the current method to build a skeleton for a Plugin 2020-03-27 21:02:16 +05:30

README.txt 

Writing a plugin for KDE Connect
=================================

For the desktop client (this project):
--------------------------------------

1. Enter the "plugins" directory.
2. Copy the "ping" under a different name ("findmyphone" in this example).
3. Add "add_subdirectory(findmyphone)" to CMakeLists.txt after the others "add_subdirectory".
4. Enter the new "findmyphone" directory.
5. Edit CMakeLists.txt by replacing "ping" with "findmyphone".
6. Rename other files in this directory by replacing "ping" with "findmyphone"
7. Write a description of your plugin into "README"
8. Edit findmyphoneplugin.cpp and findmyphoneplugin.h.
  A. Change license header.
  B. Replace (case sensitive) "ping" with "findmyphone", "PingPlugin" with "FindMyPhonePlugin" and "PING" with "FINDMYPHONE".
9. Edit kdeconnect_findmyphone.json file:
  A. Replace "ping" with "findmyphone".
  B. Change name, description, icon, author, email, version, website, license info.
  C. Remove all the translations
  D. Set X-KDEConnect-SupportedPacketType and X-KDEConnect-OutgoingPacketType to the packet type your plugin will receive
     and send, respectively. In this example this is "kdeconnect.findmyphone". Make sure that this matches what is defined in
     the findmyplugin.h file (in the line "#define PACKET_TYPE_..."), and also in Android.
10. Now you have an empty skeleton to implement your new plugin logic.

For Android (project kdeconnect-android):
-----------------------------------------

1. Change directory to src/org/kde/kdeconnect/Plugins.
2. Copy "PingPlugin" under a different name ("FindMyPhonePlugin" in this example).
3. Enter the new "FindMyPhonePlugin" directory.
4. Rename "PingPlugin.java" to "FindMyPhonePlugin.java"
5. Edit it. Replace (case sensitive) "Ping" with "FindMyPhone", "ping" with "findmyphone", "PING" with "FINDMYPHONE"
   and "plugin_ping" with "plugin_findmyphone".
6. Open res/values/strings.xml. Find and copy the lines "pref_plugin_ping_desc" and "pref_plugin_ping" replacing "ping"
   with "findmyphone" and edit the plugin name and description between <string> </string>).
7. Now you have an empty skeleton to implement your new plugin logic.