Commit graph

2415 commits

Author SHA1 Message Date
Albert Vaca
ede8f17e15 Incorrect Q_EMIT syntax 2018-11-06 23:29:39 +01:00
Albert Vaca
80395d4ca6 Missing Q_OBJECT macro 2018-11-06 23:28:25 +01:00
Albert Vaca
73129abbf5 Unused var 2018-11-06 23:28:03 +01:00
Albert Vaca
72b3d91539 Merge branch '1.3' 2018-11-06 14:30:23 +01:00
Albert Vaca
14e6ed8d60 Bump patch version to release 2018-11-06 14:29:07 +01:00
Erik Duisters
8388ed0603 A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon
Summary:
kio-kdeconnect fails to start on KDE Neon because it does not instantiate a QApplication object

BUG: 400178

Test Plan:
Install on a KDE Neon 5.14 system or VM
Pair an android phone
Browse the phone's filesystem using dolphin

Reviewers: #kde_connect, #frameworks, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16692
2018-11-06 14:22:50 +01:00
Erik Duisters
560e8638e8 A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon
Summary:
kio-kdeconnect fails to start on KDE Neon because it does not instantiate a QApplication object

BUG: 400178

Test Plan:
Install on a KDE Neon 5.14 system or VM
Pair an android phone
Browse the phone's filesystem using dolphin

Reviewers: #kde_connect, #frameworks, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16692
2018-11-06 14:20:08 +01:00
l10n daemon script
a3cce94666 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-06 05:56:05 +01:00
l10n daemon script
39c8603e54 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-05 05:36:20 +01:00
Nicolas Fella
7c89338deb Add a little margin 2018-11-05 02:05:02 +01:00
Nicolas Fella
71ef6f6ba9 Add explicit edit mode to device name field
Summary: Similar to what we do in the KCM. Show the name in a label and make it editable per button.

Test Plan: Rename device

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16639
2018-11-05 01:56:25 +01:00
Nicolas Fella
ccd476c150 Add open on remote device (Desktop)
Summary:
Add openFile to Share Plugin and extend handler to open local file urls

Future extension: Modify the desktop file to allow Open with > Open on connected device

Depends on D16605

Test Plan: Apply Android patch. Use kdeconnect-handler file:///somefile. Check phone for reaction

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Maniphest Tasks: T8637

Differential Revision: https://phabricator.kde.org/D15294
2018-11-04 19:55:30 +01:00
l10n daemon script
8d831d018b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-04 06:02:51 +01:00
Billy Laws
0b72150ed8 Add support for sharing text via qml
Summary: This allows you to send a text string from qml, this can be used in the plasmoid and qml app.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16640
2018-11-03 22:23:03 +01:00
Nicolas Fella
276d18a02a Fix clang-tidy warning 2018-11-03 02:17:25 +01:00
Nicolas Fella
4a6db4c35f Thunar integration
Summary:
Add desktop file for integration into Thunar
Depends on D16603

Test Plan: Run Thunar, Right-click file -> Send to -> Send via KDE Connect

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16604
2018-11-03 01:41:06 +01:00
Nicolas Fella
e5bbc37546 Add contract file
Summary:
This allows sending files from ElementaryOS apps such as their file manager.

Create a data dir for similar files

Test Plan: run contractor; run pantheon-files, right-click file -> Send via KDE Connect

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16603
2018-11-03 01:37:30 +01:00
Nicolas Fella
193481ce46 [handler] Embed URL into string
Summary:
E.g.
Device to call +1234567 with
Device to send /home/nico/foo to
Device to open http://google.com on

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16623
2018-11-03 01:37:01 +01:00
Nicolas Fella
357751ac68 [handler] Improve text if a file is shared
Summary:
The handler allows to easily integrate file sharing into various file managers. Make it appear nicer by removing the scheme and using a different wording when sending
files

Test Plan: {F6382616}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16605
2018-11-03 00:40:34 +01:00
Nicolas Fella
2a8938e09f Show message when clicking add commands
Summary: It isn't obvious what happens when clicking the add commands action. Show a message.

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16549
2018-11-03 00:27:29 +01:00
Nicolas Fella
6800854fd3 Add .qmlc and .rej files to gitignore 2018-11-02 23:02:26 +01:00
Nicolas Fella
fb2817e3f3 Add missing file 2018-11-02 22:13:36 +01:00
Billy Laws
f15c21e56b Add support for sharing files from QML app
Summary: This allows you to a share a local file to a remote device using the qml app.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16614
2018-11-02 21:42:08 +01:00
Nicolas Fella
56ebd3f889 Fix with calculation 2018-11-02 15:47:52 +01:00
Nicolas Fella
cefc743307 Only show addCommand button when adding commands is supported 2018-11-02 15:44:14 +01:00
Nicolas Fella
e0766ba532 Align buttons 2018-11-02 15:38:52 +01:00
Nicolas Fella
e66817928f Actually include desktop file 2018-11-02 03:22:05 +01:00
Nicolas Fella
a53d99a8ad Thunar integration
Summary: Add desktop file for integration into Thunar

Test Plan: Run Thunar, Right-click file -> Send to -> Send via KDE Connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16604
2018-11-02 03:21:03 +01:00
Nicolas Fella
9a56d7531b Add contract file
Summary:
This allows sending files from ElementaryOS apps such as their file manager.

Create a data dir for similar files

Test Plan: run contractor; run pantheon-files, right-click file -> Send via KDE Connect

Reviewers: #kde_connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16603
2018-11-02 03:00:39 +01:00
Billy Laws
eaea0ab667 Add support for sharing files from plasmoid
Summary: This allows you to share a local file on your device to a remote device running kde connect.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16552
2018-11-01 18:33:39 +01:00
Simon Redman
787e76ee91 Change SmsPlugin qDebug to qCDebug 2018-11-01 09:36:43 -06:00
l10n daemon script
0faa5c5f18 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-11-01 05:51:47 +01:00
Billy Laws
5c86da54aa Add QML support for shareplugin
Summary: This will allow it to be used in the plasmoid and QML app via dbus.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16551
2018-10-31 19:40:10 +01:00
Nicolas Fella
bf03990b75 Add editorconfig file
Summary: editorconfig is a cross-editor way of keeping basic coding style standards, e.g. indentation

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: apol, albertvaka, sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16533
2018-10-31 16:51:32 +01:00
Nicolas Fella
1359a9c059 Don't use deprecated ApplicationHeader
Summary:
Use the implicit header

This makes the Add commands action show up in the top bar on desktop

Desktop
{F6375830}

Mobile
{F6375831}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16548
2018-10-31 16:50:52 +01:00
Simon Redman
70926fbeaf [SMS App] Clean up runtime warning about undefined behavior
Summary: Move ColumnLayout containing text elements inside of the graphical bounding rectangle

Test Plan:
Pre patch:
 - Launch messaging app
 - Open conversation
 - Notice huge spew of warnings like: "qrc:/qml/ChatMessage.qml:84:5: QML ColumnLayout: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead."
Post patch:
 - Launch messaging app
 - Open conversation
 - No warnings about undefined behavior

Reviewers: apol

Reviewed By: apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16534
2018-10-31 08:47:19 -06:00
Billy Laws
c546c77040 Add a button to open command setup menu in plasmoid
Summary: This patch adds a button to the plasmoid to allow adding commands by opening the menu on the remote device.

Reviewers: #vdg, nicolasfella, albertvaka

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16535
2018-10-30 23:42:56 +01:00
Bart Ribbers
43e6fed43d Fix build failure on musl based systems
Summary:
Musl lacks backtrace support, so this patch fixes the build by making sure it only gets compiled when using a glibc system.

Bug: 395161

Reviewers: #kde_connect

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13446
2018-10-30 22:04:14 +01:00
Simon Redman
e6d84ece34 Replaces tabs with spaces (properly) 2018-10-30 14:03:16 -06:00
Simon Redman
e9d5c9e27e Revert "Replace tabs with spaces in messaging app"
This reverts commit 6657dff8cf.
2018-10-30 14:01:13 -06:00
Simon Redman
6657dff8cf Replace tabs with spaces in messaging app 2018-10-30 13:58:50 -06:00
Jun Bo Bi
467ac64be7 [remoteinput] Added keyboard support for windows
Summary:
Added keyboard input support for Windows
Completes T6269

Test Plan:
  - Open Remote input
  - Type something in

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect, #kde_connect

Tags: #kde_connect, #windows

Differential Revision: https://phabricator.kde.org/D16501
2018-10-30 11:31:58 +01:00
Simon Redman
0f5c9cd96c Make NetworkPacket Metatype-capable
Summary: I am open to discussion for whether this is desireable. The use-case is for moving NetworkPacket receive handling to a thread other than the one handling the rest of the device. In order to do this, we need to use a QtConnectionType::QueuedConnection. In order for that to work (with NetworkPackets), NetworkPacket has to be registered in the Metatype system.

Test Plan: Nothing should be functionally different from before

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, apol, nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16469
2018-10-29 10:42:12 -06:00
Simon Redman
08b31ce258 Properly Assign LanLinkProvider as the Parent of its child objects
Summary: This is not a hugely important change. I noticed it while I was working on something else, and it seems like it ought to be this way

Test Plan: Nothing should be noticeably different

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16468
2018-10-29 09:48:09 -06:00
l10n daemon script
19bea39619 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-28 04:53:25 +01:00
Alex Kovrigin
4daf129cf3 Improve "No devices" warning
Summary:
Move the "No devices available" text in smsapp from combobox to the ConversationList.

P.S.
It's a GCI task.

Test Plan:
* Build and run smsapp
* Try pairing and unpairing the device
* See the difference

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16467
2018-10-27 14:49:39 -06:00
Simon Redman
b01652f54d Fix include guards
Summary:
Some plugins were copy/pasted from a template and forgot to change their include guards. Since plugin header files are never cross-referenced, this was not a serious issue, but it looks nicer to be correct

NotificationListener.h did not have an include guard. As before, this is not a problem currently, but it's best to have it fixed

Test Plan: Project should build, compile, and run as normal

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16437
2018-10-26 15:29:39 -06:00
l10n daemon script
6879cf14cd SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-24 05:55:51 +02:00
Adam Pigg
ee52c8cd03 use libkeepalive to wakeup daemon
Summary:
Main change is to use libkeepalive to wake up the system to ensure connections stay alive

Other minor changes are:
-Log daemon messages for debugging purposes
-Add way to forece refresh of device list
-Minor spec improvements

The keepalive changes certainly seem to help, not sure if it completely solves the problems
The logging changes are temporary, and I could use them locally, but they only affect sailfish users
Im not sure if the refresh method is correct, but seems to force the daemon to check for devices

Reviewers: #kde_connect, nicolasfella, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15414
2018-10-23 08:30:48 +01:00
l10n daemon script
a98533b8f4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-23 06:01:17 +02:00