Aleix Pol
d7ec24725f
Make sure we keep track of changes when the device link changes
...
Especially useful because it contains the announce name.
CCBUG: 364150
2017-07-14 03:30:49 +02:00
Albert Vaca
f7b2cee995
Remove debug message
2017-07-14 02:17:59 +02:00
Aleix Pol
27876542ab
Unpair whenever there's a QSSLError
2017-07-14 02:17:59 +02:00
Albert Vaca
b67761a442
Remove debug messages
2017-07-14 00:32:40 +02:00
Aleix Pol
29888cb78b
Improve debug information
...
If we're ignoring an ssl issue, at least show it.
On connected show whether the socket is valid, otherwise we get remote
devices disconnected without any message. (In this case HostNameMismatch)
Also fixes a typo
CCBUG: 381542
2017-07-07 17:26:55 +02:00
Albert Vaca
34d419756b
Merge branch '1.x'
2017-04-13 21:23:29 +02:00
Albert Vaca
a4f2a60d47
Do not use the default proxy.
...
Qt uses the system proxy if set up, explicitly disable it.
BUG: 376187
2017-03-06 22:02:08 +01:00
Albert Vaca
1b308a547d
Fix warning because of missing enum value in switch
2017-02-18 15:32:55 +01:00
Albert Vaca
2c1c8525e5
Now a 100% more compiling
2017-02-14 23:03:59 +01:00
Albert Vaca
25e0cea373
Make error message reflect the actual ports we use
2017-02-14 22:52:37 +01:00
Albert Vaca
f0a96a3ab9
Do not error if we try to request pair again
2017-02-10 00:54:03 +01:00
Albert Vaca
7e63a90da6
Merge branch '1.x'
...
# Conflicts:
# app/org.kde.kdeconnect.app.desktop
# plugins/kdeconnect.notifyrc
# plugins/remotecommands/kdeconnect_remotecommands.json
# plugins/sendnotifications/kdeconnect_sendnotifications_config.desktop
2017-02-05 16:12:25 +01:00
Albert Vaca
12a3027be6
Wrong order, condition was always false.
2017-02-05 16:08:20 +01:00
Aleix Pol
5d088041c0
Don't leak pairing handlers
2017-01-25 01:16:07 +01:00
Aleix Pol
ea41d3786e
Expose pairing state for devices
...
Will allow to have information about whether we're pairing, mostly for
better GUI.
Pair-programmed with Albert Vaca
2017-01-25 00:22:22 +01:00
Holger Kaelberer
a75e0ba031
Make pairing notifications more persistent
...
Notifications are not persistent, and once gone there is no
way to accept the request. Clicking the notification in the
notification history does nothing in plasma and gnome.
There make them persistent and close them after the pairing timeout,
after which they are no longer useful.
BUG: https://phabricator.kde.org/T5002
2017-01-05 19:11:55 +01:00
Albert Vaca
beeae63086
Missing Q_OBJECT macro
2016-11-26 16:36:34 +01:00
Albert Vaca
60331ccbf1
Clazy says all this QStringLiteral and QLatin1String were missing/wrong
2016-11-26 16:21:29 +01:00
Albert Vaca
a1340c8042
Fixed old style connects with clazy
2016-11-26 15:14:19 +01:00
Albert Vaca
f845b33392
Fixed bug on Windows
2016-11-20 04:25:11 +01:00
Albert Vaca
c9cfac7253
Remove debug logs
2016-08-29 11:00:35 +02:00
Aleix Pol
0774020899
Merge branch '1.0' into 1.x
2016-08-14 21:15:13 +02:00
Aleix Pol
91f952f5f1
Fix test
...
Use the right port
Store the port in a public variable, so it can be used from the test.
2016-08-08 19:38:58 +02:00
Albert Vaca
50496a3442
Reverted change that introduced a crash.
...
If there are ssl erros with unpaired devices, link was null.
This reverts commit 7da30ddbb1
.
2016-08-03 22:01:04 +02:00
Albert Vaca
2cdf7d5499
Reduced logging
2016-07-12 12:49:21 +02:00
Albert Vaca
f41877fbec
Disabled removing links when exiting discovery mode because it was broken.
...
If both devices are in "discovery mode" (ie: both want to keep links
established) and the last one to create the link goes out of discovery
mode, it will close the link when it shouldn't (because the other end still
was "using" it to display it to the user).
2016-07-12 12:38:40 +02:00
Albert Vaca
7da30ddbb1
Use the pairing handler instead of accessing the device directly on error
2016-07-12 12:34:56 +02:00
Albert Vaca
5933c6810c
More unused includes cleanup
2016-07-05 14:27:53 +02:00
Albert Vaca
7c0fbbc034
Unused include cleanup
2016-07-05 14:13:48 +02:00
Albert Vaca
9c736583e2
Use the actual connection origin, so we don't keep all connections open.
2016-07-05 12:42:39 +02:00
Aleix Pol
2b451097eb
Make sure errors get reported
2016-07-05 01:00:02 +02:00
Albert Vaca
385bf77480
Fixed bug which didn't allow to pair a new device
2016-07-04 19:52:37 +02:00
Aleix Pol
359194c2ed
Use initializers to construct it
2016-07-04 19:18:13 +02:00
Albert Vaca
04713de718
Remove qdebugs
2016-06-26 15:48:37 +02:00
Aleix Pol
ef98fb4587
Fix file transfer under SSL
...
Introduces a big fat buffer :(
Actually test the trasfers :)
Takes QSslSocket causistic into account, for some reason QNAM refuses to
mark as finished when the QSslSocket (through QIODevice) closes.
It would be good to look into dropping the QBuffer, doing so with the test
in place will help.
2016-06-22 17:49:45 +02:00
Albert Vaca
01139d31d1
De-duplicated socket SSL configuration code
2016-06-22 14:27:09 +02:00
Aleix Pol
4cb50d69d8
Fix some issues in the downloadjob and its test
...
Test on KJob abstraction, this way we can check if it has an error when it
breaks.
Handle errors in a different branch of the code.
2016-06-22 12:40:14 +02:00
Aleix Pol
f9406e8afc
Introduce QVariantMap as an argument of NetworkPackage
...
Makes it possible to specify the different properties sent at once,
rather than one by one as we used to do.
Also port whenever possible to the initializer-list syntax.
REVIEW: 128269
2016-06-21 20:07:12 +02:00
Albert Vaca
e880e14ed5
Preffer Q_FOREACH to foreach
2016-06-21 14:50:17 +02:00
Albert Vaca
5abd081b85
Changed port so we don't conflict with Houdini
2016-06-21 14:42:32 +02:00
Aleix Pol
596e4484f4
Clean up use of virtual and override keywords
...
Only use virtual when actually virtual, to override just use override.
2016-06-20 19:22:29 +02:00
Albert Vaca
c4d7c2f39b
Improved comments
2016-06-17 02:00:23 +02:00
Albert Vaca
e379fcd69d
Destroying a socket should not destroy the link.
...
Also, sockets can be destroyed as soon as the socketreader is deleted.
2016-06-17 02:00:23 +02:00
Albert Vaca
91c23dfdea
Do not compare against the current version of the protocol
2016-06-16 19:48:23 +02:00
Albert Vaca
cb0fd1fe20
Removed a case where we would still add a link on old protocol versions
2016-06-15 20:38:57 +02:00
Aleix Pol
5715926c5c
Export the symbols needed by the tests
2016-06-10 15:07:33 +02:00
Albert Vaca
3177143439
Fixed build on windows
2016-06-09 02:36:02 +02:00
Albert Vaca
1c315af108
Revert "Fix file transfers"
...
This reverts commit 252ea4ba20
.
2016-06-07 00:28:52 +02:00
Aleix Pol
751bd5849b
small style changes
2016-06-06 01:21:37 +02:00
Frederik Schwarzer
a594324d4f
Fix message wording.
2016-06-03 21:33:25 +02:00