Commit graph

15 commits

Author SHA1 Message Date
Jean Vincent
c864267f04 Replace Q_FOREACH with C++11 range-for
Summary:
The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.

I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).

I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.

(This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)

Reviewers: #kde_connect, nicolasfella, apol

Reviewed By: #kde_connect, nicolasfella, apol

Subscribers: albertvaka, apol, nicolasfella

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6724
2017-07-21 09:57:19 +02:00
Albert Vaca
60331ccbf1 Clazy says all this QStringLiteral and QLatin1String were missing/wrong 2016-11-26 16:21:29 +01:00
Albert Vaca
a1340c8042 Fixed old style connects with clazy 2016-11-26 15:14:19 +01:00
Aleix Pol
d8c20399e4 pedantic 2016-06-15 23:49:51 +02:00
Aleix Pol
f1f0b85d3e Verbose errors 2016-06-12 22:26:32 +02:00
Aleix Pol
a8a8080248 Prevent detaching temporary objects
For more info see:
https://blogs.kde.org/2015/05/13/simple-qt-container-optimization-you-should-do-your-code
2015-09-12 09:53:05 +02:00
Aleix Pol
d58f6314fe run Clang Modernize
Minus the auto change
2015-09-08 10:47:37 +02:00
Boris Egorov
1924173df2 Fix various krazy2 warnings
Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes], [normalize],
[postfixop], [spelling]

See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html
for details.

SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize

REVIEW: 124857
2015-08-21 22:38:54 +06:00
Samoilenko Yuri
fb8fa53f8d some fixes 2014-02-06 19:25:50 +04:00
Samoilenko Yuri
499b8b00b7 some fixes 2014-02-06 00:36:51 +04:00
Samoilenko Yuri
776543409d button works 2014-01-31 14:06:21 +04:00
Samoilenko Yuri
881450146f wow - almost work, but some tricks... 2014-01-30 20:39:11 +04:00
Samoilenko Yuri
a54dd853ff play continues... 2014-01-30 20:25:22 +04:00
Samoilenko Yuri
9ce35fbd4d qml in qt4 - ugly shit... Some experiments 2014-01-29 09:17:06 +04:00
Samoilenko Yuri
42b927bcab hard experiments.. 2014-01-29 02:22:59 +04:00