Summary: There is no reason to disable it. On Android we do the same
Test Plan: Click on paired device in list, correct Page opens
Reviewers: #kde_connect, apol
Reviewed By: #kde_connect, apol
Subscribers: kdeconnect, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D13454
Summary: This seems to fix the issue I mentioned on Telegram/Mail
Test Plan:
Before: Use Mprisremote plugin with App. View did not update when e.g. next is pressed.
Now: View correctly represents the DBus data
Reviewers: #kde_connect
Subscribers: #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D12528
Summary:
Musl lacks backtrace support, so this patch fixes the build by making sure it only gets compiled when using a glibc system.
Bug: 395161
Reviewers: #kde_connect
Subscribers: kdeconnect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D13446
Summary:
For real usecases of SMS support, we will almost always need access to the message history in some way
Specifically resolve T8338
Incidentally resolve T6651 since Telephony shall no longer create a notification
Test Plan:
Setup:
- Build corresponding Android-side diff (D11698)
- Build this diff
Step 1: Does anything at all work?
- Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
- Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
- Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation
Step 2: DBus
- Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
- Poke activeConversations and verify an empty array is returned
- Poke requestAllConversationThreads
- Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
- Use a conversationId to call getFirstFromConversation
- Verify that the returned Message object is one which you recognize
- Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"
Step 3: SMS App
- Use ccmake (or similar) to set SMSAPP_ENABLE to ON
- Build the project
- Run ./bin/kdeconnect-sms
- Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
- If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number
Reviewers: #kde_connect, nicolasfella, apol
Reviewed By: #kde_connect, nicolasfella, apol
Subscribers: andyholmes, apol, nicolasfella, #kde_connect
Tags: #kde_connect
Maniphest Tasks: T8338, T6651
Differential Revision: https://phabricator.kde.org/D11854
Summary: This is a supplement for D11352.
Reviewers: #plasma, #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11751
Summary:
Added the following example commands for the Run Command plugin:
- Lock Screen
- Unlock Screen
- Close All Vaults
- Forcefully Close All Vaults
Reviewers: #plasma, ngraham, albertvaka, nicolasfella, #kde_connect
Reviewed By: nicolasfella, #kde_connect
Subscribers: ngraham, kdeconnect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D13136
Summary:
Allows other devices to make this device discoverable via a
kdeconnect.findmyphone.request command, if running.
Currently supports playing a sound.
Counterpart to FindMyPhone plugin
Test Plan:
Connect with other device running KDE Connect (with Plasmoid).
Select a working play sound in the Find My Device plugin settings.
On other device trigger Find My Phone button for this device in KDE Connect
Plasmoid and notice this device playing the configured sound.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: kdeconnect, sredman, mtijink, apol, nicolasfella
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11773
Summary:
Allows other devices to make this device discoverable via a
kdeconnect.findmyphone.request command, if running.
Currently supports playing a sound.
Counterpart to FindMyPhone plugin
Test Plan:
Connect with other device running KDE Connect (with Plasmoid).
Select a working play sound in the Find My Device plugin settings.
On other device trigger Find My Phone button for this device in KDE Connect
Plasmoid and notice this device playing the configured sound.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: kdeconnect, sredman, mtijink, apol, nicolasfella
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11773
Summary:
Fixes T6701
The reason it did not work before is that the "Keyboard" did not report itself as available.
Test Plan:
Type in plasmoid on one Desktop, see text on another.
Note that no ack packets are sent, so the text does not appear in the original input text field. I want to await the discussion in D12670 before doing that
Reviewers: apol
Reviewed By: apol
Subscribers: mtijink, kdeconnect
Tags: #kde_connect
Maniphest Tasks: T6701
Differential Revision: https://phabricator.kde.org/D12812
