Commit graph

3182 commits

Author SHA1 Message Date
Nicolas Fella
bbce00e005 Remove parent from KNotification ctor
It doesn't do anything useful and is discouraged
2020-11-02 19:01:39 +01:00
Simon Redman
9ab80593e8 [SMS App] Use interface for querying a range of messages
## Summary
This patch adds an interface to return only a specified window of messages, making loading the conversations history smooth, fast, and enjoyable.

The current implementation of the conversation interface loads all messages every time the conversation is requested. This is might be painfully slow to load in case the conversation is large or if there are a lot of MMS/RCS messages in the conversation (since those are wildly slower to load than SMS)

Requires https://invent.kde.org/kde/kdeconnect-android/merge_requests/122 to enable Android functionality

## Test Plan

 - With new Android app and old Desktop app:
   - The Android app will notice the missing fields and query for all messages as before.
 - With old Android app and new Desktop app:
   - The desktop will send fields for the new interface which will not be read and all messages will be returned.
 - With new Android app and new Desktop app:
   - The new interface is used and returns only a certain number of messages at a time.
2020-11-02 16:40:58 +00:00
Piyush Aggarwal
9930319158 initialize battery plugin members to fix crashing on Windows 2020-10-31 20:18:42 +00:00
Nicolas Fella
f2d97193eb Remove defunct calls to KAboutData::pluginData
The data is never registered so they always return nullptr. We might as well not pass it.
2020-10-31 19:58:05 +00:00
Piyush Aggarwal
671046888f re-add pre-baked PNG icons for kdeconnect-indicator.exe.
commit 5210d1ae removes PNG icons from the codebase which were needed by the windows build.
2020-10-31 14:46:13 +00:00
Piyush Aggarwal
011758530b segregate icons into different folders 2020-10-31 14:46:13 +00:00
Matthijs Tijink
9d503bc893 Fix passing multiple attachments to the CLI
Also updated the related zsh autocompletion.
2020-10-31 14:02:58 +00:00
Piyush Aggarwal
06d81412b6 reliably kill dbus-daemon and kdeconnect-daemon using WinAPIs 2020-10-31 11:31:51 +00:00
Piyush Aggarwal
28b7ad0a5d add logging category KDECONNECT_INDICATOR to indicator 2020-10-31 11:31:51 +00:00
Piyush Aggarwal
bb14a772cd append link libraries for daemon in separate lines 2020-10-31 11:31:51 +00:00
Piyush Aggarwal
19d1fb6e12 remove kdeconnectindicatorwin.svg from CMake to fix windows build 2020-10-28 19:13:53 +05:30
Piyush Aggarwal
61bd71306c remove unneeded kdeconnect tray icon SVG 2020-10-27 20:28:36 +05:30
Piyush Aggarwal
f4a960a631 use kdeconnect-tray icon from breeze-icon set in windows build 2020-10-27 20:28:36 +05:30
Nicolas Fella
a600c27490 Set window icons for GUI executables
Otherwise the task bar entry on Gnome won't have an icon.
2020-10-24 22:21:23 +02:00
Alexander Lohnau
9d94c25d83 Use systemsettings5 instead of kcmshell5
CCBUG: 398803
2020-10-24 15:25:57 +02:00
Nicolas Fella
4439e7c662 [plugins/notifications] Merge notificationsdbusinterface and notificationsplugin
We can just expose the plugin itself to DBus like we do for all other plugins.
This way we don't need a separate adaptor class any more.
2020-10-18 21:42:06 +00:00
Nicolas Fella
1060c1a81a Add API for opening the KCM to daemon
We have a few places that open the KCM, with different arguments.

Centralize the implementation in one place.

This makes it easier to switch to invoking systemsettings5 in the future (once https://invent.kde.org/plasma/systemsettings/-/merge_requests/11 is in).

It also makes sure the relevant device is selected when clicking on a pairing notification.

The function is exposed to DBus for the Plasmoid and potential third-party users.

CCBUG: 425660
2020-10-18 18:40:48 +00:00
Nicolas Fella
5ff1a2f488 Remove unused member 2020-10-18 18:00:53 +02:00
l10n daemon script
cfec7d57df GIT_SILENT made messages (after extraction) 2020-10-18 02:23:34 +02:00
l10n daemon script
f814a2c8f6 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-17 06:06:46 +02:00
l10n daemon script
e155eefaec GIT_SILENT made messages (after extraction) 2020-10-17 02:21:15 +02:00
Nicolas Fella
0c9bfadb62 Follow release service version numbers
Ever since joining the release service we never increased our version number on release.
I've seen distros automatically apply the release service version scheme (20.0X) to the package,
but when running e.g. kdeconnect-cli -v we'd still get 1.4.

This way the version is automatically adjusted by the release tooling so we don't need to care about and cannot forget it any longer.
2020-10-15 12:24:27 +00:00
l10n daemon script
1f0bd42381 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-15 06:12:38 +02:00
l10n daemon script
f405d2ff66 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-14 06:25:35 +02:00
Nicolas Fella
8b4eaa54b4 [plugins/screensaver] Port away from QDBusInterface
It's better overall and makes Kai happy
2020-10-13 23:55:31 +00:00
l10n daemon script
4372678c1f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-11 05:57:21 +02:00
Simon Redman
a1ebbdfc09 [CLI] Use ConversationsDbusInterface to avoid problems with using raw dbus 2020-10-10 22:11:05 +00:00
Ahmad Samir
be63cea8e8 Port from KRun (deprecated) to OpenUrlJob 2020-10-09 19:30:09 +00:00
l10n daemon script
5fc9fb0fb2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-09 06:32:58 +02:00
Simon Redman
d36c97a001 Replace magic number with SMS_REQUEST_PACKET_VERSION 2020-10-09 00:27:33 +00:00
Simon Redman
31951d08c3 Update header documentation for PACKET_TYPE_SMS_REQUEST 2020-10-09 00:27:33 +00:00
Simon Redman
900f5687bb Revert changing "messageBody" field to "textMessage" 2020-10-09 00:27:33 +00:00
Doron Behar
6101ef3ad0 Fix missing kcm dependency for runcommand module
Without it, the build may fail with:

fatal error: kcmutils_version.h: No such file or directory
   35 | #include <kcmutils_version.h>
      |          ^~~~~~~~~~~~~~~~~~~~
2020-10-08 21:59:17 +03:00
Thomas Staudinger
f1ce22124c Fix kdeconnect_open MimeType
This changes the MimeType handler of the kdeconnect_open desktop file from an invalid "*/*" to the (hopefully) appropriate "application/octet-stream;" as discussed [here](https://bugs.launchpad.net/ubuntu/+source/kdeconnect/+bug/1878400)(including this solution), [here](https://github.com/clearlinux/distribution/issues/1906) and [here](https://bugs.archlinux.org/task/65865).
2020-10-05 00:20:47 +02:00
Albert Vaca Cintora
e05769e6de Fix initial set of devices not being emitted in dbus 2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
bd27aec9d2 Do not replace connections for a given deviceId if the certs have changed
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
ce0f00fc2d Limit the ports we try to connect to to the port range of KDE Connect
So we can't trigger connections to other services.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
613899be24 Do not remember more than a few identity packets at a time
To prevent the kdeconnect process from using too much memory.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
542d94a70c Limit number of connected sockets from unpaired devices
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Aleix Pol
8112729eb0 Don't brute-force reading the socket
The package will arrive eventually, and dataReceived will be emitted.
Otherwise we just end up calling dataReceived to no end.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Aleix Pol
024e5f23db Do not let lanlink connections stay open for long without authenticating
If there's no information received, close the socket to try again.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Aleix Pol
4fbd01a3d4 Limit identity packets to 8KiB
Healthy identity packages shouldn't be that big and we don't want to
allow systems around us to send us ever humongous packages that will
just leave us without any memory.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Matthias Gerstner
7e47d04053 Fix use after free in LanLinkProvider::connectError()
If QSslSocket::connectToHost() hasn't finished running.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
aa84aa5dcb Do not leak the local user in the device name.
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
Albert Vaca Cintora
7b904f47b3 Do not ignore SSL errors, except for self-signed cert errors.
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-10-02 12:52:08 +02:00
l10n daemon script
be2d3947f1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-29 06:04:37 +02:00
Simon Redman
8dd0111d99 [SMS App] Add thumbnail preview to ConversationList 2020-09-27 03:51:17 +00:00
Bharadwaj Raju
cb51cb4adf Fix bug with use of drawer hiding when not wideScreen
Make drawer reappear when resized from narrow to wide screen if drawer
was closed in narrow mode.
2020-09-25 17:42:22 +05:30
l10n daemon script
120218b7c1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-25 06:18:57 +02:00
Aleix Pol
bf089f3461 Remove unused variable 2020-09-24 18:31:11 +02:00