Albert Vaca
4230f4fb44
Added a signal so plugins know when we update the config
2015-09-12 04:50:20 -07:00
Aleix Pol
f7423c6ad6
Better use of error information
2015-09-12 09:47:47 +02:00
Aleix Pol
4730022810
Pass arguments as const-reference
2015-09-12 09:45:59 +02:00
Aleix Pol
5e0a7a34b9
Merge branch 'master' into ssl
...
# Conflicts:
# cli/kdeconnect-cli.cpp
# core/backends/lan/landevicelink.cpp
# core/backends/lan/landevicelink.h
# core/backends/lan/lanlinkprovider.cpp
# core/backends/lan/lanlinkprovider.h
# core/backends/lan/socketlinereader.h
# core/backends/lan/uploadjob.cpp
# core/backends/lan/uploadjob.h
# core/backends/loopback/loopbackdevicelink.h
# core/daemon.cpp
# core/daemon.h
# core/device.cpp
# core/device.h
2015-09-11 17:25:23 +02:00
Aleix Pol
b62349cae6
Merge branch 'stable'
2015-09-11 17:03:57 +02:00
Aleix Pol
9fedfcdb3d
Notify QNAM about the file received size
2015-09-11 17:03:11 +02:00
Albert Vaca
89afa5b9af
Renamed capabilties so we don't clash with KDE4's broken implementation
2015-09-11 06:20:15 -07:00
Aleix Pol
47147c5fa1
Merge branch 'stable'
2015-09-11 14:04:54 +02:00
Aleix Pol
c2acc37da6
Fix filtering of plugins that don't support capabilities
2015-09-11 14:00:15 +02:00
Aleix Pol
95f01c4bea
Use C++ for setting the default argument
2015-09-11 12:34:52 +02:00
Aleix Pol
ca4a81b8e8
Merge branch 'stable'
2015-09-11 12:24:15 +02:00
Aleix Pol
2b8a54357e
Remove redundant copy constructor
2015-09-11 12:22:59 +02:00
Aleix Pol
c62fac0bcf
Don't join hte interfaces in 1 string
...
Let NetworkPackage do the serialization
2015-09-11 12:14:19 +02:00
Albert Vaca
4c98e2e7b3
Less verbose output
2015-09-11 02:29:57 -07:00
Albert Vaca
b07e442b97
Less verbose plugin loader
2015-09-11 01:12:34 -07:00
Albert Vaca
4df14d1c7d
Fixed plugins without incoming nor outgoing packages being disabled
2015-09-11 01:12:22 -07:00
Patrick von Reth
da5c9bd30e
Fix compilation on Windows.
2015-09-10 15:51:38 +02:00
Aleix Pol
4cccb7344a
++verbosity on error
2015-09-09 20:12:16 +02:00
Aleix Pol
a9d2840664
Use acquire and release instead of a boolean property
...
This way we hope we won't end up without discovery if 2 instances need
discovery at the same time.
Reviewed by Albert Vaca
2015-09-09 20:09:04 +02:00
Aleix Pol
32daa4e51f
Fix misbehaviour
...
Delete devices, not links
2015-09-09 13:42:28 +02:00
Aleix Pol
77e92262fe
Fix build
2015-09-09 13:03:08 +02:00
Aleix Pol
26b0ec8b98
Make sure we don't disconnect from discovering remotes
...
Otherwise it's hard to let other devices connect to us, without having both
devices in discoverability mode.
Reviewed by Albert Vaca
2015-09-09 13:01:38 +02:00
Albert Vaca
c65be84a89
Only send capabilities packets for paired devices
2015-09-09 01:19:38 -07:00
Aleix Pol
a0da8ba858
Let the KPluginSelector react to changes in the plugin configuration
...
Mainly whenever the remote capabilities change.
Reviewed by The Vaca Man
2015-09-08 20:03:44 +02:00
Aleix Pol
b101e828a4
Fix capabilities detection
...
Only consider capabilities as unsupported if both incoming and outgoing are
empty, rather than either.
Reviewed by Albert Vaca
2015-09-08 17:58:40 +02:00
Aleix Pol
6a379e9227
Rename missingPlugins to unsupportedPlugins
2015-09-08 17:38:33 +02:00
Aleix Pol
617b66aeb8
small code simplification
...
removes changes from list to set
always uses the same path for figuring out the interfaces.
reviewed by Albert Vaca
2015-09-08 17:35:30 +02:00
Aleix Pol
df3581459a
Add a test that makes sure that capabilities are gathered correctly
...
While at it, fix the logic, because it wasn't working all that well.
Reviewed by Albert Vaca
2015-09-08 17:35:30 +02:00
Albert Vaca
854e4227fa
Read the capabilities in the first addLink instead of only the constructor
2015-09-08 08:37:43 -07:00
Aleix Pol
817fcbc9d6
Merge branch 'stable'
2015-09-08 10:51:41 +02:00
Aleix Pol
d58f6314fe
run Clang Modernize
...
Minus the auto change
2015-09-08 10:47:37 +02:00
Albert Vaca
1a63d18ada
Print more info
2015-09-08 01:12:00 -07:00
Aleix Pol
4023bf0599
Only keep connections alive with unpaired devices when discovery is enabled
...
At the moment, we were keeping the connection alive with every reachable
device. While this works optimally for most use-cases, on networks with
several devices with KDE Connect, the amount of connections grows
exponentially.
Reviewed by Albert Vaca
CCBUG: 352424
2015-09-08 09:30:55 +02:00
Aleix Pol
774893d3f9
cleanup
...
make attribute const
construct when initializing
no need to have all methods as slots
2015-09-08 09:22:31 +02:00
Aleix Pol
e1be5319f5
Only broadcast again if the network configuration actually changes
...
Reviewed Albert Vaca
2015-09-08 09:05:06 +02:00
Aleix Pol
4960247fb5
Add a package type that updates the device capabilities
...
Every time we reload the plugin list, report the plugins that we support.
If the remote devices' capabilities change, update the plugin list.
Reviewed by Albert Vaca
2015-09-07 20:03:05 +02:00
Aleix Pol
f65a1f206f
Turn core qWarnings into qCWarning
2015-09-07 19:35:07 +02:00
Aleix Pol
91351773fd
Mark incompatible plugins as such in the kcm
...
If a plugin isn't available, display it as unsupported by the device. This
is figured out through capabilities.
Reviewed by Albert Vaca
2015-09-07 19:35:07 +02:00
Aleix Pol
61f357a512
Fix regression
...
Reviewed by Albert Vaca
2015-09-07 17:12:28 +02:00
Aleix Pol
d835d01a09
Add a test for file sending, using the loopback device
...
Extends unit testing by making sure that file sharing works locally.
REVIEW: 125086
2015-09-07 15:03:04 +02:00
Vineet Garg
78e9c08732
Merge branch 'master' into ssl
...
Conflicts:
core/backends/lan/socketlinereader.h
core/backends/lan/uploadjob.h
core/networkpackage.h
2015-08-25 03:43:41 +05:30
Vineet Garg
17da38e5ba
Explicity using TLSv1 because using AnyProtocol causes a default TLSv1.2 handshake which not supported on older android version
...
Was using QueryPeer instead of VerifyPeer of isDeviceTrusted of connected slot
2015-08-25 01:14:24 +05:30
Boris Egorov
1924173df2
Fix various krazy2 warnings
...
Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes], [normalize],
[postfixop], [spelling]
See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html
for details.
SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize
REVIEW: 124857
2015-08-21 22:38:54 +06:00
Vineet Garg
44c0ec1c78
If remote device certificate is changes, in sslError due to simulataneous multiple connections, unpair was called on null pointer
2015-08-17 20:04:41 +05:30
Vineet Garg
eff84a49d4
We support any protocol instead of TLSv1.2
2015-08-16 21:19:56 +05:30
Vineet Garg
9bc93b6337
We generate certificate from present date -1 year to present date + 10 year, this avoids the case where certificate is not valid due to difference of time zones
2015-08-14 17:50:58 +05:30
Vineet Garg
75bd15ed65
Added default value while checking for link name in pairing handler, this provides backward compatibility
2015-08-14 17:33:08 +05:30
Vineet Garg
6fe1399a18
Fixed minor issues in pairing handler
2015-08-13 14:56:28 +05:30
Vineet Garg
c5a399b94b
Fixed code identation issue
2015-08-12 23:49:15 +05:30
Vineet Garg
6acb4204a2
Added KdeConnectConfigTest, TestSslSocketLineReader, LanLinkProviderTest
2015-08-12 23:42:27 +05:30
Vineet Garg
cf3d37b504
Fixed issue pointed out on RR
...
Fixed some pairing handler issues
2015-08-11 09:04:02 +05:30
Vineet Garg
2824e73617
Pairing handler implemented
2015-07-27 20:58:58 +05:30
Vineet Garg
27515546a0
Now per device per link type pairing handlers are there
2015-07-25 17:15:19 +05:30
Vineet Garg
1b430db4a3
Fixed indentation
2015-07-19 21:59:27 +05:30
Vineet Garg
eda2563d03
Fixed encryption info in cli
2015-07-19 20:25:28 +05:30
Vineet Garg
20e46418ba
Encryption info in cli
2015-07-18 18:54:10 +05:30
Vineet Garg
e6da860fb7
Fixed issues pointed out on CR
2015-07-14 17:34:04 +05:30
Vineet Garg
781adac15b
Removed whitespace
2015-07-13 19:55:22 +05:30
Vineet Garg
1ba68150a7
Made server like normal QTcpServer
2015-07-10 03:57:27 +05:30
Vineet Garg
7c777e6279
Implemented pairing handler interface
2015-07-10 03:21:08 +05:30
Vineet Garg
e7617f3da9
Use Q_DECL_OVERRIDE in server
2015-07-08 02:45:59 +05:30
Vineet Garg
8b0f06e484
Code cleanup, fixed socket deletelater issue
2015-07-08 00:22:10 +05:30
Vineet Garg
b6b5257ba4
Added ssl support in download job
2015-07-06 03:19:58 +05:30
Vineet Garg
0c110e4392
Added SSL encryption in file upload
...
DeviceId is used for peerVerifyName
2015-07-06 02:35:26 +05:30
Vineet Garg
148a713176
Initial working implementation of ssl
2015-07-05 18:53:53 +05:30
Aleix Pol
7d6912c11f
Revert "Drop NetworkPackage QObject heritage"
...
It makes us depend on unreleased Qt 5.5. Will un-revert it
when Qt 5.5 is a dependency we can take.
CCMAIL: kdeconnect@kde.org
This reverts commit 1a2f569a47
.
2015-06-27 20:54:07 +02:00
Aleix Pol
43451d6ae1
Simplify Device::id management
...
Removes the id->row mapping. It was broken as the indices weren't updated
when a row was added or removed.
Stop exposing Device::id through dbus, just store it in the interface
class.
* It's redundant as it's part of the interface definition
* If we keep it it will save us quite some dbus round-trips
* It will be reliable, as nowadays id() sometimes QString() if the dbus
connection is invalid.
REVIEW: 124158
2015-06-24 20:57:17 +02:00
Aleix Pol
1a2f569a47
Drop NetworkPackage QObject heritage
...
It was only used for introspection and we can use Q_GADGET for that.
Make the NetworkPackage objects much lighter.
REVIEW: 124166
2015-06-24 20:57:17 +02:00
Albert Vaca
77256e1932
Devices where not removed if they were unpaired after going offline
2015-06-21 19:40:05 -07:00
Albert Vaca
08938689c5
Emit less redundant events
2015-06-21 19:39:04 -07:00
Aleix Pol
68b206e525
Move the generation of dbus interfaces into interfaces/
...
Simplifies the code altogether by centralizing the generation into 1 call
that does all the steps.
REVIEW: 124120
2015-06-18 19:06:14 +02:00
Aleix Pol
5c79e8a7a6
Implement an MPRIS client plugin
...
Makes it possible to control remote MPRIS instances.
REVIEW: 124100
2015-06-18 04:01:01 +02:00
Albert Vaca
a4c8934ee7
If both devices request pairing at the same time, we just pair.
...
The second device accepts the request instead of failing.
2015-06-15 09:03:26 -07:00
Albert Vaca
2dab79bc3f
Fixed warning.
2015-06-15 09:03:26 -07:00
Albert Vaca
09557b8a14
Moved network change detection from daemon to lanlink
2015-06-14 13:54:52 -07:00
Aleix Pol
cee2c6b057
Remove unused declaration
2015-06-13 01:27:16 +02:00
Aleix Pol
ef788e0658
Restore removed API, deprecate
...
REVIEW: 124084
2015-06-12 17:54:47 +02:00
Aleix Pol
b592dc99a0
Merge pairingSuccessful and unpaired signals into pairingChanged(bool)
...
REVIEW: 124067
2015-06-11 16:19:00 +02:00
Albert Vaca
e5b897884c
Added device status icons to be used in the KCM instead of the IM ones
2015-05-17 23:28:58 -07:00
Aleix Pol
11996f56ca
Drop dependency of KIO from kdeconnectcore
...
Use QNetworkAccessManager for storing the files we receive instead of
directly KIO, then provide the KIO-based QNetworkAccessManager from the
daemon. This way we'll still get the KIO network-transparency, but the
library only depenends on QtNetwork, which will be easier to get in some
platforms.
After this change, we only depend on KConfig, KI18n and KCoreAddons, which
are tier1 and really easy to work with on any platform.
REVIEW: 123325
2015-05-05 01:07:29 +02:00
Àlex Fiestas
ba4c87abc1
Consume all pendingDatagrams from udpServer
...
This fixes a bug where receiving broadcast messages would stop working
in case 2 messages have been received at the same time.
The problem is that readReady will only emit once per batch of datagrams
received, in case we receive 2 datagrams but only consume 1, readReady
will never be emitted again.
2015-05-05 01:04:50 +02:00
Albert Vaca
2f7e6f7de2
Fixed compilation warnings in clang (one of them is actually an issue!)
2015-04-19 22:50:12 -07:00
Aleix Pol
3caf5e7908
Move some find_package dependencies to the children directories as agreed
2015-04-10 17:48:48 +02:00
Aleix Pol
48cb087ec8
Remove unneeded KService include
2015-04-10 17:47:54 +02:00
Ashish Bansal
c8eb5e3074
Changed KF5 5.8 to 5.9
2015-04-09 16:22:56 +05:30
Albert Vaca
07773b8141
disconnected is specific to Sockets, abouTtoClose is generic to IODevice
2015-04-04 19:04:11 -07:00
Albert Vaca
fbbaa854b2
Const
2015-04-04 19:03:24 -07:00
Albert Vaca
dacaee6629
Fixed daemon sending lots of identity packets at startup
...
The way we were detecting the active network interfaces caused to detect
all of them at the application startup.
2015-04-04 16:32:15 -07:00
Albert Vaca
6c6f2b1a03
Fixed uninitialized members
2015-04-04 10:17:08 -07:00
Aleix Pol
c9700de391
cleanup
...
Don't store into a const-reference
Fix typo
2015-04-02 00:02:09 +02:00
Aleix Pol
9ab7e2356e
Use QMetaObject for introspecting a QObject
...
It will be faster and will provide better error messages.
REVIEW: 123214
2015-04-01 23:38:32 +02:00
Aleix Pol
80d77fa9b6
Fix crash when incoming FileTransfer
...
Otherwise qobject2qvairant complains that a property is missing.
REVIEW: 123214
2015-04-01 23:37:25 +02:00
Yuri Chornoivan
0452839893
Add missing spaces
2015-03-25 19:46:29 +02:00
Aleix Pol
8f777040f7
Remove KNotifications dependency from libkdeconnectcore
...
Moves the implementation into the actual daemon. This opens the
possibility for different ways to expose these notifications depending on
where the libkdeconnect will be deployed.
REVIEW: 123076
2015-03-24 12:26:37 +01:00
Albert Vaca
a77a3dc0d5
Fixed broken compilation :/
...
BUG: 345460
2015-03-23 20:44:09 -07:00
Albert Vaca
a5e5b10d9a
Code styling
2015-03-21 23:12:04 -07:00
Albert Vaca
a649bb5668
Added some error messages when ports are not available
2015-03-21 23:11:50 -07:00
Albert Vaca
e20c3c907d
Fixed config memory leak.
2015-03-21 22:21:34 -07:00
Aleix Pol
c7cee37330
Port away from KServiceTrader
...
Uses KPluginLoader+KPluginMetadata instead.
Describes plugins in json instead of desktop files. These desktop files are
then embedded into the .so file. All the plugins will be in a kdeconnect/
directory, and those will be the ones to look for.
Note it doesn't drop the KService dependency as KIOCore is a KDE Connect
dependency as well.
REVIEW: 123042
2015-03-19 16:36:53 +01:00
Ashish Bansal
6b4d5be618
Used QSettings instead of KConfig in KdeConnectSettings
...
REVIEW: 122936
2015-03-15 19:31:01 -07:00