Commit graph

152 commits

Author SHA1 Message Date
Nicolas Fella
40c155f990 [app/mpris] Fix displaying times > 2h
We need to apply the correction for all hours >= 1, not just 1
2021-02-07 15:39:03 +00:00
Nicolas Fella
473b1f07c3 [app] Improve plugin config delegates
Add description and make them more consistent with other list items in
KDE.
2020-11-16 12:21:47 +00:00
Nicolas Fella
753b1a2b0c Constify variable 2020-11-16 12:21:47 +00:00
Bharadwaj Raju
cb51cb4adf Fix bug with use of drawer hiding when not wideScreen
Make drawer reappear when resized from narrow to wide screen if drawer
was closed in narrow mode.
2020-09-25 17:42:22 +05:30
Carl Schwan
5d9dad3d7e Remove hack introduced by previous commit
Instead of hardcoding font size, use default font size, this makes the
height of the Heading normal and don't overflow.
2020-09-19 14:59:35 +02:00
Carl Schwan
21f0227e06 Use Kirigami header in sidebar 2020-09-19 12:51:11 +00:00
Nicolas Fella
400c800deb [app] Add plugin settings page
Include a page that allows (de)selecting and configuring plugins

This is one of the last missing pieces for feature parity with the KCM.
2020-09-08 20:33:20 +02:00
Nicolas Fella
87db95b22f Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
Nicolas Fella
05a1978331 [app] Allow refreshing the device list
The Android app and the KCM allow forcing a refresh, which is useful sometimes. kdeconnect-app should have that too given we want to replace the KCM.
2020-08-07 12:56:47 +02:00
Nicolas Fella
5657547179 [app/volume] Use property setter 2020-08-07 00:08:31 +02:00
Nicolas Fella
198789e6fc Fix file dialog usage in app and plasmoid
fileDialog.open() does *not* block, so we need to move the sending to onAccepted. Not sure why I thought this ever worked.

BUG: 423975
2020-07-18 21:57:15 +00:00
Nicolas Fella
6cbaaa1a80 [app/mpris] Use property binding 2020-07-17 01:48:20 +02:00
Nicolas Fella
cefe6eec14 Add text to pair confirmation page 2020-07-17 01:31:16 +02:00
Nicolas Fella
a27d684f16 [app] Use subtitle in list item 2020-07-17 01:05:22 +02:00
Nicolas Fella
3a309cc72f [app] Port runcommand page to ScrollablePage 2020-07-12 02:25:38 +02:00
Nicolas Fella
151f829308 [app] Rework device page
To achive the proper scrolling behaviour it needs to be a ScrollablePage. In order to do that correctly the listview needs to be the direct content item of the page. Therefore we need to get rid of the loader and the various placeholder messages are parented to the listview.
2020-07-06 10:50:01 +00:00
Nicolas Fella
4531cebe18 [app] Add placeholder message around pair button 2020-07-05 20:00:29 +02:00
Jonah Brüchert
e5c6003399
app: Elide device name in global drawer 2020-06-22 18:58:32 +02:00
Nicolas Fella
c4f4f8d408 [app/mousepad] Prevent page change during input 2020-06-16 17:59:36 +02:00
Tobias Fella
ef965c34cf Port App to Kirigami.PlaceholderMessage 2020-05-02 00:18:22 +02:00
Nicolas Fella
5931de875e [app/volume] Elide sink name label 2020-03-15 22:09:31 +01:00
Nicolas Fella
bd7b4c305a Use Kirigami.ListSectionHeader 2020-02-06 16:43:44 +01:00
Yuri Chornoivan
f84b3c8c11 Fix localization of app and smsapp. Patch mainly by Victor Ryzhykh. 2019-12-21 09:59:36 +02:00
Nicolas Fella
f7296dfcf5 Don't highlight entries in device and plugin list 2019-10-15 20:19:40 +02:00
Nicolas Fella
f58a99e388 Fix background of device name on Plasma Mobile 2019-10-15 20:13:17 +02:00
Nicolas Fella
8d8989ea09 Coding style++ 2019-10-15 20:07:45 +02:00
Nicolas Fella
92ac51465f Simplify page pushing 2019-10-15 20:06:04 +02:00
Nicolas Fella
6c6689491e [app] Rework sidebar header 2019-07-21 18:40:16 +00:00
Nicolas Fella
749dcfa148 [app/mpris] Support non-seekable players 2019-07-17 21:19:53 +00:00
Rituka Patwal
d0cb028a84 add icons for pair, accept, reject 2019-03-26 12:30:04 +00:00
Nicolas Fella
3b8fedea1a Replace http GNU urls with https 2019-03-23 17:29:26 +01:00
Piyush Aggarwal
ad14953c21 add menu icons 2019-03-19 14:42:12 +00:00
Nicolas Fella
6a804faca8 Fix icon display on PM again 2019-03-08 22:24:38 +00:00
Nicolas Fella
f345b05838 Use ListView for plugins list 2019-02-21 17:13:28 +00:00
Nicolas Fella
afe8c95afa Give list headers a little padding 2019-02-10 22:57:28 +01:00
Nicolas Fella
2687ee5483 Set icon color 2019-02-09 00:17:07 +01:00
Nicolas Fella
e14b3dde32 Fix icon display on PM 2019-02-08 16:40:47 +00:00
Billy Laws
27f47ce8d4 Add a progress slider to mpris remote in app
Summary:
The progress slider can be mooved to seek through the song and
will display song length and current position on sides.

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17417
2018-12-18 02:50:54 +01:00
Billy Laws
05a34747f3 Add mute button with dynamic icon to MPRIS volume control
Summary:
The icon changes depending on the slider value and clicking it
will switch the volume between 0 and 100

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: apol, broulik, albertvaka, nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16962
2018-11-27 21:30:25 +00:00
Nicolas Fella
793c74e89e Show text when device is not reachable 2018-11-26 22:56:26 +01:00
Alex Kovrigin
1cee137dcb Align behaviour of the desktop app with the Android app
Summary: Now devices are shown same as in Android app, as in Kirigami app (kcapp)

Test Plan:
* Build kdeconnect, using the experimental version
* Try pairing, unpairing, connecting and disconnected devices.
* See the difference.

Reviewers: albertvaka, #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16935
2018-11-26 22:15:01 +01:00
Nicolas Fella
2de96e86ac Revert "Fix device name display in app"
This reverts commit 3865307619.
2018-11-26 15:51:28 +01:00
Nicolas Fella
00111e41e1 [app] Use new mouse icons 2018-11-22 01:27:11 +01:00
Nicolas Fella
3865307619 Fix device name display in app 2018-11-18 21:13:43 +01:00
Nicolas Fella
861a0441b5 Add RemoteKeyboard control to app
Summary:
Add textfield for remote keyboard input to app

{F6397375}

Test Plan: Write some text

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16747
2018-11-08 02:53:03 +01:00
Nicolas Fella
2f76d2143f [app] Add system volume control
Summary: Add a remote systemvolume plugin.

Test Plan:
Change volume via slider -> Volume on target changes
Change volume on target -> Slider changes

Mute via button -> Mute on target changes
Mute on target -> Button changes icon

Add/remove sink on host -> Sink is add/removed in list

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16667
2018-11-08 00:43:12 +01:00
Nicolas Fella
7c89338deb Add a little margin 2018-11-05 02:05:02 +01:00
Nicolas Fella
71ef6f6ba9 Add explicit edit mode to device name field
Summary: Similar to what we do in the KCM. Show the name in a label and make it editable per button.

Test Plan: Rename device

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16639
2018-11-05 01:56:25 +01:00
Nicolas Fella
2a8938e09f Show message when clicking add commands
Summary: It isn't obvious what happens when clicking the add commands action. Show a message.

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16549
2018-11-03 00:27:29 +01:00
Billy Laws
f15c21e56b Add support for sharing files from QML app
Summary: This allows you to a share a local file to a remote device using the qml app.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16614
2018-11-02 21:42:08 +01:00
Nicolas Fella
1359a9c059 Don't use deprecated ApplicationHeader
Summary:
Use the implicit header

This makes the Add commands action show up in the top bar on desktop

Desktop
{F6375830}

Mobile
{F6375831}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16548
2018-10-31 16:50:52 +01:00
Nicolas Fella
7307cd2709 [App] Always show drawer on Desktop
Summary: A drawer is not good UX on the desktop. Only collapse it when on mobile or window is very narrow

Test Plan:
{F6319485}
{F6319492}

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16122
2018-10-11 16:30:02 +02:00
Nicolas Fella
bd5c3ca460 [App] Show message when no device is found
Summary: {F6286990}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15784
2018-09-27 18:16:39 +02:00
Nicolas Fella
5cc205b5de [App] Show text if no commands are defined 2018-09-24 21:49:18 +02:00
Nicolas Fella
aaa95cf6db Revert accidental change 2018-08-03 02:42:21 +02:00
Nicolas Fella
81cc275f5b Fix NotificationListener Test 2018-08-03 02:40:34 +02:00
Nicolas Fella
e4385042eb Show icons in plugin list
Summary:
Show the plugin's icons in the list

Depends on D14567

{F6172885}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14571
2018-08-03 02:25:39 +02:00
Nicolas Fella
f094408171 Show message and hide controls if no player is available
Summary: Instead of showing empty controls show a message that no players are available

Test Plan: Use eyes

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12830
2018-07-12 15:22:38 +02:00
Nicolas Fella
17e1e1eced Enable running commands from app
Summary:
The RemotecommandsPlugin lacks a graphical frontend.

Inlcudes a Dbus Interface for fetching the commands and a Model exposing them to QML. For this I oriented on the NotificatonsPlugin.

Test Plan:
Open command list in app, check available commands, trigger some. Do same for CLI.
Activate edit action, check KCM opening on remote device, add command, check for new command in list

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13503
2018-06-20 08:23:15 +02:00
Nicolas Fella
51f3394a21 Do not disable paired devices in list
Summary: There is no reason to disable it. On Android we do the same

Test Plan: Click on paired device in list, correct Page opens

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13454
2018-06-12 14:27:29 +02:00
Nicolas Fella
cb470ce311 Enable accepting/rejecting pairing from app
Test Plan: Open app, request pairing from other device, accept/reject it

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13452
2018-06-12 14:25:26 +02:00
Aleix Pol
f171f76d74 Fix warning 2018-06-08 20:23:03 +02:00
Aleix Pol
db2e1af179 kcapp: Make both the device and find device page look similar
Use ScrollablePage or drop paddings
Don't add spacing between delegates
2018-06-08 20:22:54 +02:00
Aleix Pol
9bc9aba474 kcapp: Add a presentation mode
Just does presentation things, could do more.
2018-06-08 20:17:06 +02:00
Aleix Pol
b4b48b97d6 Port to QQC2 2018-06-08 01:58:50 +02:00
Aleix Pol
4e0588adc7 Include a kirigami header to the application
It helps and it looks less empty
2018-06-08 01:50:50 +02:00
Aleix Pol
61d3d6c1a1 Kirigami: Don't clear the stack when changing devices from finddevice page
It allows simpler navigation and it doesn't show the weird behavior we
used to have.
2018-06-08 01:49:35 +02:00
Nicolas Fella
1934585c41 Use title, album and artist in UI
Summary: Depends on D12546

Test Plan: Look at it

Reviewers: #kde_connect, apol, mtijink

Reviewed By: #kde_connect, mtijink

Subscribers: kdeconnect, mtijink, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12552
2018-05-12 18:04:44 +02:00
Nicolas Fella
aa5aeedf0a Fix another DBus connection in Kirigami app
Summary: When a DevicePage is created from FindDevicePage the device is not passed correctly, resulting in some device is null warnings. The pair button still does not work, but it seems to be another issue.

Test Plan: I could set the button text to the device id, so the device is passed correctly. The button still does not work as intended though.

Reviewers: #kde_connect

Subscribers: apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12506
2018-04-28 00:25:17 +02:00
Nicolas Fella
25cbf66e58 Fix DBus connection in Kirigami app
Summary: The device id was not properly passed to the interface factory, rendering the Mpris and mousepad UI useless

Test Plan: Mpris and mousepad UI in app are now actually filled with content

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12505
2018-04-25 14:47:56 +02:00
Aleix Pol
d42a65e621 Change how we specify devices 2017-05-18 11:45:28 +02:00
Aleix Pol
51c4eb68c6 Port to kirigami 2.0 2017-05-09 11:41:55 +02:00
Aleix Pol
d9e7f308c2 Show the announcedName in the qml app
Makes it possible to display it and modify it
Introduces a DBusProperty component that can be used if we don't want
to go through the QtDBus property generation hell.
2016-08-21 19:38:15 +02:00
Aleix Pol
b69247b4e5 Don't force the creation of a DeviceInterface for every pluginchecker
Create one per device and share it
2016-08-21 18:57:27 +02:00
Aleix Pol
d84a1a108b Mark the current section 2016-08-21 18:45:49 +02:00
Aleix Pol
bbf33f69a6 Use actions rather than visual elements 2016-08-21 17:55:13 +02:00
Aleix Pol
aef02c0cce Add findmyphone 2016-08-21 17:54:25 +02:00
Aleix Pol
64e0250d99 Properly case unpair 2016-08-21 17:54:15 +02:00
Aleix Pol
a89634c2b6 Don't show unavailable plugins 2016-08-21 17:53:58 +02:00
Aleix Pol
f654e75820 Improve how we handle the different plugin pages 2016-08-21 13:05:43 +02:00
Aleix Pol
70b6e5f804 Implement PluginChecker for plugin availability 2016-06-12 22:31:09 +02:00
Aleix Pol
fb8f468535 Unify naming with the Android client 2016-06-08 18:39:16 +02:00
Aleix Pol
e30a2d6bcf Move some of the options into the ContextDrawer 2016-06-08 18:38:48 +02:00
Aleix Pol
794e8c6904 Make the app work a bit more like the Android version 2016-06-08 18:37:57 +02:00
Aleix Pol
d6eb2d07bc Port the experimental application to kirigami 2016-06-06 01:21:37 +02:00
Aleix Pol
cc3f16ef34 Remove unneeded level of depth 2016-06-06 01:21:37 +02:00
Aleix Pol
d41eab2fae add i18n for consistency 2015-09-07 15:03:04 +02:00
Aleix Pol
a2aa2ab72b Fix qml touchpad interface
On release, forget about the last position
2015-08-07 15:02:36 +02:00
Martin Gräßlin
208cc573d2 [app] Add a title on the ApplicationWindow
Without a title, it's not possible to identify the window on Wayland.
E.g. KWin doesn't have a title for the application in Present Windows
or application switchers filtering it out.

REVIEW: 124417
2015-07-22 15:50:20 +02:00
Martin Gräßlin
56b6c019dc [app] Do not runtime depend on Qt 5.5
Reviewed-By: apol
2015-07-22 12:06:49 +02:00
Aleix Pol
be2a3252c2 Make it possible to lock the screen from KDE Connect
Connects to freedesktop ScreenSaver interface and un/locks it upon request.

REVIEW: 124170
2015-07-22 03:37:34 +02:00
Aleix Pol
058f7c7c90 Implement the touchpad forwarding into kcapp
This way the computer's cursor can be controlled from the device. Keyboard
is not yet implemented.
2015-07-22 03:21:28 +02:00
Aleix Pol
2b844e59da Improve app mpris interface 2015-07-19 22:20:47 +02:00
Aleix Pol
6d83827b18 Don't rely on Q_PROPERTY if we're inheriting QDBusAbstractInterfaceBase
See bug:
https://bugreports.qt.io/browse/QTBUG-46858
2015-06-25 04:08:00 +02:00
Aleix Pol
d6c779c938 improve navigation button usability 2015-06-24 00:36:57 +02:00
Aleix Pol
c7055cfe15 Adapt to changes in DevicesModel 2015-06-22 06:47:31 +02:00
Aleix Pol
9f4d837b22 Adapt to changes in DevicesModel 2015-06-22 06:45:18 +02:00
Aleix Pol
d741465473 Make it possible to go back from any page by having a back button on the toolbar 2015-06-19 07:22:00 +02:00
Aleix Pol
46b57003cd Display the device model section
This way we can differentiate between the different states
2015-06-19 07:14:02 +02:00
Aleix Pol
4654a61a5f Fix icon placing in the DeviceDelegate 2015-06-19 07:13:04 +02:00