Commit graph

105 commits

Author SHA1 Message Date
Aleix Pol
36bcade705 plasmoid: move plasmoid buttons into a menu
This way we get to see what they do together with the icon.
Removes some visual clutter as well.

Reviewed by Albert Vaca
2019-10-12 20:06:12 +02:00
Aleix Pol
8a919a8015 Remove clipboard integration on the plasmoid
It's redundant to the clipboard plugin and remote keyboard.
It clutters the UI.

Reviewed by Albert Vaca
2019-10-12 19:44:09 +02:00
Albert Vaca Cintora
db626fa4bd Hide the install buttons if you have already paired some device 2019-09-20 12:24:30 +02:00
Albert Vaca Cintora
7eeed141f0 Add a button to open the settings
If you already have kdeconnect on your phone, the call to action to install
it doesn't make sense.

This doesn't add a string because it reuses one that was already in the
plasmoid
2019-09-19 18:48:58 +02:00
Albert Vaca Cintora
9f8928513d Don't hide the plasmoid, otherwise the install buttons don't make sense 2019-09-19 18:39:45 +02:00
Nicolas Fella
6c40364490 Fix SMS icon in plasmoid 2019-08-15 19:22:29 +02:00
Aleix Pol
20f4ed3e9b sms: forgot to add the file 2019-07-21 20:13:10 +02:00
Aleix Pol
c17972881b sms: Added opening kdeconnect-sms on the plasmoid and indicator
Add a menu entry on the kdeconnect-indicator within devices' submenu that opens kdeconnect-sms.
Also add it in the plasmoid in the device delegate.
2019-07-21 18:30:41 +02:00
Matthijs Tijink
24eb0799f1 Show install instructions for Android when there are no devices 2019-07-20 18:21:41 +02:00
Matthijs Tijink
f8184f84bc Make more of the device name/battery show up in the plasmoid 2019-06-25 16:40:10 +00:00
Nicolas Fella
f9dee192b5 Completely hide plamoid in system tray if no device is connected 2019-06-20 16:22:43 +00:00
Nicolas Fella
1999a0b49e Allow to share multiple files from plasmoid 2019-06-15 18:10:53 +02:00
Nicolas Fella
5a0b82dd6d Fix whitespace 2019-06-15 17:44:27 +02:00
Nicolas Fella
a6dd1f5465 Translate file dialog title 2019-06-15 17:44:11 +02:00
Nicolas Fella
3b8fedea1a Replace http GNU urls with https 2019-03-23 17:29:26 +01:00
Aleix Pol
d650faaa4f Fix warning 2019-01-31 16:38:21 +01:00
Simon Redman
bafbc344b9 Implement Drag n Drop file transfer on the plasmoid
Summary:
A DropArea has been added to the ListItem representing a device in the
plasmoid based on what is done in the Quickshare plasmoid. This enables
Drag n Drop of files onto a section of the plasmoid to transfer files.

The DropArea has the size of the ListItem which is a rectangle
including the title of the device down to the button to share text.
Additionally, there is a tooltip area covering the DropArea to indicate
that it is possible to drop a file to send it to the device. Multiple files
can be sent at once.

Ref T8288

Test Plan: Drag and Drop one or many files onto the widget, the files should be transferred to the connected device.

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Maniphest Tasks: T8288

Differential Revision: https://phabricator.kde.org/D17611
2019-01-02 10:26:40 -07:00
Nicolas Fella
99e335ede2 Revert "Fix devicename in Plasmoid"
This reverts commit e029c61935.
2018-11-26 15:50:44 +01:00
Nicolas Fella
e029c61935 Fix devicename in Plasmoid 2018-11-22 16:45:53 +01:00
Billy Laws
9fc55c72f0 Use plasma TextArea for sharing text in plasmoid
Summary:
This also fixes a bug where the box could be too small.
BUG: 400862

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, sredman, apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16782
2018-11-09 19:07:10 +00:00
Nicolas Fella
952da637b0 Share RemoteKeyboard implementation
Summary: Extract RemoteKeyboard.qml into declarativeplugin to be able to use it from both plasmoid and app without code duplication

Reviewers: #kde_connect, hkaelberer, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect, mtijink, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12670
2018-11-08 02:20:34 +01:00
Billy Laws
061d415f83 Add support for sharing text from plasmoid
Summary:
This allows you to enter text in the plasmoid and it be sent
to the connected device.

Reviewers: #vdg, #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16696
2018-11-07 21:52:53 +00:00
Nicolas Fella
fb2817e3f3 Add missing file 2018-11-02 22:13:36 +01:00
Nicolas Fella
56ebd3f889 Fix with calculation 2018-11-02 15:47:52 +01:00
Nicolas Fella
cefc743307 Only show addCommand button when adding commands is supported 2018-11-02 15:44:14 +01:00
Nicolas Fella
e0766ba532 Align buttons 2018-11-02 15:38:52 +01:00
Billy Laws
eaea0ab667 Add support for sharing files from plasmoid
Summary: This allows you to share a local file on your device to a remote device running kde connect.

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16552
2018-11-01 18:33:39 +01:00
Billy Laws
c546c77040 Add a button to open command setup menu in plasmoid
Summary: This patch adds a button to the plasmoid to allow adding commands by opening the menu on the remote device.

Reviewers: #vdg, nicolasfella, albertvaka

Reviewed By: nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16535
2018-10-30 23:42:56 +01:00
Yuri Chornoivan
5fe74ce041 Fix minor EBN issues and typos 2018-10-07 21:23:20 +03:00
Nicolas Fella
d7d2917e00 Use new icon for clearing notifications
Summary: {F6303876}

Reviewers: #kde_connect, ngraham, thsurrel

Reviewed By: ngraham

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15948
2018-10-04 19:25:53 +02:00
Nicolas Fella
fc4d4e7685 Enable running commands from the plasmoid
Summary: {F5926667}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13660
2018-07-27 08:11:03 +02:00
Thomas Surrel
5ab26096a2 Change the 'Dismiss all notifications' icon
Summary: This matches the KDE notification icon.

Reviewers: apol

Reviewed By: apol

Subscribers: abetts, Fuchs, apol, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D13534
2018-06-14 17:45:01 +02:00
Nicolas Fella
4d8863bacc Start cleaning up RemoteKeyboard QML code
Summary:
The code for visually disabling the input field is not needed any more since the field is completely hidden when not needed. Also drop the custom available property from the text field.

More cleanups will follow. My long-term goal is to reuse the code in the app to enable remote keyboard input on non-Plasma DEs

Test Plan: (De)activate the remote keyboard on Android.

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12669
2018-05-09 01:15:14 +02:00
Matthijs Tijink
749351ec64 Add tooltips to the "dismiss" buttons for notifications
Summary: It also makes it clearer that the top line is not a notification, but a header.

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: #kde_connect

Differential Revision: https://phabricator.kde.org/D11646
2018-03-24 16:40:09 +01:00
Matthijs Tijink
dbce29a66f Revert "Add a refresh button to the plasmoid"
This reverts commit ca4b4227ce.
2018-03-21 17:36:24 +01:00
Matthijs Tijink
ca4b4227ce Add a refresh button to the plasmoid
Summary: This adds a refresh button to the plasmoid if no device is connected.

Test Plan: Refreshing works, and the button only appears when no devices are connected.

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: apol, nicolasfella, #kde_connect

Differential Revision: https://phabricator.kde.org/D11501
2018-03-20 19:53:13 +01:00
Kai Uwe Broulik
0b7578a5e2 Remove custom compact representation
It doesn't do anything special

Differential Revision: https://phabricator.kde.org/D11259
2018-03-12 12:29:15 +01:00
Kai Uwe Broulik
1c3a45fd95 Get rid of ProcessRunner
Use KCMShell singleton in kquickcontrolsaddons
Also while at it honor kiosk restriction

Differential Revision: https://phabricator.kde.org/D9759
2018-01-09 16:33:02 +01:00
Nicolas Fella
5d4821fb9c Only show notification title in plasmoid if different to app name
Summary: Like we do for the notifications in the plugin already. Passing the title and text separately to the plasmoid could be useful later as well.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D7457
2017-08-22 18:18:34 +02:00
Nicolas Fella
66e5eefe20 Gave plasmoid some love
Summary:
Make the plasmoid content transparent
Include battery info in header
Only show remotekeyboard input if available
Make header always centered

before:
{F3820966}

after:
{F3820965}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: jeanv, albertvaka, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6943
2017-07-27 17:15:07 +02:00
Fabian Vogt
0667c6556f Merge branch '1.x' 2017-07-12 11:37:41 +02:00
Fabian Vogt
5641d818dc Treat device names as plaintext, not rich text
Summary:
Notifications, QML Text and QLabel accept a HTML subset,
which does not make sense for device names.

BUG: 382243

Test Plan:
Sent a pair request and accepted it, device name
now shown as plain text everywhere.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: #kde_connect

Differential Revision: https://phabricator.kde.org/D6640
2017-07-12 11:33:21 +02:00
Julian Wolff
8aaa18848e show icon and reply toolbutton in plasmoid
Summary:
Show an icon for each notification which has an icon.

	Show a toolbutton which can be used to reply to notifications which offer a quick reply.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka

Maniphest Tasks: T4674, T4658

Differential Revision: https://phabricator.kde.org/D6058
2017-06-01 16:17:45 +02:00
Kai Uwe Broulik
e9af490553 Merge branch '1.x' 2017-02-07 22:03:15 +01:00
Kai Uwe Broulik
54d43cebcb [Applet] Make "no device available" heading consistent with other applets
Also ensure that it wraps instead of overflowing in case the text gets too long on translated system.

Differential Revision: https://phabricator.kde.org/D4478
2017-02-07 22:02:38 +01:00
Holger Kaelberer
30cffbd96e Add remotekeyboard plugin
BUG: 370919
REVIEW: 129727
2017-01-23 09:08:27 +01:00
Aleix Pol
a164983b6f Revert "kdeconnect-kde: Add remotekeyboard plugin"
This reverts commit 040ad7357b.

Sorry, didn't mean to push that myself ^^'
2017-01-11 17:20:22 +01:00
Holger Kaelberer
040ad7357b kdeconnect-kde: Add remotekeyboard plugin
Allow to inject keypress events to remote peers (most notably Android devices)

Notes / open issues / possible improvements:

- For the json-payload I used the syntax of the key-events as sent by mousepad-plugin with the addition of a "sendAck"-flag. If "sendAck" is set to true the remote peer should echo a key-event if it could be handled, thus allowing the local client to find out whether the key was accepted. For performance reasons, it's allowed to send multi-char strings in the "key" property (performs much better if you send a whole string via "echo '...' |  kdeconnect-cli ..." e.g.)

- kdeconnect-cli: For now takes a string and transforms it into single key-events for visible characters only. In a first implementation I used a kbhit() helper that used termios.h to catch and relay keypresses interactively (including some special-events), which was not optimal. A better approch might be to use linux input-api directly. Would this be an option regarding cross-platform compatibility or can I assume to develop for Linux only? Being a command-line guy, I'd really like to have a fully featured kdeconnect-cli interface ;-)

- Factor out the Qt::Key-to-internal keymap to some core-helper because it corresponds to the mapping in the mousepad-plugin?

- The plasmoid is not perfect as it is: A single line containing a non-echoing TextField (i.e. it eats all the KeyPress events), and only ack-ed keypress-packets from the peer device are injected if they contain visible keys. Advantage: the user sees whether his key-presses are accepted by the peer device. Disadvantage: The echoed text does not correspond 1:1 to what is shown on the peer's display, user might be confused when typing without success. I played around with different variations each of which with its proper shortcomings:
1. An echoing Textfield for typing: Has the advantage that the user can directly see what he is typing, which makes interaction in the typing field easier, BUT messes up interaction if the Editor on the peer is changed silently and does not notify the user if his keypresses are not handled by the peer.
2. A non-echoing TextField for typing PLUS a readonly one for printing visible echoed keys. Disadvantage: same as for the previous one and uses more space on the plasmoid.
Comments? Ideas?

REVIEW: 129727
BUG: 370919
2017-01-10 21:12:42 +01:00
Aleix Pol
e9c835f477 Prefer properties to functions 2016-11-23 19:45:35 +01:00
Aleix Pol
eb31c1e152 Make it possible to toggle full notification contents by clicking on it
REVIEW: 129087
2016-10-04 01:12:04 +02:00