Commit graph

67 commits

Author SHA1 Message Date
Simon Redman
d742684d21 Set view to track new elements as they are added
Summary: Set the currentIndex of the ConversationDisplay to show the newest messages by default, but stay where the user positioned it if viewing older messages

Test Plan:
Launch SMS App:
 - Select conversation
 - View should show the most recent messages
 - Receive new message
 - View should scroll to show the new message
 - Scroll up to view older messages
 - Receive new message
 - View should continue to show older messages and not scroll to the bottom

Reviewers: nicolasfella

Reviewed By: nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D15562
2018-09-16 15:52:44 -06:00
Nicolas Fella
372f23b103 [SMS app] Mask regex special characters in search box
Summary: QSortFilterProxyModel filters based on a regex. When the user inserts regex special characters things go bad.

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, broulik, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14642
2018-08-06 13:07:23 +02:00
Nicolas Fella
3437fa5a39 [SMS app] Search case insensitive 2018-08-06 00:32:12 +02:00
Nicolas Fella
5f63f78f77 Show new messages on the bottom
Summary: Like every messaging app I know does

Test Plan: Compare message order with phone

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14638
2018-08-06 00:22:18 +02:00
Nicolas Fella
21b52d7dcf Refine SMS conversation view
Summary: Use components from Kaidan messenger

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14635
2018-08-06 00:09:46 +02:00
Nicolas Fella
a1b5c4e2d9 Display Name and message in separate line
Summary:
Before:
{F6176746}

After:
{F6176749}

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14636
2018-08-06 00:05:10 +02:00
Nicolas Fella
367f2e08a9 Clear SMS input field on send 2018-08-04 21:13:09 +02:00
Aleix Pol
31e93ef7bf (WIP) Upgrade Telephony plugin to read SMS history (KDE side)
Summary:
For real usecases of SMS support, we will almost always need access to the message history in some way

Specifically resolve T8338

Incidentally resolve T6651 since Telephony shall no longer create a notification

Test Plan:
Setup:
- Build corresponding Android-side diff (D11698)
- Build this diff

Step 1: Does anything at all work?
- Put a breakpoint in the handleBatchMessages method of the telephony plugin, ideally after constructing a Message object
- Use DBus to poke /modules/kdeconnect/devices/<deviceID>/telephony.requestAllConversations()
- Verify that the constructed Message is one you sent or received and that it is the most recent in the corresponding conversation

Step 2: DBus
- Open the Interface org.kde.kdeconnect.device.conversations of /modules/kdeconnect/devices/<deviceId>
- Poke activeConversations and verify an empty array is returned
- Poke requestAllConversationThreads
- Poke activeConversations and verify that a list of numbers has been returned. These are conversationIds
- Use a conversationId to call getFirstFromConversation
  - Verify that the returned Message object is one which you recognize
  - Note that if the message is an MMS it will be blank and meaningless. Try a different conversationId. MMS support "coming soon!"

Step 3: SMS App
- Use ccmake (or similar) to set SMSAPP_ENABLE to ON
- Build the project
- Run ./bin/kdeconnect-sms
- Verify that the app shows a list of everyone you have an SMS conversation with (MMS messages are stripped out)
  - If you have the Contacts plugin working, verify that most contacts have their name and photo instead of their phone number

Reviewers: #kde_connect, nicolasfella, apol

Reviewed By: #kde_connect, nicolasfella, apol

Subscribers: andyholmes, apol, nicolasfella, #kde_connect

Tags: #kde_connect

Maniphest Tasks: T8338, T6651

Differential Revision: https://phabricator.kde.org/D11854
2018-06-09 13:35:26 -06:00
Aleix Pol
8dba3898e5 Move the dummy conversation model to c++ 2018-05-16 03:44:23 +02:00
Aleix Pol
ea69141d2e SMS App: Note that there's no device available on the combo
Fixes T8342
2018-04-08 02:40:40 +02:00
Aleix Pol
cfc51e0814 SMS App: Don't allow sending sms when there's no device selected
Fixes T8343
2018-04-08 02:36:05 +02:00
Aleix Pol
f20cb63e53 SMS App: remove certain cruft and warnings 2018-04-08 02:34:26 +02:00
Aleix Pol
11071b4894 SMS app: Initialize the device combo when devices appear
Solves T8344
2018-04-08 02:08:12 +02:00
Aleix Pol
fdb03afb4d Send an SMS when the text field is accepted
Solves T8339
2018-04-08 02:08:12 +02:00
Simon Redman
bf327e5b8c Reduce dependencies of smsapp to kirigami 2.2 2018-03-27 17:10:10 +02:00
Aleix Pol
bee6c4a8be Use KPeople API that exists 2018-03-25 22:21:39 +02:00
Aleix Pol
c863feef58 Optionally include sms app
Creates a tiny messaging app that uses KPeople to query the contacts and
KDE connect telephony plugins to send plugins.
To be ready, still needs some work on the contacts sync side and some
messages history would be nice.
2018-03-25 20:48:38 +02:00