tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1751 commits 81 branches 117 tags 12 MiB
Commit graph

19 commits

Author SHA1 Message Date
Jean Vincent
c864267f04 Replace Q_FOREACH with C++11 range-for 
Summary:
The use of Q_FOREACH is advised against (https://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH) since Qt 5.7 and will eventually be removed from Qt.

I replaced all occurrences with the range-for loop introduced in C++11 (except for the one in daemon.cpp in deviceIdByName which might have a bug / typo in it).

I added const to the container or casted it with qAsConst when appropriate to avoid unnecessary copies.

(This is my first submission. I did all the unit tests, and they all passed but I don't know how to show it here.)

Reviewers: #kde_connect, nicolasfella, apol

Reviewed By: #kde_connect, nicolasfella, apol

Subscribers: albertvaka, apol, nicolasfella

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6724
 2017-07-21 09:57:19 +02:00
Albert Vaca
60331ccbf1 Clazy says all this QStringLiteral and QLatin1String were missing/wrong 2016-11-26 16:21:29 +01:00
Albert Vaca
a1340c8042 Fixed old style connects with clazy 2016-11-26 15:14:19 +01:00
Albert Vaca
e880e14ed5 Preffer Q_FOREACH to foreach 2016-06-21 14:50:17 +02:00
Elvis Angelaccio
1290296e5c Don't leak QMenu in fileitemactionplugin 
REVIEW: 128091
 2016-06-03 20:30:29 +02:00
Albert Vaca
4477ff29d9 Fixed Dolphin's extension 
It was not working because it used the model (that is now async) instead
of dbus interfaces.

CCMAIL: aleixpol@kde.org
 2015-03-21 22:50:00 -07:00
Àlex Fiestas
0c0cfb711d Port fileitemactionplugin free of KDELibs4Support 2014-09-23 19:33:03 +02:00
Àlex Fiestas
677f650216 Removed K_EXPORT_PLUGIN, no longer needed 
With kf5 this is not longer needed. removing it!
 2014-09-22 02:40:51 +02:00
Àlex Fiestas
101c741266 Make sendfileitemaction ready for qCDebug 
We are not using debug statements in this pluging, but for when we do
debugging will be ready.
 2014-09-22 00:15:36 +02:00
Àlex Fiestas
53830bfa68 Use QUrl instead of KUrl in fileitemactionplugin 
Again, straight forward port, simple replace works.
 2014-09-21 22:22:47 +02:00
Àlex Fiestas
42269a9dda Port from KIcon to QIcon 
Executed kcm and some notifications, icons are still shown.
 2014-09-13 01:04:48 +02:00
Albert Vaca
a303b73238 Merge branch 'master' into frameworks 
Conflicts:
	cli/kdeconnect-cli.cpp
	core/CMakeLists.txt
	plasmoid/package/contents/ui/FullRepresentation.qml
	plugins/ping/pingplugin.cpp
 2014-07-01 23:59:38 +02:00
Aleix Pol
59cab0dc06 When trying to send file, actually tell the plugin to send the file 
Works wonderfully on new apk's. \o/

Reviewed by Albert Vaca
 2014-06-27 16:46:49 +02:00
Aleix Pol
b618a64f51 Merge remote-tracking branch 'origin/master' into frameworks 
Conflicts:
	cli/kdeconnect-cli.cpp
 2014-06-18 02:46:14 +02:00
Albert Vaca
f12a3768b4 Translated sendfileitemaction and the CLI 2014-06-17 22:21:58 +02:00
Aleix Pol
a1a560c469 First approach to a KF5 port of KDE Connect 
Ported using KDELibs4Support, for a smaller delta, so we can keep
developing on master until we decide not to.

At the moment, it builds and installs but tests don't pass because
of a QCA2 initialization problem I didn't manage to debug yet.

CCMAIL: kdeconnect@kde.org
 2014-06-16 20:02:07 +02:00
Aleix Pol
9459001fbe Use the icon for the device, in the file item actions 
This way, we have visual information of what type of file we're sending it
to.
 2014-06-14 19:42:34 +02:00
Aleix Pol
61fcf3f4ba Improve exposed actions 
If there's no paired devices, show nothing.
If there's one, just one action to send directly from.
If there's more, then show the submenu
 2014-06-14 19:42:33 +02:00
Aleix Pol
a2e6632759 Introduce a fileitemactionplugin 
This way we can send files to all devices.
 2014-06-14 19:42:33 +02:00