Rob Emery
811542cf84
This thows an error in kdeconnectd
...
qt.dbus.integration: QDBusConnection: couldn't handle call to getLinkProviders, no slot matched
but we are getting nearer
2024-11-03 22:26:06 +01:00
Rob Emery
01897942a0
Trying to get end-to-end of the link providers out so we can pass back
...
lists
2024-11-03 22:26:05 +01:00
Albert Vaca Cintora
475a4c2ca8
Add missing QQuickStyle::setStyle calls
...
Calls `QQuickStyle::setStyle("breeze")` everywhere we were
calling `QApplication::setStyle("org.kde.desktop")`.
2024-10-18 11:38:57 +00:00
Albert Astals Cid
3242a5bebc
Fix QML widget being too wide in hidpi
...
We don't need to multiply by the devicePixelRatio here
2024-10-13 12:49:24 +00:00
Rob Emery
83536d1684
Using KColorSchemeManager::KColorSchemeManager is deprecated
2024-10-10 08:51:57 +01:00
Albert Astals Cid
c0036d2d9b
Use QML ListView in KCM
2024-10-06 21:40:39 +00:00
Albert Vaca Cintora
02ff5bd6c5
Handle dbus errors in setWhenAvailable
2024-09-09 13:31:31 +02:00
Albert Vaca Cintora
af4ce1c33c
Show pairing keys everywhere and always shorten to 8 chars
...
The previous key was 64 freakin characters long which made it more prone
to being ignored, and thus less secure.
2024-05-18 20:26:48 +00:00
Aleix Pol
a0d93fa537
Make sure we are not using deprecated APIs
...
Bumps the deprecation values in line with the APIs we depend on.
2024-04-27 17:47:29 +02:00
Nicolas Fella
1785160049
[kcm] Use correct KCModule constructor
...
BUG: 482199
CCBUG: 478091
2024-03-06 22:03:55 +00:00
Laurent Montel
b61f32262e
GIT_SILENT: Adapt to KConfigGroup name officially being a QString type
2023-11-06 20:05:39 +01:00
Albert Vaca Cintora
5cc2043c35
Update old-style connect/disconnect where possible
2023-08-08 22:51:30 +02:00
Albert Vaca Cintora
a467247f08
Only use proxy signals for Q_PROPERTY NOTIFY
...
In other cases we can just connect to the signal from the parent class
2023-08-08 20:24:22 +02:00
Alexander Lohnau
6fbecf28da
Remove trailing / for KPluginMetaData::findPlugins
...
This is not needed and pretty much all usages of this method don't do it too
2023-07-31 06:39:08 +00:00
Alexander Lohnau
dd5e61ab0a
KdeConnectKcm: Do not make generated UI class instance a ptr
2023-07-30 07:27:45 +00:00
Albert Vaca Cintora
bd72602875
Move setWhenAvailable from dbusinterfaces to dbushelpers
2023-07-23 16:53:57 +02:00
Alexander Lohnau
7d66b07ef7
Remove unused createId methods
2023-07-22 19:12:33 +02:00
Albert Vaca Cintora
6c1b81a384
Use nullptr instead of 0
2023-07-20 18:26:24 +02:00
Alexander Lohnau
52b6d57942
Qt6 build fixes in plugins and KCM
2023-07-20 11:15:46 +03:00
Albert Vaca Cintora
9c87393b28
clang-format pass
2023-07-16 16:20:34 +02:00
Albert Vaca Cintora
981796ed66
Fix KCM reloading the plugins N times when a device was selcted
...
Every time a device is selected, `pluginsConfigChanged` would trigger even
if no plugins actually changed (there's a boolean to distinghish that on
the signal that we were ignoring). On top of that, we were connecting to
the signal again each time we selected a device, causing this bug to
trigger N+1 times every time a device was selected.
This is bad because `pluginsConfigChanged` would reload all the plugins,
which for some plugins even implies network calls to the connected device.
2023-06-24 17:45:48 +00:00
Albert Vaca Cintora
064ddfa3fe
Refactor PairingHandler
...
We now have a single PairingHandler for all types of links.
The implementation now is more aligned with the one for Android.
2023-06-02 16:38:52 +00:00
Nicolas Fella
2ce55df1ba
Remove unused KPluginInfo include
2022-12-06 19:44:15 +01:00
Nicolas Fella
a918ffc0cb
Add and make use of ECM's clang-format integration
2022-09-11 23:21:58 +00:00
Alexander Lohnau
e365e1b35c
Port from KPluginSelector to new KPluginWidget class
...
Task: https://phabricator.kde.org/T12265
2021-12-15 08:24:22 +01:00
Alexander Lohnau
fd681e62ab
Port deprecated KCMultiDialog methods & embed json metadata in KCM
...
This KCM will have to get installed installed in the new plasma namespace eventually.
But considering that this app is part of the release service, we should not
depend on changes in a not yet released Plasma version.
Task: https://phabricator.kde.org/T14501
2021-12-15 08:24:22 +01:00
Piyush Aggarwal
82c7a8080d
add KColorSchemeManager instance to install auto dark theme on Windows
2021-06-13 13:51:28 +05:30
Piyush Aggarwal
7f7f0d8992
ensure kiconloader is instantiated when bringing up settings
2021-06-11 23:45:14 +05:30
Piyush Aggarwal
02ed0699ff
set app style to breeze explicitly on Windows
2021-06-03 03:15:35 +05:30
Albert Vaca Cintora
e7518493df
Add a verification key that's displayed when pairing
...
The key is a sha256 of both devices' certificates. Both should generate the
same key, so hey user can check they are pairing against the right device.
Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
2020-11-26 11:28:49 +01:00
Nicolas Fella
8b82a30d40
CMake cleanup
...
Remove all include_directory calls
They are either unnecessary or can be done better
2020-11-16 12:21:07 +00:00
Nicolas Fella
f2d97193eb
Remove defunct calls to KAboutData::pluginData
...
The data is never registered so they always return nullptr. We might as well not pass it.
2020-10-31 19:58:05 +00:00
Nicolas Fella
87db95b22f
Convert license headers to SPDX expressions
2020-08-17 09:48:10 +00:00
Nicolas Fella
3b8fedea1a
Replace http GNU urls with https
2019-03-23 17:29:26 +01:00
Nicolas Fella
1f1462e813
Remove unused includes
2019-02-28 14:11:23 +01:00
Nicolas Fella
fc4da13d64
Add context object
2019-02-28 14:08:17 +01:00
Nicolas Fella
68d0c5d143
Do not require Frameworks 5.45
...
Summary: Ifdef for old KF5 as discussed in D11684.
Test Plan: Can still use feature when above 5.45
Reviewers: apol
Reviewed By: apol
Subscribers: kdeconnect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D12810
2018-05-10 19:48:40 +02:00
Aleix Pol
dd031d3deb
Show the KCM with the run commands open when a setup packet is received
...
Summary: Depends on D11683.
Test Plan: Tested the `kcmshell kdeconnect --args mydeviceid:kdeconnect_runcommand` works
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: nicolasfella
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11684
2018-04-19 03:03:42 +02:00
Albert Vaca
84bba9429f
Merge branch 'master' into 1.x
...
# Conflicts:
# core/backends/lan/downloadjob.cpp
# core/backends/lan/downloadjob.h
# core/filetransferjob.cpp
# core/filetransferjob.h
# plugins/notifications/sendreplydialog.cpp
# plugins/notifications/sendreplydialog.h
# plugins/telephony/sendsmsdialog.cpp
# plugins/telephony/sendsmsdialog.h
2017-09-03 22:05:54 +02:00
Jean Vincent
72535ecf48
Make member variable names, & placement and * placement more coherent
...
Summary:
Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
Place all references and pointers on the side of the type since it is the majority.
Basically:
- mFoo -> m_foo
- foo -> m_foo (if it is a member variable)
- Type &ref -> Type& ref
- Type *ptr -> Type* ptr
Reviewers: #kde_connect, nicolasfella, albertvaka
Reviewed By: #kde_connect, nicolasfella, albertvaka
Subscribers: albertvaka, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D7312
2017-09-03 21:45:08 +02:00
Albert Vaca
a18f91ccc1
Swapped labels
2017-08-02 02:59:41 +02:00
Aleix Pol
209e3e2842
Reflect property change when unpairing
...
There's no pairStatusChanged when the device is not connected to
anything (be it because it's unreachable at the moment).
2017-07-14 01:01:15 +02:00
Aleix Pol
f65392ca6b
Expose pair requests on the KCM
2017-02-20 21:00:26 +01:00
Aleix Pol
b947ef6b60
Use asynchronous calls to the device interface when possible
...
Summary:
Use setWhenAvailable for isTrusted calls
Just deal with the pairing buttons state only once.
Unify semantics (paired vs trusted)
Reviewers: albertvaka, #kde_connect
Reviewed By: albertvaka, #kde_connect
Differential Revision: https://phabricator.kde.org/D4125
2017-01-13 18:36:43 +01:00
Aleix Pol
c822ef8104
Set the device's announcedName when it's available
...
No need to block on it
2017-01-13 17:48:37 +01:00
Aleix Pol
41fd3d8dd8
Stop enforcing maximum size
2016-11-28 15:32:35 +01:00
Albert Vaca
60331ccbf1
Clazy says all this QStringLiteral and QLatin1String were missing/wrong
2016-11-26 16:21:29 +01:00
Albert Vaca
a1340c8042
Fixed old style connects with clazy
2016-11-26 15:14:19 +01:00
Kai Uwe Broulik
6f7c419baa
Merge branch '1.x'
2016-09-10 22:53:37 +02:00
Albert Vaca
3c0f3b9814
Removed unsupported plugins section from KCM
2016-09-06 10:53:19 +02:00