tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4020 commits 81 branches 117 tags 12 MiB
Commit graph

39 commits

Author SHA1 Message Date
Alexander Lohnau
7d685c94cc Discard unused params more elegantly 
By commenting out the var nime, we get compile-time checks

Also, we can omit them for slots
 2023-07-28 16:18:59 +02:00
Albert Vaca Cintora
dd4831f823 Add missing NOTIFY to properties 2023-07-22 20:09:46 +02:00
Nicolas Fella
a918ffc0cb Add and make use of ECM's clang-format integration 2022-09-11 23:21:58 +00:00
Laurent Montel
ba69e4a05a Remove extra ';' 2022-06-23 06:47:52 +02:00
Nicolas Fella
87db95b22f Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
Aleix Pol
c17972881b sms: Added opening kdeconnect-sms on the plasmoid and indicator 
Add a menu entry on the kdeconnect-indicator within devices' submenu that opens kdeconnect-sms.
Also add it in the plasmoid in the device delegate.
 2019-07-21 18:30:41 +02:00
Nicolas Fella
d4026861ab Clean up includes 2019-04-30 19:03:24 +02:00
Nicolas Fella
5e5275ffb8 Revert "QtGui is not needed in interfaces" 
It breaks icons in several places

This reverts commit 2538a6a3e6.
 2019-03-24 17:12:42 +01:00
Nicolas Fella
3b8fedea1a Replace http GNU urls with https 2019-03-23 17:29:26 +01:00
Nicolas Fella
2538a6a3e6 QtGui is not needed in interfaces 2019-03-13 01:23:16 +01:00
Aleix Pol
dd031d3deb Show the KCM with the run commands open when a setup packet is received 
Summary: Depends on D11683.

Test Plan: Tested the `kcmshell kdeconnect --args mydeviceid:kdeconnect_runcommand` works

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D11684
 2018-04-19 03:03:42 +02:00
Jean Vincent
72535ecf48 Make member variable names, & placement and * placement more coherent 
Summary:
Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
Place all references and pointers on the side of the type since it is the majority.

Basically:
 - mFoo -> m_foo
 - foo -> m_foo (if it is a member variable)
 - Type &ref -> Type& ref
 - Type *ptr -> Type* ptr

Reviewers: #kde_connect, nicolasfella, albertvaka

Reviewed By: #kde_connect, nicolasfella, albertvaka

Subscribers: albertvaka, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D7312
 2017-09-03 21:45:08 +02:00
Aleix Pol
07b191ca71 Remove unused method 2017-01-13 17:48:37 +01:00
Aleix Pol
b67b0e6c2c First approach to a tool that sits on the system tray 
Hopefully will better integrate in all platforms
 2016-11-23 19:45:35 +01:00
Aleix Pol
596e4484f4 Clean up use of virtual and override keywords 
Only use virtual when actually virtual, to override just use override.
 2016-06-20 19:22:29 +02:00
Aleix Pol
e2c89794d9 Prefer Q_ENUM to Q_ENUMS 2016-06-08 18:39:31 +02:00
David Kahles
3103bd0c5a Improve filtering of devices in the DevicesModel 
We need to remove devices from the model if the filter doesn't match, to
prevent listing disconnected devices in the plasmoid.

REVIEW: 127610
 2016-04-08 17:01:33 +02:00
Aleix Pol
d58f6314fe run Clang Modernize 
Minus the auto change
 2015-09-08 10:47:37 +02:00
Boris Egorov
1924173df2 Fix various krazy2 warnings 
Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes], [normalize],
[postfixop], [spelling]

See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html
for details.

SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize

REVIEW: 124857
 2015-08-21 22:38:54 +06:00
Lamarque V. Souza
208c11de1a Fix battery widget not appearing after kdeconnectd restarts. 
I also added a workaround to prevent memory leak described in
0f38eb34a4.

REVIEW: 124361
 2015-07-17 00:40:45 -03:00
Aleix Pol
43451d6ae1 Simplify Device::id management 
Removes the id->row mapping. It was broken as the indices weren't updated
when a row was added or removed.
Stop exposing Device::id through dbus, just store it in the interface
class.
* It's redundant as it's part of the interface definition
* If we keep it it will save us quite some dbus round-trips
* It will be reliable, as nowadays id() sometimes QString() if the dbus
connection is invalid.

REVIEW: 124158
 2015-06-24 20:57:17 +02:00
Albert Vaca
9fa8538bf1 Removed some assertions that could not be true if using the model filter 
Also fixed ugly hack where the KCM updated the model
 2015-06-21 20:20:40 -07:00
Albert Vaca
fd65570487 Some TODOs done :) 
Also renamed the Status flags enum to make it more understandable
 2015-06-21 19:42:16 -07:00
Aleix Pol
6ddac08978 Introduce a device Role 
REVIEW: 124067
 2015-06-11 16:47:53 +02:00
Aleix Pol
05491442e6 Make it possible to fetch the device from the DevicesModel from QML 
Uses the row as the argument instead of the QModelIndex.
Defines the Device type so it can be used from QML.

REVIEW: 123361
 2015-04-15 13:00:23 +02:00
Aleix Pol
fda4556dfc Take into account the integrated filter in the DevicesModel 2015-03-16 02:31:59 +01:00
Aleix Pol
6fe7a9b158 Make it possible for the DevicesModel to react to device name changes 2015-03-14 04:28:54 +01:00
Aleix Pol
b99cba1949 Make the DevicesModel::deviceAdded code more robust 
If deviceAdded is reported even though it's already in the model, don't
add it twice.
 2015-03-14 03:40:01 +01:00
Aleix Pol
a4ccc93518 Make the devices list a vector 
It's the suggested data type to use according to:
https://marcmutz.wordpress.com/effective-qt/containers/
 2015-03-14 03:25:14 +01:00
Aleix Pol
7af7dbdc2f Improve DevicesModel::receivedDeviceList 
Make the population asynchronous on dbus. Wait for the device list and
don't populate it until it's ready. There's no reason to block.
Don't emit after endInsertRows. It doesn't help, as the views will have
already refreshed.
 2015-03-14 02:30:35 +01:00
Albert Vaca
6cc6d287fc Merge branch 'master' into frameworks 
Conflicts:
	cli/kdeconnect-cli.cpp
	core/filetransferjob.cpp
	core/filetransferjob.h
	interfaces/notificationsmodel.cpp
	plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h
	plugins/sftp/sftpplugin.cpp
 2015-01-20 22:44:31 -08:00
Albert Vaca
da1cb4c354 Coding style 2015-01-20 22:22:14 -08:00
Aleix Pol
968ccb22c6 Port away from deprecated setRoleNames 2014-09-23 19:27:47 +02:00
Albert Vaca
d72ebc4cf7 Workaround to make devices be correctly filtered again. 
Flags in QML are not working correctly (as they are in Qt5), so we will
use integer values for the flags for now.
 2014-07-01 01:26:07 +02:00
Aleix Pol
446dbbc230 Remove IsPairedRole 
It was not a good idea
 2014-06-27 16:16:45 +02:00
Aleix Pol
e227c61cf8 Expose flags so that the plasmoid doesn't need to use magic numbers 2014-06-27 16:09:01 +02:00
Aleix Pol
dc2f9c0f3c Introduce a IsPaired role in the DevicesModel 
Reviewed by Albert Vaca
 2014-06-23 18:13:43 +02:00
Aleix Pol
b7420146eb Expose the icon name from the device instance 2014-06-14 19:42:34 +02:00
Aleix Pol
b88897847b Reorganize sources 
We broke kded into core and kded, core contains the library with the backends
and plugins.
Also we renamed libkdeconnect to interfaces.
 2014-06-14 15:22:40 +02:00
Renamed from libkdeconnect/devicesmodel.h (Browse further)