Commit graph

13 commits

Author SHA1 Message Date
Fabian Arndt
b24d629802 virtualmonitor: implemented capabilities check
BUG: 485829

## Summary

Currently, the plugin just fails silently if the local device is missing the `krfb` package or if the remote device misses an `vnc://` protocol/scheme handler. You click the button and nothing happens.

One issue is, that the plugin is considered `virtualmonitor.available` in the `DeviceDelegate.qml`, even if the check for `krfb-virtualmonitor` fails and no dbus-path is provided. I investigated the behavior a bit, but ignored it in the end as this MR benefits from being shown for device constellations that _could_ provide this feature.

A warning is shown with brief instructions, how to get the plugin working correctly.

- Check if krfb-virtualmonitor is available locally
- Check default scheme handler for vnc:// on device (Linux)
- Show warnings / reasons, if no connection could be established


## Test Plan

Regarding if the devices have mentioned packages installed, we should see different behaviors.

If the remote device has no VNC client, it can not connect to out server. _A warning should be shown._

If the local device hasn't the `krfb-virtualmonitor` available, the remote device couldn't connect. _A warning should be shown._

If both problems are present, _both warnings should be shown._


If none of these are present, no warning should be shown and we should try to establish a connection.


The connection attempts failed? _A warning should be shown._
2024-05-30 23:13:54 +00:00
Aleix Pol
2bd8a00aaf declarative: Fix error message
There's no write property here, also print the actual error message.
2024-04-21 17:11:11 +02:00
Alexander Lohnau
7b15a5eab7 Fix warnings about old style QML connections 2023-07-22 16:03:24 +02:00
Alexander Lohnau
131ed9a079 Port away from deprecated signal param injection 2023-07-20 11:16:04 +03:00
Aleix Pol
b61ba29673 remotekeyboard: Move workaround to the c++ side and make it more generic
The QKeyEvent::text we get from a Ctrl+W press is a weird unicode
charcater for ^W (see comment). We don't deal with that thing, create
the controlled letter using QKeySequence and move on.
2023-05-22 17:43:27 +00:00
ivan tkachenko
4b6caf9af4
Port away from deprecated QML features 2022-09-21 01:14:37 +03:00
ivan tkachenko
abd088a375
Port Connections to function syntax 2022-08-16 22:58:45 +03:00
Nate Graham
b00acad77b Remove unused Plasma imports in RemoteKeyboard.qml 2021-04-15 12:58:17 -06:00
Nicolas Fella
87db95b22f Convert license headers to SPDX expressions 2020-08-17 09:48:10 +00:00
Nicolas Fella
3b8fedea1a Replace http GNU urls with https 2019-03-23 17:29:26 +01:00
Nicolas Fella
952da637b0 Share RemoteKeyboard implementation
Summary: Extract RemoteKeyboard.qml into declarativeplugin to be able to use it from both plasmoid and app without code duplication

Reviewers: #kde_connect, hkaelberer, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect, mtijink, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12670
2018-11-08 02:20:34 +01:00
Nicolas Fella
e4385042eb Show icons in plugin list
Summary:
Show the plugin's icons in the list

Depends on D14567

{F6172885}

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14571
2018-08-03 02:25:39 +02:00
Nicolas Fella
d9f427aaeb Move declarativeplugin to top-level dir
Summary: It's not only used by the plasmoid any more but also SFOS and the app use it.

Test Plan: Builds, App runs fine

Reviewers: #kde_connect, piggz, apol

Reviewed By: #kde_connect, piggz, apol

Subscribers: piggz, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D14567
2018-08-03 02:24:58 +02:00