tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't use QObject for Conversationmessage

Browse source
This commit is contained in:
Nicolas Fella 2019-03-21 17:42:27 +00:00
parent 76be5a17b6
commit fa66a714d1
2 changed files with 10 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
interfaces/conversationmessage.cpp
View file

@ -23,9 +23,8 @@
#include <QVariantMap>
ConversationMessage::ConversationMessage(const QVariantMap& args, QObject* parent)
: QObject(parent),
m_eventField(args["event"].toInt()),
ConversationMessage::ConversationMessage(const QVariantMap& args)
: m_eventField(args["event"].toInt()),
m_body(args["body"].toString()),
m_address(args["address"].toString()),
m_date(args["date"].toLongLong()),
@ -40,10 +39,8 @@ ConversationMessage::ConversationMessage (const qint32& eventField, const QStrin
const QString& address, const qint64& date,
const qint32& type, const qint32& read,
const qint64& threadID,
const qint32& uID,
QObject* parent)
: QObject(parent)
, m_eventField(eventField)
const qint32& uID)
: m_eventField(eventField)
, m_body(body)
, m_address(address)
, m_date(date)
@ -54,9 +51,8 @@ ConversationMessage::ConversationMessage (const qint32& eventField, const QStrin
{
}
ConversationMessage::ConversationMessage(const ConversationMessage& other, QObject* parent)
: QObject(parent)
, m_eventField(other.m_eventField)
ConversationMessage::ConversationMessage(const ConversationMessage& other)
: m_eventField(other.m_eventField)
, m_body(other.m_body)
, m_address(other.m_address)
, m_date(other.m_date)

24
interfaces/conversationmessage.h
View file

@ -21,25 +21,12 @@
#ifndef PLUGINS_TELEPHONY_CONVERSATIONMESSAGE_H_
#define PLUGINS_TELEPHONY_CONVERSATIONMESSAGE_H_
#include <QObject>
#include <QDBusMetaType>
#include <QDBusArgument>
#include <QVariantMap>
#include "interfaces/kdeconnectinterfaces_export.h"
class KDECONNECTINTERFACES_EXPORT ConversationMessage
: public QObject {
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.telephony.messages")
Q_PROPERTY(qint32 eventField READ eventField)
Q_PROPERTY(QString body READ body)
Q_PROPERTY(QString address READ address)
Q_PROPERTY(qint64 date READ date)
Q_PROPERTY(qint32 type READ type)
Q_PROPERTY(qint32 read READ read)
Q_PROPERTY(qint64 threadID READ threadID)
Q_PROPERTY(qint32 uID READ uID)
{
public:
// TYPE field values from Android
@ -52,7 +39,6 @@ public:
MessageTypeFailed = 5,
MessageTypeQueued = 6,
};
Q_ENUM(Types);
/**
* Values describing the possible type of events contained in a message
@ -62,21 +48,19 @@ public:
enum Events {
EventTextMessage = 0x1, // This message has a body field which contains pure, human-readable text
};
Q_ENUM(Events)
/**
* Build a new message from a keyword argument dictionary
*
* @param args mapping of field names to values as might be contained in a network packet containing a message
*/
ConversationMessage(const QVariantMap& args = QVariantMap(), QObject* parent = Q_NULLPTR);
ConversationMessage(const QVariantMap& args = QVariantMap());
ConversationMessage(const qint32& eventField, const QString& body, const QString& address,
const qint64& date, const qint32& type, const qint32& read,
const qint64& threadID, const qint32& uID,
QObject* parent = Q_NULLPTR);
const qint64& threadID, const qint32& uID);
ConversationMessage(const ConversationMessage& other, QObject* parent = Q_NULLPTR);
ConversationMessage(const ConversationMessage& other);
~ConversationMessage();
ConversationMessage& operator=(const ConversationMessage& other);
static void registerDbusType();