tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Escape HTML Characters in Notifications.

Browse source 
REVIEW: 130114
This commit is contained in:
Nicolas Fella 2017-05-07 20:22:57 +02:00 committed by Albert Vaca
parent f0010763e7
commit ec2b794ffb
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
plugins/notifications/notification.cpp
View file

@ -82,18 +82,22 @@ KNotification* Notification::createKNotification(bool update, const NetworkPacka
mNotification->setComponentName(QStringLiteral("kdeconnect")); mNotification->setComponentName(QStringLiteral("kdeconnect"));
} }
mNotification->setTitle(mAppName); QString escapedTitle = mTitle.toHtmlEscaped();
QString escapedText = mText.toHtmlEscaped();
QString escapedTicker = mTicker.toHtmlEscaped();
mNotification->setTitle(mAppName.toHtmlEscaped());
if (mTitle.isEmpty() && mText.isEmpty()) { if (mTitle.isEmpty() && mText.isEmpty()) {
mNotification->setText(mTicker); mNotification->setText(escapedTicker);
} else if (mAppName==mTitle) { } else if (mAppName==mTitle) {
mNotification->setText(mText); mNotification->setText(escapedText);
} else if (mTitle.isEmpty()){ } else if (mTitle.isEmpty()){
mNotification->setText(mText); mNotification->setText(escapedText);
} else if (mText.isEmpty()){ } else if (mText.isEmpty()){
mNotification->setText(mTitle); mNotification->setText(escapedTitle);
} else { } else {
mNotification->setText(mTitle+": "+mText); mNotification->setText(escapedTitle+": "+escapedText);
} }
if (!mHasIcon) { if (!mHasIcon) {