diff --git a/core/kdeconnectplugin.h b/core/kdeconnectplugin.h index 9a0169fa5..86accef0c 100644 --- a/core/kdeconnectplugin.h +++ b/core/kdeconnectplugin.h @@ -52,7 +52,9 @@ public Q_SLOTS: * This method will be called when a device is connected to this computer. * The plugin could be loaded already, but there is no guarantee we will be able to reach the device until this is called. */ - virtual void connected() = 0; + virtual void connected() + { + } private: QScopedPointer d; diff --git a/plugins/bigscreen/bigscreenplugin.h b/plugins/bigscreen/bigscreenplugin.h index d1d67d25c..d1e135596 100644 --- a/plugins/bigscreen/bigscreenplugin.h +++ b/plugins/bigscreen/bigscreenplugin.h @@ -21,7 +21,6 @@ public: explicit BigscreenPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override{}; QString dbusPath() const override; Q_SIGNALS: diff --git a/plugins/connectivity-report/connectivity_reportplugin.cpp b/plugins/connectivity-report/connectivity_reportplugin.cpp index 90c73ef85..3559de98d 100644 --- a/plugins/connectivity-report/connectivity_reportplugin.cpp +++ b/plugins/connectivity-report/connectivity_reportplugin.cpp @@ -30,10 +30,6 @@ int ConnectivityReportPlugin::cellularNetworkStrength() const return m_cellularNetworkStrength; } -void ConnectivityReportPlugin::connected() -{ -} - bool ConnectivityReportPlugin::receivePacket(const NetworkPacket &np) { if (PACKET_TYPE_CONNECTIVITY_REPORT != np.type()) { diff --git a/plugins/connectivity-report/connectivity_reportplugin.h b/plugins/connectivity-report/connectivity_reportplugin.h index 92d26bebb..f1adff5d7 100644 --- a/plugins/connectivity-report/connectivity_reportplugin.h +++ b/plugins/connectivity-report/connectivity_reportplugin.h @@ -43,7 +43,6 @@ public: explicit ConnectivityReportPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override; QString dbusPath() const override; QString cellularNetworkType() const; diff --git a/plugins/findmyphone/findmyphoneplugin.h b/plugins/findmyphone/findmyphoneplugin.h index 95c4aad1f..bd603ca47 100644 --- a/plugins/findmyphone/findmyphoneplugin.h +++ b/plugins/findmyphone/findmyphoneplugin.h @@ -24,9 +24,6 @@ public: Q_SCRIPTABLE void ring(); QString dbusPath() const override; - void connected() override - { - } bool receivePacket(const NetworkPacket &np) override; }; diff --git a/plugins/findthisdevice/findthisdeviceplugin.h b/plugins/findthisdevice/findthisdeviceplugin.h index 340d8798e..de54f91ee 100644 --- a/plugins/findthisdevice/findthisdeviceplugin.h +++ b/plugins/findthisdevice/findthisdeviceplugin.h @@ -31,7 +31,6 @@ class FindThisDevicePlugin : public KdeConnectPlugin public: explicit FindThisDevicePlugin(QObject *parent, const QVariantList &args); - void connected() override{}; QString dbusPath() const override; bool receivePacket(const NetworkPacket &np) override; }; diff --git a/plugins/mmtelephony/mmtelephonyplugin.h b/plugins/mmtelephony/mmtelephonyplugin.h index 9b148d37f..aca07efbb 100644 --- a/plugins/mmtelephony/mmtelephonyplugin.h +++ b/plugins/mmtelephony/mmtelephonyplugin.h @@ -39,9 +39,6 @@ public: ~MMTelephonyPlugin() override = default; bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private: void onCallAdded(ModemManager::Call::Ptr call); diff --git a/plugins/mpriscontrol/mpriscontrolplugin-win.h b/plugins/mpriscontrol/mpriscontrolplugin-win.h index cda27a7d5..2db29abd6 100644 --- a/plugins/mpriscontrol/mpriscontrolplugin-win.h +++ b/plugins/mpriscontrol/mpriscontrolplugin-win.h @@ -34,9 +34,6 @@ public: explicit MprisControlPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private: std::optional sessionManager; diff --git a/plugins/mpriscontrol/mpriscontrolplugin.h b/plugins/mpriscontrol/mpriscontrolplugin.h index 69b21d903..5e0e44b0d 100644 --- a/plugins/mpriscontrol/mpriscontrolplugin.h +++ b/plugins/mpriscontrol/mpriscontrolplugin.h @@ -53,9 +53,6 @@ public: explicit MprisControlPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private Q_SLOTS: void propertiesChanged(const QString &propertyInterface, const QVariantMap &properties); diff --git a/plugins/mprisremote/mprisremoteplugin.h b/plugins/mprisremote/mprisremoteplugin.h index b07638050..a7fe94831 100644 --- a/plugins/mprisremote/mprisremoteplugin.h +++ b/plugins/mprisremote/mprisremoteplugin.h @@ -50,9 +50,6 @@ public: void setPlayer(const QString &player); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override; Q_SCRIPTABLE void seek(int offset) const; diff --git a/plugins/pausemusic/pausemusicplugin-win.h b/plugins/pausemusic/pausemusicplugin-win.h index 7fdb80341..1111eeb4b 100644 --- a/plugins/pausemusic/pausemusicplugin-win.h +++ b/plugins/pausemusic/pausemusicplugin-win.h @@ -35,9 +35,6 @@ public: ~PauseMusicPlugin(); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private: void updatePlayersList(); diff --git a/plugins/pausemusic/pausemusicplugin.h b/plugins/pausemusic/pausemusicplugin.h index ad399812c..321bb7b5b 100644 --- a/plugins/pausemusic/pausemusicplugin.h +++ b/plugins/pausemusic/pausemusicplugin.h @@ -21,9 +21,6 @@ public: explicit PauseMusicPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private: QSet pausedSources; diff --git a/plugins/photo/photoplugin.h b/plugins/photo/photoplugin.h index 582fee32d..c3bd08c8f 100644 --- a/plugins/photo/photoplugin.h +++ b/plugins/photo/photoplugin.h @@ -25,9 +25,6 @@ public: Q_SCRIPTABLE void requestPhoto(const QString &url); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override; diff --git a/plugins/ping/pingplugin.h b/plugins/ping/pingplugin.h index 34fca908a..03dd3ceaf 100644 --- a/plugins/ping/pingplugin.h +++ b/plugins/ping/pingplugin.h @@ -26,10 +26,6 @@ public: Q_SCRIPTABLE void sendPing(const QString &customMessage); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } - QString dbusPath() const override; }; diff --git a/plugins/presenter/presenterplugin.h b/plugins/presenter/presenterplugin.h index d66495390..3f99839da 100644 --- a/plugins/presenter/presenterplugin.h +++ b/plugins/presenter/presenterplugin.h @@ -25,9 +25,6 @@ class Q_DECL_EXPORT PresenterPlugin : public KdeConnectPlugin public: explicit PresenterPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } private: QPointer m_view; diff --git a/plugins/remotecontrol/remotecontrolplugin.h b/plugins/remotecontrol/remotecontrolplugin.h index 8da1946ec..2bb1b742a 100644 --- a/plugins/remotecontrol/remotecontrolplugin.h +++ b/plugins/remotecontrol/remotecontrolplugin.h @@ -25,9 +25,6 @@ public: { return false; } - void connected() override - { - } QString dbusPath() const override; Q_SCRIPTABLE void moveCursor(const QPoint &p); diff --git a/plugins/remotekeyboard/remotekeyboardplugin.cpp b/plugins/remotekeyboard/remotekeyboardplugin.cpp index d24a0191b..229b90383 100644 --- a/plugins/remotekeyboard/remotekeyboardplugin.cpp +++ b/plugins/remotekeyboard/remotekeyboardplugin.cpp @@ -121,10 +121,6 @@ int RemoteKeyboardPlugin::translateQtKey(int qtKey) const return specialKeysMap.value(qtKey, 0); } -void RemoteKeyboardPlugin::connected() -{ -} - QString RemoteKeyboardPlugin::dbusPath() const { return QStringLiteral("/modules/kdeconnect/devices/") + device()->id() + QStringLiteral("/remotekeyboard"); diff --git a/plugins/remotekeyboard/remotekeyboardplugin.h b/plugins/remotekeyboard/remotekeyboardplugin.h index f5001fa3d..507ba14fe 100644 --- a/plugins/remotekeyboard/remotekeyboardplugin.h +++ b/plugins/remotekeyboard/remotekeyboardplugin.h @@ -31,7 +31,6 @@ public: bool receivePacket(const NetworkPacket &np) override; QString dbusPath() const override; - void connected() override; bool remoteState() const { diff --git a/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.cpp b/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.cpp index 832a15a2e..50e785b19 100644 --- a/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.cpp +++ b/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.cpp @@ -33,10 +33,6 @@ ScreensaverInhibitPlugin::~ScreensaverInhibitPlugin() } } -void ScreensaverInhibitPlugin::connected() -{ -} - bool ScreensaverInhibitPlugin::receivePacket(const NetworkPacket &np) { Q_UNUSED(np); diff --git a/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.h b/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.h index 2c826bcbe..b36f41e46 100644 --- a/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.h +++ b/plugins/screensaver-inhibit/screensaverinhibitplugin-macos.h @@ -21,7 +21,6 @@ public: ~ScreensaverInhibitPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override; private: QProcess *m_caffeinateProcess; diff --git a/plugins/screensaver-inhibit/screensaverinhibitplugin-win.h b/plugins/screensaver-inhibit/screensaverinhibitplugin-win.h index 2552de041..8185574e6 100644 --- a/plugins/screensaver-inhibit/screensaverinhibitplugin-win.h +++ b/plugins/screensaver-inhibit/screensaverinhibitplugin-win.h @@ -20,7 +20,6 @@ public: ~ScreensaverInhibitPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override{}; }; #endif diff --git a/plugins/screensaver-inhibit/screensaverinhibitplugin.cpp b/plugins/screensaver-inhibit/screensaverinhibitplugin.cpp index 61c53037a..9dd3acf6d 100644 --- a/plugins/screensaver-inhibit/screensaverinhibitplugin.cpp +++ b/plugins/screensaver-inhibit/screensaverinhibitplugin.cpp @@ -42,10 +42,6 @@ ScreensaverInhibitPlugin::~ScreensaverInhibitPlugin() inhibitInterface.SimulateUserActivity(); } -void ScreensaverInhibitPlugin::connected() -{ -} - bool ScreensaverInhibitPlugin::receivePacket(const NetworkPacket &np) { Q_UNUSED(np); diff --git a/plugins/screensaver-inhibit/screensaverinhibitplugin.h b/plugins/screensaver-inhibit/screensaverinhibitplugin.h index bf2ecae2d..eebe2f015 100644 --- a/plugins/screensaver-inhibit/screensaverinhibitplugin.h +++ b/plugins/screensaver-inhibit/screensaverinhibitplugin.h @@ -20,7 +20,6 @@ public: ~ScreensaverInhibitPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override; private: uint inhibitCookie; diff --git a/plugins/sendnotifications/sendnotificationsplugin.cpp b/plugins/sendnotifications/sendnotificationsplugin.cpp index 5b790cadd..9164f798d 100644 --- a/plugins/sendnotifications/sendnotificationsplugin.cpp +++ b/plugins/sendnotifications/sendnotificationsplugin.cpp @@ -30,8 +30,4 @@ bool SendNotificationsPlugin::receivePacket(const NetworkPacket &np) return true; } -void SendNotificationsPlugin::connected() -{ -} - #include "sendnotificationsplugin.moc" diff --git a/plugins/sendnotifications/sendnotificationsplugin.h b/plugins/sendnotifications/sendnotificationsplugin.h index 90986fdcb..2edb98e40 100644 --- a/plugins/sendnotifications/sendnotificationsplugin.h +++ b/plugins/sendnotifications/sendnotificationsplugin.h @@ -28,7 +28,6 @@ public: ~SendNotificationsPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override; protected: NotificationsListener *notificationsListener; diff --git a/plugins/sftp/sftpplugin-win.h b/plugins/sftp/sftpplugin-win.h index 67185a39a..16094cc6e 100644 --- a/plugins/sftp/sftpplugin-win.h +++ b/plugins/sftp/sftpplugin-win.h @@ -24,9 +24,6 @@ public: explicit SftpPlugin(QObject *parent, const QVariantList &args); bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override { return QStringLiteral("/modules/kdeconnect/devices/") + deviceId + QStringLiteral("/sftp"); diff --git a/plugins/sftp/sftpplugin.h b/plugins/sftp/sftpplugin.h index 670d8f0cb..1ac25c7f2 100644 --- a/plugins/sftp/sftpplugin.h +++ b/plugins/sftp/sftpplugin.h @@ -22,9 +22,6 @@ public: ~SftpPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override { return QStringLiteral("/modules/kdeconnect/devices/") + deviceId + QStringLiteral("/sftp"); diff --git a/plugins/share/shareplugin.h b/plugins/share/shareplugin.h index 2a5a3fd00..fd87e62f8 100644 --- a/plugins/share/shareplugin.h +++ b/plugins/share/shareplugin.h @@ -36,9 +36,6 @@ public: } bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override; private Q_SLOTS: diff --git a/plugins/sms/smsplugin.h b/plugins/sms/smsplugin.h index 9f9d9e0b5..66a9b2d18 100644 --- a/plugins/sms/smsplugin.h +++ b/plugins/sms/smsplugin.h @@ -148,9 +148,6 @@ public: ~SmsPlugin() override; bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override; diff --git a/plugins/telephony/telephonyplugin.h b/plugins/telephony/telephonyplugin.h index 31aee1ed9..231e85df2 100644 --- a/plugins/telephony/telephonyplugin.h +++ b/plugins/telephony/telephonyplugin.h @@ -40,9 +40,6 @@ public: ~TelephonyPlugin() override = default; bool receivePacket(const NetworkPacket &np) override; - void connected() override - { - } QString dbusPath() const override; public: